All of lore.kernel.org
 help / color / mirror / Atom feed
From: Trevor Woerner <twoerner@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: [PATCH v2 3/3] nativesdk-packagegroup-sdk-host: optionally add wic
Date: Tue,  7 Jul 2026 10:40:09 -0400	[thread overview]
Message-ID: <20260707144009.708407-4-twoerner@gmail.com> (raw)
In-Reply-To: <20260707144009.708407-1-twoerner@gmail.com>

wic is useful from an installed SDK for assembling or inspecting a wic
image, but adding it is not free: nativesdk-wic pulls in the long list
of host-side tools it might need (parted, gptfdisk, dosfstools, mtools,
bmaptool, grub, btrfs-tools, squashfs-tools, e2fsprogs, util-linux,
tar, erofs-utils, and syslinux on x86). Most SDKs do not need any of
that, so it should not be forced into the host packagegroup
unconditionally.

Add an SDK_INCLUDE_WIC knob, defaulting to "no", that gates
nativesdk-wic in the host packagegroup. A configuration that wants wic
in its SDK opts in with

  SDK_INCLUDE_WIC = "yes"

and gets a working wic, together with the tools it invokes, in the SDK;
the default SDK is unchanged.

AI-Generated: codex/claude-opus 4.8 (xhigh)
Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
 .../packagegroups/nativesdk-packagegroup-sdk-host.bb        | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
index 51e48f250b19..37218824171f 100644
--- a/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
+++ b/meta/recipes-core/packagegroups/nativesdk-packagegroup-sdk-host.bb
@@ -9,6 +9,11 @@ inherit_defer nativesdk
 
 PACKAGEGROUP_DISABLE_COMPLEMENTARY = "1"
 
+# wic is useful from an installed SDK for assembling or inspecting a wic
+# image, but it is not needed by every SDK, so it is opt-in. Set
+# SDK_INCLUDE_WIC = "yes" to add it (it pulls in the tools it invokes).
+SDK_INCLUDE_WIC ?= "no"
+
 # autoconf pulls in nativesdk-perl but perl-module-integer is needed to 
 # build some recent linux kernels (5.14+) for arm
 RDEPENDS:${PN} = "\
@@ -29,6 +34,7 @@ RDEPENDS:${PN} = "\
     nativesdk-bison \
     nativesdk-flex \
     nativesdk-perl-module-integer \
+    ${@'nativesdk-wic' if bb.utils.to_boolean(d.getVar('SDK_INCLUDE_WIC')) else ''} \
     "
 
 RDEPENDS:${PN}:darwin = "\
-- 
2.50.0.173.g8b6f19ccfc3a



      parent reply	other threads:[~2026-07-07 14:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07 14:40 [PATCH v2 0/3] wic: give installed wic the tools it needs Trevor Woerner
2026-07-07 14:40 ` [PATCH v2 1/3] wic: add runtime dependencies on the tools it invokes Trevor Woerner
2026-07-07 14:40 ` [PATCH v2 2/3] buildtools-extended-tarball: drop wic helper tools Trevor Woerner
2026-07-07 14:40 ` Trevor Woerner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260707144009.708407-4-twoerner@gmail.com \
    --to=twoerner@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.