Re: [PATCH v3 9/9] arm64: dts: renesas: r9a08g046l48-smarc: Add USB2.0 support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Using `module_platform_driver()` twice in the same C file causes a build failure due to the redefinition of `init_module` and `cleanup_module`.
--

--- Patch [9]: [PATCH v3 9/9] arm64: dts: renesas: r9a08g046l48-smarc: Add USB2.0 support ---
commit 5af51dcc7dc2267ce2a724cd23f6ac8e1361e710
Author: Biju Das <biju.das.jz@bp.renesas.com>

regulator: renesas-usb-vbus-regulator: Add RZ/G3L VBUS regulator support

This commit adds dual USB VBUS regulator support for the RZ/G3L SoC. It
introduces an array of regulator descriptors and a dedicated probe
function to register both regulators. A new platform driver is also added
to handle this dual regulator configuration.

> diff --git a/drivers/regulator/renesas-usb-vbus-regulator.c b/drivers/regulator/renesas-usb-vbus-regulator.c
> index 9ba791bd72eca..9028340008749 100644
> --- a/drivers/regulator/renesas-usb-vbus-regulator.c
> +++ b/drivers/regulator/renesas-usb-vbus-regulator.c

[ ... ]

> @@ -64,6 +108,15 @@ static struct platform_driver rzg2l_usb_vbus_regulator_driver = {
>  };
>  module_platform_driver(rzg2l_usb_vbus_regulator_driver);
>  
> +static struct platform_driver rzg3l_usb_vbus_regulator_driver = {
> +	.probe = rzg3l_usb_vbus_regulator_probe,
> +	.driver	= {
> +		.name = "rzg3l-usb-vbus-regulator",
> +		.probe_type = PROBE_PREFER_ASYNCHRONOUS,
> +	},
> +};
> +module_platform_driver(rzg3l_usb_vbus_regulator_driver);

[Severity: Low]
Will this regression cause a build failure when the driver is compiled as a
module?

Using module_platform_driver() twice in the same C file expands into
module_init() and module_exit() twice.

This creates conflicting global aliases for init_module and cleanup_module,
causing the compiler to flag a redefinition error.

Could these drivers be registered with a custom module_init() function
that registers both, or perhaps combined into a single driver using match data?

> +
>  MODULE_AUTHOR("Biju Das <biju.das.jz@bp.renesas.com>");
>  MODULE_DESCRIPTION("Renesas RZ/G2L USB Vbus Regulator Driver");
>  MODULE_LICENSE("GPL");

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707143646.245177-1-biju.das.jz@bp.renesas.com?part=9