From: Greg KH <gregkh@linuxfoundation.org>
To: "Diego Fernando Mancera Gómez" <diegomancera.dev@gmail.com>
Cc: linux-staging@lists.linux.dev, m.steinmoetzger@gmail.com,
guojy.bj@gmail.com, straube.linux@gmail.com, error27@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: rtl8723bs: clean up if-else logic in odm_HWConfig.c
Date: Tue, 7 Jul 2026 11:52:31 +0200 [thread overview]
Message-ID: <2026070715-polyester-recycling-fb55@gregkh> (raw)
In-Reply-To: <20260522054624.190256-1-diegomancera.dev@gmail.com>
On Thu, May 21, 2026 at 11:46:24PM -0600, Diego Fernando Mancera Gómez wrote:
> Refactored redundant if-else blocks to a cleaner else-if structure in
> odm_HWConfig.c and fixed indentation to use tabs as required by the
> kernel coding style.
>
> Signed-off-by: Diego Fernando Mancera Gómez <diegomancera.dev@gmail.com>
> ---
> v3: Restored accidentally removed comments and blank line.
> v2: Added commit body description and Signed-off-by tag.
> v1: Initial cleanup of if-else logic.
>
> drivers/staging/rtl8723bs/hal/odm_HWConfig.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> index c88d669cb086..abf3d96746b9 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> +++ b/drivers/staging/rtl8723bs/hal/odm_HWConfig.c
> @@ -227,19 +227,16 @@ static void odm_rx_phy_status_parsing(struct dm_odm_t *dm_odm,
>
> odm_parsing_cfo(dm_odm, pkt_info, phy_sta_rpt->path_cfotail);
> }
> -
> /*
Why did you delete this blank line?
thanks,
greg k-h
prev parent reply other threads:[~2026-07-07 9:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 5:46 [PATCH v3] staging: rtl8723bs: clean up if-else logic in odm_HWConfig.c Diego Fernando Mancera Gómez
2026-05-22 5:48 ` Dan Carpenter
2026-07-07 9:52 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070715-polyester-recycling-fb55@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=diegomancera.dev@gmail.com \
--cc=error27@gmail.com \
--cc=guojy.bj@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=m.steinmoetzger@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.