From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E919C43458 for ; Tue, 7 Jul 2026 16:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XnDXo1UyV4tAZq03SbfrqImzPkKBLUDpMs9f1ZBZUfw=; b=xa27PG+hyGY/of +RQRzdQiBqPfXqbHNuf4U/3pettrogeFF7crx5wfPPPAob/vA2A6z6M8yDUfUDb0icS8x93FvgN8h bAZ7A+zQSdlctsULaC8xwSeag1GFyhXpiTAiwj96Jp49kwlCdoHGMlPORO7qfwlBv/52pOGguosqG PRlNaC8zwB+iFj3Dp3s2/P+u6eToEOppyWLg0DVQxmU5m0LqNFakk+nMkav7aEeUKm6+ovQfOtRBt 1z8r+hV57JJ9Jyue9TdISq43L36qawF1H4CG2fbtoFFbNDW7gsGXkE7ESv79eZmi3eFMza16r5epb wolhl6FZhUtTjwlTdbGg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh8Jt-0000000FQV7-0Myk; Tue, 07 Jul 2026 16:06:49 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wh8Jr-0000000FQUx-3nlE for linux-phy@lists.infradead.org; Tue, 07 Jul 2026 16:06:48 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 460AF60018; Tue, 7 Jul 2026 16:06:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 813771F000E9; Tue, 7 Jul 2026 16:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783440407; bh=L5y+zUPinxjtVfco8HA4/kOWa/nb9LJmepf6+tT3NBY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fBDYi1zGE7lf4Blqh7AGdmstS6BNHwbUlm21DQ1dz+mK03zfb1ZPwQM0DyOwzhChE uZL6yI19C0Nmz6mjClnAAzrwgzPLTo/cwyNspErpwAt+MxEBctJumAse1eQvmDohkE PwP6fkEj11lvde6jy6Zr2Wz1mj8ghRhN0LAIsQH37SQbT1PYUMQNacHIFEPEyqg7jK /t6EdzTj5cXvDyVsxerjN65IX6J9KExgkXXrWqkGAoNKYPKP7ACtJeaEHOvUSLBiNb vMKVwNJKFaNKGz1Ra4hqYrOHnEWVI1y9os8RRb/py1Qy9/uSZbwYMhXmp2M7xvgh5d Z4q5of08j19VA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 03/12] phy: phy-mtk-dp: Allow probing with devicetree match To: "AngeloGioacchino Del Regno" Cc: vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, linux-phy@lists.infradead.org, conor+dt@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, robh@kernel.org In-Reply-To: <20260707154245.198361-4-angelogioacchino.delregno@collabora.com> References: <20260707154245.198361-1-angelogioacchino.delregno@collabora.com> <20260707154245.198361-4-angelogioacchino.delregno@collabora.com> Date: Tue, 07 Jul 2026 16:06:46 +0000 Message-Id: <20260707160646.813771F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpOZXcgaXNzdWVzOgotIFtIaWdoXSBI YXJkY29kZWQgYFBIWV9PRkZTRVRgIGNhdXNlcyBvdXQtb2YtYm91bmRzIHJlZ2lzdGVyIGFjY2Vz c2VzIG9yIHJlc291cmNlIGNvbmZsaWN0cyB3aGVuIHRoZSBQSFkgaXMgcHJvYmVkIGFzIGEgc3Rh bmRhbG9uZSBkZXZpY2V0cmVlIG5vZGUuCi0gW0hpZ2hdIEhhcmR3YXJlIHJlZ2lzdGVycyBhcmUg YWNjZXNzZWQgaW4gYG10a19kcF9waHlfY29uZmlndXJlKClgIHdoaWxlIHRoZSBQSFkgZGV2aWNl IGlzIHJ1bnRpbWUtc3VzcGVuZGVkLCBjYXVzaW5nIGEgc3lzdGVtIGNyYXNoIG9yIHNpbGVudCBs b3NzIG9mIGNvbmZpZ3VyYXRpb24uCgpQcmUtZXhpc3RpbmcgaXNzdWVzOgotIFtIaWdoXSBEZXJl ZmVyZW5jaW5nIGBkZXYtPnBsYXRmb3JtX2RhdGFgIGJlZm9yZSBjaGVja2luZyBpZiBpdCBpcyBO VUxMIGxlYWRzIHRvIGEga2VybmVsIGNyYXNoLgotLQoKLS0tIFBhdGNoIFszXTogW1BBVENIIHYz IDAzLzEyXSBwaHk6IHBoeS1tdGstZHA6IEFsbG93IHByb2Jpbmcgd2l0aCBkZXZpY2V0cmVlIG1h dGNoIC0tLQpjb21taXQgNzEwYWI1NDg4ZmQwYjY2YjJlYTYyMzg4Yjk3N2E0MzA4Zjk5YTBjNgpB dXRob3I6IEFuZ2Vsb0dpb2FjY2hpbm8gRGVsIFJlZ25vIDxhbmdlbG9naW9hY2NoaW5vLmRlbHJl Z25vQGNvbGxhYm9yYS5jb20+CgpwaHk6IHBoeS1tdGstZHA6IEFsbG93IHByb2Jpbmcgd2l0aCBk ZXZpY2V0cmVlIG1hdGNoCgpNYWtlIGl0IHBvc3NpYmxlIHRvIGRlY291cGxlIHRoZSByZWdpc3Ry YXRpb24gb2YgdGhlIERpc3BsYXlQb3J0ClBIWSBkcml2ZXIgZnJvbSB0aGUgRGlzcGxheVBvcnQg SVAgZHJpdmVyIGJ5IGFkZGluZyBhIGRldmljZXRyZWUKbWF0Y2ggdG8gcHJvYmUgdGhlIFBIWS4g SW4gb3JkZXIgdG8gcmV0YWluIGNvbXBhdGliaWxpdHkgd2l0aCBvbGRlcgpkZXZpY2V0cmVlcywg dGhlIGxlZ2FjeSBjb2RlIHdhcyBtb3ZlZCBpbiBhIG10a19kcF9waHlfbGVnYWN5X3Byb2JlKCkK ZnVuY3Rpb24uCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLWRw LmMgYi9kcml2ZXJzL3BoeS9tZWRpYXRlay9waHktbXRrLWRwLmMKPiBpbmRleCBiZjdiM2E5NWU3 MmQyLi5kMjQxMDA0ZTI4Mjg2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvcGh5L21lZGlhdGVrL3Bo eS1tdGstZHAuYwo+ICsrKyBiL2RyaXZlcnMvcGh5L21lZGlhdGVrL3BoeS1tdGstZHAuYwpbIC4u LiBdCj4gK3N0YXRpYyBpbnQgbXRrX2RwX3BoeV9sZWdhY3lfcHJvYmUoc3RydWN0IHBsYXRmb3Jt X2RldmljZSAqcGRldiwgc3RydWN0IG10a19kcF9waHkgKmRwX3BoeSkKPiArewo+ICsJc3RydWN0 IGRldmljZSAqZGV2ID0gJnBkZXYtPmRldjsKPiArCXN0cnVjdCBwaHkgKnBoeTsKPiArCWludCBy ZXQ7Cj4gKwo+ICsJZHBfcGh5LT5yZWdtYXAgPSAqKHN0cnVjdCByZWdtYXAgKiopZGV2LT5wbGF0 Zm9ybV9kYXRhOwo+ICsJaWYgKCFkcF9waHktPnJlZ21hcCkKPiArCQlyZXR1cm4gZGV2X2Vycl9w cm9iZShkZXYsIC1FSU5WQUwsICJObyBwbGF0Zm9ybSBkYXRhIGF2YWlsYWJsZVxuIik7CgpbU2V2 ZXJpdHk6IEhpZ2hdClRoaXMgaXMgYSBwcmUtZXhpc3RpbmcgaXNzdWUsIGJ1dCBkb2VzIGNhc3Rp bmcgYW5kIGRlcmVmZXJlbmNpbmcKZGV2LT5wbGF0Zm9ybV9kYXRhIGJlZm9yZSBjaGVja2luZyBp ZiBpdCBpcyBOVUxMIGxlYWQgdG8gYSBrZXJuZWwgY3Jhc2g/CgpJZiB0aGUgZHJpdmVyIGlzIGJv dW5kIHRvIGEgZGV2aWNlIHdpdGhvdXQgcGxhdGZvcm0gZGF0YSB2aWEgc3lzZnMsIHRoaXMKdW52 YWxpZGF0ZWQgcG9pbnRlciB3aWxsIGJlIGRlcmVmZXJlbmNlZCBiZWZvcmUgdGhlIGNoZWNrIGZv cgohZHBfcGh5LT5yZWdtYXAgY2FuIGV4ZWN1dGUuCgpbIC4uLiBdCj4gIHN0YXRpYyBpbnQgbXRr X2RwX3BoeV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICB7Cj4gIAlzdHJ1 Y3QgZGV2aWNlICpkZXYgPSAmcGRldi0+ZGV2OwpbIC4uLiBdCj4gIAlkcF9waHkgPSBkZXZtX2t6 YWxsb2MoZGV2LCBzaXplb2YoKmRwX3BoeSksIEdGUF9LRVJORUwpOwo+ICAJaWYgKCFkcF9waHkp Cj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+IC0JZHBfcGh5LT5yZWdtYXAgPSByZWdzOwo+ICsJ ZHBfcGh5LT5kZXYgPSBkZXY7Cj4gKwo+ICsJLyogSWYgdGhlcmUncyBubyBkZXZpY2V0cmVlLCBn byBmb3IgbGVnYWN5IHBkZXYgcHJvYmUgKi8KPiArCWlmICghZGV2LT5vZl9ub2RlKQo+ICsJCXJl dHVybiBtdGtfZHBfcGh5X2xlZ2FjeV9wcm9iZShwZGV2LCBkcF9waHkpOwo+ICsKPiArCWJhc2Ug PSBkZXZtX3BsYXRmb3JtX2lvcmVtYXBfcmVzb3VyY2UocGRldiwgMCk7Cj4gKwlpZiAoSVNfRVJS KGJhc2UpKQo+ICsJCXJldHVybiBQVFJfRVJSKGJhc2UpOwo+ICsKPiArCWRwX3BoeS0+cmVnbWFw ID0gZGV2bV9yZWdtYXBfaW5pdF9tbWlvKGRldiwgYmFzZSwgJm10a19kcF9waHlfcmVnbWFwX2Nm Zyk7CgpbU2V2ZXJpdHk6IEhpZ2hdClNpbmNlIHRoZSBkcml2ZXIgaGFyZGNvZGVzIFBIWV9PRkZT RVQgKDB4MTAwMCkgaW50byBpdHMgcmVnaXN0ZXIgbWFjcm9zIGxpa2UKTVRLX0RQX1BIWV9ESUdf UExMX0NUTF8xLCB3aWxsIHRoaXMgaW5kZXBlbmRlbnQgcmVnbWFwIGNhdXNlIG91dC1vZi1ib3Vu ZHMKYWNjZXNzZXMgaWYgdGhlIGRldmljZXRyZWUgbWFwcyB0aGUgUEhZIG5vZGUgdG8gaXRzIHRy dWUgcGh5c2ljYWwgYmFzZT8KCklmIHRoZSBkZXZpY2V0cmVlIGluc3RlYWQgc2V0cyB0aGUgUEhZ IG5vZGUncyByZWcgdG8gdGhlIHBhcmVudCBEUCBJUCBiYXNlIHRvCmNvdW50ZXJhY3QgdGhpcyBv ZmZzZXQsIHdvbid0IHRoaXMgY2F1c2UgZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlKCkg dG8KZmFpbCB3aXRoIC1FQlVTWSBkdWUgdG8gcmVzb3VyY2UgY29uZmxpY3RzIGJldHdlZW4gdGhl IFBIWSBkcml2ZXIgYW5kIHRoZSBEUApJUCBkcml2ZXI/Cgo+ICsJaWYgKElTX0VSUihkcF9waHkt PnJlZ21hcCkpCj4gKwkJcmV0dXJuIFBUUl9FUlIoZHBfcGh5LT5yZWdtYXApOwo+ICsKPiArCXJl dCA9IGRldm1fcG1fcnVudGltZV9lbmFibGUoZGV2KTsKPiArCWlmIChyZXQpCj4gKwkJcmV0dXJu IHJldDsKCltTZXZlcml0eTogSGlnaF0KQnkgZW5hYmxpbmcgcnVudGltZSBQTSBoZXJlLCBjb3Vs ZCBtdGtfZHBfcGh5X2NvbmZpZ3VyZSgpIGFjY2VzcyBoYXJkd2FyZQpyZWdpc3RlcnMgd2hpbGUg dGhlIFBIWSBkZXZpY2UgaXMgcnVudGltZS1zdXNwZW5kZWQ/CgpUaGUgY29uc3VtZXIgZHJpdmVy IGNhbGxzIHBoeV9jb25maWd1cmUoKSB3aXRob3V0IGNhbGxpbmcgcGh5X3Bvd2VyX29uKCkuClRo ZSBQSFkgZnJhbWV3b3JrIHRha2VzIGEgcnVudGltZSBQTSByZWZlcmVuY2UgZHVyaW5nIC5pbml0 IGFuZCAucmVzZXQsCmJ1dCBleHBsaWNpdGx5IGRyb3BzIGl0IHJpZ2h0IGJlZm9yZSByZXR1cm5p bmcsIGFuZCBkb2VzIG5vdCB0YWtlIGEgcmVmZXJlbmNlCmR1cmluZyAuY29uZmlndXJlLgoKV2hl biB0aGUgY29uc3VtZXIgY2FsbHMgcGh5X2NvbmZpZ3VyZSgpLCBpdCB3cml0ZXMgZGlyZWN0bHkg dG8gaGFyZHdhcmUgdmlhCnJlZ21hcF93cml0ZSgpIGFuZCByZWdtYXBfdXBkYXRlX2JpdHMoKSB3 aGlsZSB0aGUgZGV2aWNlIFBNIHVzYWdlIGNvdW50CmlzIHplcm8uIENhbiB0aGlzIGNyYXNoIHRo ZSBzeXN0ZW0gb3IgY2F1c2Ugc2lsZW50IGxvc3Mgb2YgY29uZmlndXJhdGlvbj8KCj4gKwo+ICAJ cGh5ID0gZGV2bV9waHlfY3JlYXRlKGRldiwgTlVMTCwgJm10a19kcF9waHlfZGV2X29wcyk7Cgot LSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIw MjYwNzA3MTU0MjQ1LjE5ODM2MS0xLWFuZ2Vsb2dpb2FjY2hpbm8uZGVscmVnbm9AY29sbGFib3Jh LmNvbT9wYXJ0PTMKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5p bmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 17C5D2777F3 for ; Tue, 7 Jul 2026 16:06:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783440408; cv=none; b=A/QWrmBm3qtay6E16yYgLaYVceirTvn0/tTn3JHMZAN30L/cPl3NjycyKB2/c8AZTHiEp0xO2AZ7d5RkV8NBUYbmfcwfemLAjV3NwqIU69fgi0ijdbrzq9TKUWWz+Xh6f1Z+ryp2hQFhQ1QuMH/9mkaDx5ySnXCOZbIUet9kMcE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783440408; c=relaxed/simple; bh=0VGHzDYBm0N7ODWWGcxmhraoTwtHm351aNt2Ep1oM6I=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=gf1IVNHmkN3lGsGYN/BA3yWjzPwjTX0+E1xu1iO1b5IODWjrPIUuvkSQNbnpsufRHg9H4sw/jRJklZAcPGUD6n5y5WllraWHXaZwI+6u073YDh2Hlun2DIG6wZGFYlnf2ayRDVQNpL7Jn5HT6QAxb3kGCZjQqlz0ir3MgJZ56eE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=fBDYi1zG; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fBDYi1zG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 813771F000E9; Tue, 7 Jul 2026 16:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783440407; bh=L5y+zUPinxjtVfco8HA4/kOWa/nb9LJmepf6+tT3NBY=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=fBDYi1zGE7lf4Blqh7AGdmstS6BNHwbUlm21DQ1dz+mK03zfb1ZPwQM0DyOwzhChE uZL6yI19C0Nmz6mjClnAAzrwgzPLTo/cwyNspErpwAt+MxEBctJumAse1eQvmDohkE PwP6fkEj11lvde6jy6Zr2Wz1mj8ghRhN0LAIsQH37SQbT1PYUMQNacHIFEPEyqg7jK /t6EdzTj5cXvDyVsxerjN65IX6J9KExgkXXrWqkGAoNKYPKP7ACtJeaEHOvUSLBiNb vMKVwNJKFaNKGz1Ra4hqYrOHnEWVI1y9os8RRb/py1Qy9/uSZbwYMhXmp2M7xvgh5d Z4q5of08j19VA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 03/12] phy: phy-mtk-dp: Allow probing with devicetree match Reply-To: sashiko-reviews@lists.linux.dev To: "AngeloGioacchino Del Regno" Cc: vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com, linux-phy@lists.infradead.org, conor+dt@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, robh@kernel.org In-Reply-To: <20260707154245.198361-4-angelogioacchino.delregno@collabora.com> References: <20260707154245.198361-1-angelogioacchino.delregno@collabora.com> <20260707154245.198361-4-angelogioacchino.delregno@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 07 Jul 2026 16:06:46 +0000 Message-Id: <20260707160646.813771F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: New issues: - [High] Hardcoded `PHY_OFFSET` causes out-of-bounds register accesses or r= esource conflicts when the PHY is probed as a standalone devicetree node. - [High] Hardware registers are accessed in `mtk_dp_phy_configure()` while = the PHY device is runtime-suspended, causing a system crash or silent loss = of configuration. Pre-existing issues: - [High] Dereferencing `dev->platform_data` before checking if it is NULL l= eads to a kernel crash. -- --- Patch [3]: [PATCH v3 03/12] phy: phy-mtk-dp: Allow probing with devicet= ree match --- commit 710ab5488fd0b66b2ea62388b977a4308f99a0c6 Author: AngeloGioacchino Del Regno phy: phy-mtk-dp: Allow probing with devicetree match Make it possible to decouple the registration of the DisplayPort PHY driver from the DisplayPort IP driver by adding a devicetree match to probe the PHY. In order to retain compatibility with older devicetrees, the legacy code was moved in a mtk_dp_phy_legacy_probe() function. > diff --git a/drivers/phy/mediatek/phy-mtk-dp.c b/drivers/phy/mediatek/phy= -mtk-dp.c > index bf7b3a95e72d2..d241004e28286 100644 > --- a/drivers/phy/mediatek/phy-mtk-dp.c > +++ b/drivers/phy/mediatek/phy-mtk-dp.c [ ... ] > +static int mtk_dp_phy_legacy_probe(struct platform_device *pdev, struct = mtk_dp_phy *dp_phy) > +{ > + struct device *dev =3D &pdev->dev; > + struct phy *phy; > + int ret; > + > + dp_phy->regmap =3D *(struct regmap **)dev->platform_data; > + if (!dp_phy->regmap) > + return dev_err_probe(dev, -EINVAL, "No platform data available\n"); [Severity: High] This is a pre-existing issue, but does casting and dereferencing dev->platform_data before checking if it is NULL lead to a kernel crash? If the driver is bound to a device without platform data via sysfs, this unvalidated pointer will be dereferenced before the check for !dp_phy->regmap can execute. [ ... ] > static int mtk_dp_phy_probe(struct platform_device *pdev) > { > struct device *dev =3D &pdev->dev; [ ... ] > dp_phy =3D devm_kzalloc(dev, sizeof(*dp_phy), GFP_KERNEL); > if (!dp_phy) > return -ENOMEM; > =20 > - dp_phy->regmap =3D regs; > + dp_phy->dev =3D dev; > + > + /* If there's no devicetree, go for legacy pdev probe */ > + if (!dev->of_node) > + return mtk_dp_phy_legacy_probe(pdev, dp_phy); > + > + base =3D devm_platform_ioremap_resource(pdev, 0); > + if (IS_ERR(base)) > + return PTR_ERR(base); > + > + dp_phy->regmap =3D devm_regmap_init_mmio(dev, base, &mtk_dp_phy_regmap_= cfg); [Severity: High] Since the driver hardcodes PHY_OFFSET (0x1000) into its register macros like MTK_DP_PHY_DIG_PLL_CTL_1, will this independent regmap cause out-of-bounds accesses if the devicetree maps the PHY node to its true physical base? If the devicetree instead sets the PHY node's reg to the parent DP IP base = to counteract this offset, won't this cause devm_platform_ioremap_resource() to fail with -EBUSY due to resource conflicts between the PHY driver and the DP IP driver? > + if (IS_ERR(dp_phy->regmap)) > + return PTR_ERR(dp_phy->regmap); > + > + ret =3D devm_pm_runtime_enable(dev); > + if (ret) > + return ret; [Severity: High] By enabling runtime PM here, could mtk_dp_phy_configure() access hardware registers while the PHY device is runtime-suspended? The consumer driver calls phy_configure() without calling phy_power_on(). The PHY framework takes a runtime PM reference during .init and .reset, but explicitly drops it right before returning, and does not take a referen= ce during .configure. When the consumer calls phy_configure(), it writes directly to hardware via regmap_write() and regmap_update_bits() while the device PM usage count is zero. Can this crash the system or cause silent loss of configuration? > + > phy =3D devm_phy_create(dev, NULL, &mtk_dp_phy_dev_ops); --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260707154245.1983= 61-1-angelogioacchino.delregno@collabora.com?part=3D3