All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Kai Cheng Jin <kj@kylejin.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	error27@gmail.com
Subject: Re: [PATCH v2 1/3] staging: rtl8723bs: add spaces around operators in rtl8723b_cmd.c
Date: Tue, 7 Jul 2026 13:22:44 +0200	[thread overview]
Message-ID: <2026070718-roundish-cherisher-938c@gregkh> (raw)
In-Reply-To: <20260619201600.973619-1-kj@kylejin.com>

On Fri, Jun 19, 2026 at 01:15:58PM -0700, Kai Cheng Jin wrote:
> Add missing spaces around arithmetic and bitwise operators to
> follow kernel coding style, as reported by checkpatch.pl.
> 
> Signed-off-by: Kai Cheng Jin <kj@kylejin.com>
> ---
>  drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c | 88 ++++++++++----------
>  1 file changed, 44 insertions(+), 44 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> index c35c7f1c38ef..d92dde57b720 100644
> --- a/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_cmd.c
> @@ -70,23 +70,23 @@ s32 FillH2CCmd8723B(struct adapter *padapter, u8 ElementID, u32 CmdLen, u8 *pCmd
>  			goto exit;
>  
>  		if (CmdLen <= 3)
> -			memcpy((u8 *)(&h2c_cmd)+1, pCmdBuffer, CmdLen);
> +			memcpy((u8 *)(&h2c_cmd) + 1, pCmdBuffer, CmdLen);
>  		else {
> -			memcpy((u8 *)(&h2c_cmd)+1, pCmdBuffer, 3);
> -			memcpy((u8 *)(&h2c_cmd_ex), pCmdBuffer+3, CmdLen-3);
> -/* 			*(u8 *)(&h2c_cmd) |= BIT(7); */
> +			memcpy((u8 *)(&h2c_cmd) + 1, pCmdBuffer, 3);
> +			memcpy((u8 *)(&h2c_cmd_ex), pCmdBuffer + 3, CmdLen - 3);
> +/*			*(u8 *)(&h2c_cmd) |= BIT(7); */

What changed on this last line?  That shouldn't have happened :(

      parent reply	other threads:[~2026-07-07 11:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-19  0:25 [PATCH] staging: rtl8723bs: fix coding style issues in rtl8723b_cmd.c Kai Cheng Jin
2026-06-19  8:06 ` Dan Carpenter
2026-06-19 20:15   ` [PATCH v2 1/3] staging: rtl8723bs: add spaces around operators " Kai Cheng Jin
2026-06-19 20:15     ` [PATCH v2 2/3] staging: rtl8723bs: remove unnecessary parentheses " Kai Cheng Jin
2026-06-19 20:16     ` [PATCH v2 3/3] staging: rtl8723bs: remove extra blank lines " Kai Cheng Jin
2026-07-07 11:22     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070718-roundish-cherisher-938c@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=error27@gmail.com \
    --cc=kj@kylejin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.