From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33E5E2E7F38 for ; Tue, 7 Jul 2026 18:31:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783449076; cv=none; b=EBcrQTdP9V3ErqjoN8edS8mA0FWA/2dsm22xj3EIrFlSbKHzSVeLDLahspsf3Lodzi5t4UFrWwaRSZd6m7B4vyUtsgKhaMdC+2u6hNZmoqHoO0Qku9BDK6Hvrm2XVKecmdnQeyHsigujUESIIV/V9rBiiFO72SgW9W96SnUD9qg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783449076; c=relaxed/simple; bh=PQ4FwWYgv8aIcJc8oVWKayrpZ0rFpl2LWgPurWwlUU4=; h=Date:To:From:Subject:Message-Id; b=TBHaY5ltn0+Ek6mG9MgoxsioByX8bcijS6BOJrJvd+rufcszNTWRGP4H2wTq/L3X+9WszEjN/QzVXtUtixMBaBHxq4b/Q7Sn47PqoHo5tOTJGfvdSli9mahVogOwFPe1ZjUzTRoPZwRv/bymA30fEXnwkoynwnLArSaudnlPY+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=Qz7Oxs+N; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="Qz7Oxs+N" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B08B91F000E9; Tue, 7 Jul 2026 18:31:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=korg; t=1783449074; bh=A/cXWljd4yfwlf2SB53a2V43a/7pXdO1q1ojnR3E51Q=; h=Date:To:From:Subject; b=Qz7Oxs+NxBfMKs6bP/esktMCSLaOTDQl0QesOTrILPYNJF+NgbB5UyTDUw9oAWlgz CBDTuS+h9LpjlleQ1eAwcShC+WEX73PH5CaSGS9VqLCJmHcpimU7RSQnE4w/xDqsbS 2c4eeXXGT0qfxa34Ri+wRx/LgrSrIvgzoIc/VRZ8= Date: Tue, 07 Jul 2026 11:31:14 -0700 To: mm-commits@vger.kernel.org,wujianyue000@gmail.com,akpm@linux-foundation.org From: Andrew Morton Subject: [to-be-updated] mm-swap-colocate-page-cluster-sysctl-with-swap-readahead.patch removed from -mm tree Message-Id: <20260707183114.B08B91F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: mm-commits@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: The quilt patch titled Subject: mm/swap: colocate page-cluster sysctl with swap readahead has been removed from the -mm tree. Its filename was mm-swap-colocate-page-cluster-sysctl-with-swap-readahead.patch This patch was dropped because an updated version will be issued ------------------------------------------------------ From: Jianyue Wu Subject: mm/swap: colocate page-cluster sysctl with swap readahead Date: Sun, 05 Jul 2026 22:12:31 +0800 Patch series "mm: clean up folio LRU and swap declarations", v7. This series splits folio LRU and swap cleanup into three steps: - move the page-cluster sysctl next to swap readahead in mm/swap_state.c - rename mm/swap.c to mm/folio.c after the swap-specific bits move out - move MM-internal reclaim declarations out of include/linux/swap.h After this series, swap cache and swap-in readahead stay in mm/swap_state.c, folio LRU helpers live in mm/folio.c, and MM-internal reclaim/workingset declarations move from include/linux/swap.h to mm/internal.h (public LRU helpers used outside mm/ remain in swap.h). The first patch handles the swap-specific page-cluster state before the file rename, so the rename commit only carries folio LRU code. The last patch keeps the LRU helpers used outside mm/ in include/linux/swap.h and moves the internal reclaim/workingset declarations to mm/internal.h. This patch (of 3): page_cluster and the vm.page-cluster sysctl are only used by swap-in readahead in swap_state.c. Move them out of swap.c together with swap_readahead_setup(), and make page_cluster static to that file. Rename swap_setup() while moving it as well. The helper is internal to MM and now only sets up swap readahead defaults and its sysctl hook, so the more specific name matches its reduced scope. swap_setup() previously lived in mm/swap.c, which is built unconditionally, so the vm.page-cluster sysctl was registered also on CONFIG_SWAP=n kernels. swap_readahead_setup() is now a no-op stub when CONFIG_SWAP is disabled, so vm.page-cluster is no longer registered there. The knob only tunes swap-in readahead and had no effect without swap. Link: https://lore.kernel.org/20260705-ch-swap-series-plus-folio-lru-cleanup-v7-0-a028e8b5fc3d@gmail.com Link: https://lore.kernel.org/20260705-ch-swap-series-plus-folio-lru-cleanup-v7-1-a028e8b5fc3d@gmail.com Signed-off-by: Jianyue Wu Suggested-by: Baoquan He Suggested-by: Barry Song Suggested-by: Johannes Weiner Acked-by: Johannes Weiner Acked-by: David Hildenbrand (Arm) Reviewed-by: Kairui Song Cc: Axel Rasmussen Cc: Baolin Wang Cc: Chris Li Cc: Hugh Dickins Cc: Jonathan Corbet Cc: Kemeng Shi Cc: Liam R. Howlett Cc: Lorenzo Stoakes Cc: Matthew Wilcox (Oracle) Cc: Michal Hocko Cc: Mike Rapoport Cc: Nhat Pham Cc: Shakeel Butt Cc: Suren Baghdasaryan Cc: Vlastimil Babka Cc: Wei Xu Cc: Yuanchu Xie Signed-off-by: Andrew Morton --- include/linux/swap.h | 1 - mm/swap.c | 36 ------------------------------------ mm/swap.h | 9 +++++++-- mm/swap_state.c | 37 +++++++++++++++++++++++++++++++++++++ mm/vmscan.c | 2 +- 5 files changed, 45 insertions(+), 40 deletions(-) --- a/include/linux/swap.h~mm-swap-colocate-page-cluster-sysctl-with-swap-readahead +++ a/include/linux/swap.h @@ -340,7 +340,6 @@ extern void lru_add_drain_cpu_zone(struc extern void lru_add_drain_all(void); void folio_deactivate(struct folio *folio); void folio_mark_lazyfree(struct folio *folio); -extern void swap_setup(void); /* linux/mm/vmscan.c */ extern unsigned long zone_reclaimable_pages(struct zone *zone); --- a/mm/swap.c~mm-swap-colocate-page-cluster-sysctl-with-swap-readahead +++ a/mm/swap.c @@ -44,10 +44,6 @@ #define CREATE_TRACE_POINTS #include -/* How many pages do we try to swap or page in/out together? As a power of 2 */ -int page_cluster; -static const int page_cluster_max = 31; - struct cpu_fbatches { /* * The following folio batches are grouped together because they are protected @@ -1177,35 +1173,3 @@ void lru_reparent_memcg(struct mem_cgrou lruvec_reparent_lru(child_lruvec, parent_lruvec, lru, nid); } #endif - -static const struct ctl_table swap_sysctl_table[] = { - { - .procname = "page-cluster", - .data = &page_cluster, - .maxlen = sizeof(int), - .mode = 0644, - .proc_handler = proc_dointvec_minmax, - .extra1 = SYSCTL_ZERO, - .extra2 = (void *)&page_cluster_max, - } -}; - -/* - * Perform any setup for the swap system - */ -void __init swap_setup(void) -{ - unsigned long megs = PAGES_TO_MB(totalram_pages()); - - /* Use a smaller cluster for small-memory machines */ - if (megs < 16) - page_cluster = 2; - else - page_cluster = 3; - /* - * Right now other parts of the system means that we - * _really_ don't want to cluster much more - */ - - register_sysctl_init("vm", swap_sysctl_table); -} --- a/mm/swap.h~mm-swap-colocate-page-cluster-sysctl-with-swap-readahead +++ a/mm/swap.h @@ -8,8 +8,6 @@ struct mempolicy; struct swap_iocb; struct swap_memcg_table; -extern int page_cluster; - #if defined(MAX_POSSIBLE_PHYSMEM_BITS) #define SWAP_CACHE_PFN_BITS (MAX_POSSIBLE_PHYSMEM_BITS - PAGE_SHIFT) #elif defined(MAX_PHYSMEM_BITS) @@ -79,6 +77,8 @@ enum swap_cluster_flags { }; #ifdef CONFIG_SWAP +void swap_readahead_setup(void); + #include /* for swp_offset */ #include /* for bio_end_io_t */ @@ -336,6 +336,11 @@ static inline unsigned int folio_swap_fl #else /* CONFIG_SWAP */ struct swap_iocb; + +static inline void swap_readahead_setup(void) +{ +} + static inline struct swap_cluster_info *swap_cluster_lock( struct swap_info_struct *si, pgoff_t offset, bool irq) { --- a/mm/swap_state.c~mm-swap-colocate-page-cluster-sysctl-with-swap-readahead +++ a/mm/swap_state.c @@ -22,10 +22,15 @@ #include #include #include +#include #include "internal.h" #include "swap_table.h" #include "swap.h" +/* Swap readahead cluster size, as a power of 2 pages. */ +static int page_cluster; +static const int page_cluster_max = 31; + /* * swapper_space is a fiction, retained to simplify the path through * vmscan's shrink_folio_list. @@ -985,6 +990,38 @@ struct folio *swapin_readahead(swp_entry return folio; } +static const struct ctl_table swap_readahead_sysctl_table[] = { + { + .procname = "page-cluster", + .data = &page_cluster, + .maxlen = sizeof(int), + .mode = 0644, + .proc_handler = proc_dointvec_minmax, + .extra1 = SYSCTL_ZERO, + .extra2 = (void *)&page_cluster_max, + } +}; + +/** + * swap_readahead_setup - defaults and sysctl for swap cache readahead clustering + */ +void __init swap_readahead_setup(void) +{ + unsigned long megs = PAGES_TO_MB(totalram_pages()); + + /* Use a smaller cluster for small-memory machines */ + if (megs < 16) + page_cluster = 2; + else + page_cluster = 3; + /* + * Right now other parts of the system means that we + * _really_ don't want to cluster much more + */ + + register_sysctl_init("vm", swap_readahead_sysctl_table); +} + #ifdef CONFIG_SYSFS static ssize_t vma_ra_enabled_show(struct kobject *kobj, struct kobj_attribute *attr, char *buf) --- a/mm/vmscan.c~mm-swap-colocate-page-cluster-sysctl-with-swap-readahead +++ a/mm/vmscan.c @@ -7647,7 +7647,7 @@ static int __init kswapd_init(void) { int nid; - swap_setup(); + swap_readahead_setup(); for_each_node_state(nid, N_MEMORY) kswapd_run(nid); register_sysctl_init("vm", vmscan_sysctl_table); _ Patches currently in -mm which might be from wujianyue000@gmail.com are mm-rename-swapc-to-folioc.patch mm-move-reclaim-internal-declarations-out-of-swaph.patch