From: Greg KH <gregkh@linuxfoundation.org>
To: Dalvin-Ehinoma Noah Aiguobas <fliegbert2@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: fix CamelCase warning for OnAssoc
Date: Tue, 7 Jul 2026 13:28:16 +0200 [thread overview]
Message-ID: <2026070725-napped-decimal-3768@gregkh> (raw)
In-Reply-To: <ajpXBI0GxOGkmTUF@koolguy>
On Tue, Jun 23, 2026 at 09:51:00AM +0000, Dalvin-Ehinoma Noah Aiguobas wrote:
> Rename OnAssoc values from CamelCase to snake_case to conform to
> linux kernel coding style:
> OnAssocReq -> on_assoc_req
> OnAssocRsp -> on_assoc_rsp
> WMMOnAssocRsp -> WMM_on_assoc_rsp
> HTOnAssocRsp -> HT_on_assoc_rsp
> OnAssocReqFail -> on_assoc_req_fail
Why just these? It's a miss-mash of different things all at once.
Please make this a series that does one function at a time.
Also, when you change the function names, make them more obvious they
are in this driver as they turn into some pretty horrible global symbol
names, right?
thanks,
greg k-h
prev parent reply other threads:[~2026-07-07 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 9:51 [PATCH] staging: rtl8723bs: fix CamelCase warning for OnAssoc Dalvin-Ehinoma Noah Aiguobas
2026-07-07 11:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070725-napped-decimal-3768@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=fliegbert2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.