From: Greg KH <gregkh@linuxfoundation.org>
To: Parsal Baral <parsalbaral@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Use PTR_ALIGN for rsp_buf alignment
Date: Tue, 7 Jul 2026 12:58:40 +0200 [thread overview]
Message-ID: <2026070733-entryway-cost-91a0@gregkh> (raw)
In-Reply-To: <20260603182602.658589-1-parsalbaral@gmail.com>
On Thu, Jun 04, 2026 at 12:11:02AM +0545, Parsal Baral wrote:
> Replace manual pointer alignment calculation with the standard PTR_ALIGN
> macro for rsp_buf in rtw_init_cmd_priv()
>
> Follows modernization of cmd_buf alignment in commit 69dc48dc5506
> ("staging: rtl8723bs: use PTR_ALIGN for buffer alignment")
>
> Compile-tested only
>
> Signed-off-by: Parsal Baral <parsalbaral@gmail.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index c1185c25e..38ce3156c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -184,7 +184,7 @@ int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv)
> return -ENOMEM;
> }
>
> - pcmdpriv->rsp_buf = pcmdpriv->rsp_allocated_buf + 4 - ((SIZE_PTR)(pcmdpriv->rsp_allocated_buf) & 3);
> + pcmdpriv->rsp_buf = PTR_ALIGN(pcmdpriv->rsp_allocated_buf, 4);
>
> pcmdpriv->cmd_issued_cnt = 0;
> pcmdpriv->cmd_done_cnt = 0;
> --
> 2.54.0
>
>
Does not apply to the latest tree :(
next prev parent reply other threads:[~2026-07-07 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-03 18:26 [PATCH] staging: rtl8723bs: Use PTR_ALIGN for rsp_buf alignment Parsal Baral
2026-07-07 10:58 ` Greg KH [this message]
2026-07-07 12:03 ` Parsal Baral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070733-entryway-cost-91a0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=parsalbaral@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.