All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Jiri Slaby <jirislaby@kernel.org>,
	linux-serial@vger.kernel.org, lvc-project@linuxtesting.org,
	syzbot+b5d1f455d385b2c7da3c@syzkaller.appspotmail.com
Subject: Re: [PATCH 1/2] tty: n_gsm: avoid reactivation without previous cleanup
Date: Tue, 7 Jul 2026 07:58:23 +0200	[thread overview]
Message-ID: <2026070734-risotto-onshore-a30b@gregkh> (raw)
In-Reply-To: <3ca834d7-1ee0-426c-89d1-b52dab0b0a24@yandex.ru>

On Tue, Jul 07, 2026 at 08:47:46AM +0300, Dmitry Antipov wrote:
> On 7/6/26 6:18 PM, Greg Kroah-Hartman wrote:
> 
> > That's why userspace does not do this from multiple threads :)
> 
> What about malicious userspace like https://github.com/fff-vr/n_gsm_exploit?
> IIUC completely unlocked 'gsmld_ioctl()' makes such a things relatively simple.

The gsm code should never be loaded on systems that do not have the
hardware for it, which is why it requires root access to do so.

Systems that do have this hardware, are properly secured to not allow
untrusted userspace programs on it.

This has been discussed numerous times in the past on this list, nothing
new here.

thanks,

greg k-h

      reply	other threads:[~2026-07-07  5:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 14:20 [PATCH 1/2] tty: n_gsm: avoid reactivation without previous cleanup Dmitry Antipov
2026-07-06 14:20 ` [PATCH 2/2] tty: n_gsm: issue mutex_destroy() from gsm_dlci_free() Dmitry Antipov
2026-07-07  3:24   ` Jiri Slaby
2026-07-06 14:35 ` [PATCH 1/2] tty: n_gsm: avoid reactivation without previous cleanup Greg Kroah-Hartman
2026-07-06 14:49   ` Dmitry Antipov
2026-07-06 15:18     ` Greg Kroah-Hartman
2026-07-07  5:47       ` Dmitry Antipov
2026-07-07  5:58         ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070734-risotto-onshore-a30b@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=dmantipov@yandex.ru \
    --cc=jirislaby@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=syzbot+b5d1f455d385b2c7da3c@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.