All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>
Cc: Kevin Cernekee <cernekee@gmail.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] tty: serial: rp2: Use named initializer for pci_device_id::driver_data
Date: Tue, 7 Jul 2026 14:26:09 +0200	[thread overview]
Message-ID: <2026070746-voltage-division-abd6@gregkh> (raw)
In-Reply-To: <akzB9zul5o1OMnsm@monoceros>

On Tue, Jul 07, 2026 at 11:09:30AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> Hello,
> 
> On Sun, May 24, 2026 at 03:19:05PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > The .driver_data member of the struct pci_device_id array were
> > initialized by list expressions relying on hidden assignment of .class
> > and .class_mask in PCI_VDEVICE().
> > 
> > Make the initialization more robust by using a named initializer. This
> > robustness is relevant for a planned change to struct pci_device_id that
> > replaces .driver_data by an anonymous union.
> > 
> > This change doesn't introduce changes to the compiled pci_device_id
> > array. Tested on x86 and arm64.
> > 
> > Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> 
> This patch was sent before the merge window leading to v7.2-rc1 and got
> no feedback and isn't in next. So I wonder if it's still on someone's
> radar?!

It is, give me a chance to catch up, just made it through 300+
drivers/staging/ patches that had been sent recently....

thanks,

greg k-h

      reply	other threads:[~2026-07-07 12:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-24 13:19 [PATCH v1] tty: serial: rp2: Use named initializer for pci_device_id::driver_data Uwe Kleine-König (The Capable Hub)
2026-07-07  9:09 ` Uwe Kleine-König (The Capable Hub)
2026-07-07 12:26   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070746-voltage-division-abd6@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=cernekee@gmail.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.