All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Anirban Bose <boses156@gmail.com>
Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: rename camelcase variable bDumpRxPkt
Date: Tue, 7 Jul 2026 12:17:03 +0200	[thread overview]
Message-ID: <2026070747-goldfish-xerox-fb37@gregkh> (raw)
In-Reply-To: <20260525065935.130736-1-boses156@gmail.com>

On Mon, May 25, 2026 at 12:29:35PM +0530, Anirban Bose wrote:
> Rename the local variable 'bDumpRxPkt' to 'dump_rx_pkt' in
> validate_recv_frame() to resolve a checkpatch.pl CamelCase warning.
> 
> Signed-off-by: Anirban Bose <boses156@gmail.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_recv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_recv.c b/drivers/staging/rtl8723bs/core/rtw_recv.c
> index 86c5e2c4e7dd..808f67b61f77 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_recv.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_recv.c
> @@ -1447,7 +1447,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
>  	u8 type;
>  	u8 subtype;
>  	signed int retval = _SUCCESS;
> -	u8 bDumpRxPkt;
> +	u8 dump_rx_pkt;
>  
>  	struct rx_pkt_attrib *pattrib = &precv_frame->u.hdr.attrib;
>  
> @@ -1473,7 +1473,7 @@ static signed int validate_recv_frame(struct adapter *adapter, union recv_frame
>  	pattrib->mdata = GetMData(ptr);
>  	pattrib->privacy = GetPrivacy(ptr);
>  	pattrib->order = GetOrder(ptr);
> -	rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(bDumpRxPkt));
> +	rtw_hal_get_def_var(adapter, HAL_DEF_DBG_DUMP_RXPKT, &(dump_rx_pkt));

If this is never used, why is it set at all?

thanks,

greg k-h

  reply	other threads:[~2026-07-07 10:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-25  6:59 [PATCH] staging: rtl8723bs: rename camelcase variable bDumpRxPkt Anirban Bose
2026-07-07 10:17 ` Greg KH [this message]
2026-07-10 14:11 ` [PATCH v2] staging: rtl8723bs: remove unused " Anirban Bose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026070747-goldfish-xerox-fb37@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=boses156@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.