From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Aiman Najjar <aiman@linux.com>
Cc: kernel-janitors@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: rtl8723bs: drop GEN_CMD_CODE macro and capitalize labels
Date: Tue, 7 Jul 2026 13:07:01 +0200 [thread overview]
Message-ID: <2026070750-myself-hardhat-295f@gregkh> (raw)
In-Reply-To: <20260609-rtl8723bs-code-style-v1-1-daa0e85359a6@linux.com>
On Tue, Jun 09, 2026 at 09:42:55PM -0400, Aiman Najjar wrote:
> The use of GEN_CMD_CODE macro to generate cmd enum label names is applied
> inconsistently and is confusing, it also makes it harder to make use of
> tools such as clangd when looking up symbols.
>
> Replace them with writing the enum labels directly and adopting
> new capitalized names instead of the current camel case ones.
>
> Signed-off-by: Aiman Najjar <aiman@linux.com>
> ---
> drivers/staging/rtl8723bs/core/rtw_ap.c | 4 +-
> drivers/staging/rtl8723bs/core/rtw_cmd.c | 190 +++++++++++++-------------
> drivers/staging/rtl8723bs/core/rtw_mlme.c | 4 +-
> drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 18 +--
> drivers/staging/rtl8723bs/include/rtw_cmd.h | 154 ++++++++++-----------
> 5 files changed, 181 insertions(+), 189 deletions(-)
Does not apply to the latest tree :(
next prev parent reply other threads:[~2026-07-07 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-10 1:42 [PATCH 0/2] staging: rtl8723bs: enum labels naming, coding style Aiman Najjar
2026-06-10 1:42 ` [PATCH 1/2] staging: rtl8723bs: drop GEN_CMD_CODE macro and capitalize labels Aiman Najjar
2026-07-07 11:07 ` Greg Kroah-Hartman [this message]
2026-06-10 1:42 ` [PATCH 2/2] staging: rtl8723bs: drop GEN_EVT_CODE " Aiman Najjar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070750-myself-hardhat-295f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=aiman@linux.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.