From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-8fa9.mail.infomaniak.ch (smtp-8fa9.mail.infomaniak.ch [83.166.143.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 063081A9FA8 for ; Wed, 8 Jul 2026 11:10:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.166.143.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783509022; cv=none; b=ZwuEZmTQWuZXe+KU+OG311Dk/PdTn/tbFzn3aVvQiSt/+5+TmB3VYMmnyB1wTEPy3maQTGFnhvrrUMTpYkrzcGyRkPinYZhy5Irj8hhfsWoxA3WDiuX2ibCS6RBysGrol9iRRSMjlc7sgel+H8doIGPY83Vr/aCotZ1rb7jsob0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783509022; c=relaxed/simple; bh=ZVcYC3hCqq1HkYMWG9phZU3ckArI00ecy3AEJ1DiY28=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=s6wUL13I+OCoDHIDWQXBDCe2Yl1wgmk2eBq8ExVt9GdSuG4jmyxi0gn0t+K/iQ1I2G5ilsSQaatPWurddHBOpSIIl+uolIXC9eRPt8iHZD58Uzbhsztho3QChICtU2iZPxxzvlCsCS0sDj59So4hmB3jEYWtDvq9N5gJV6MMM5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net; spf=pass smtp.mailfrom=digikod.net; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b=j4N9bd+J; arc=none smtp.client-ip=83.166.143.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=digikod.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=digikod.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=digikod.net header.i=@digikod.net header.b="j4N9bd+J" Received: from smtp-3-0001.mail.infomaniak.ch (smtp-3-0001.mail.infomaniak.ch [10.4.36.108]) by smtp-4-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4gwFk94XQwzdGy; Wed, 8 Jul 2026 13:10:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=digikod.net; s=20191114; t=1783509009; bh=L9TX1lDUPbMjdqgiiifNuFpkH16wh8d3qOZphCHCwnQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=j4N9bd+Js4mo9136rHp4MNVUwhfe4298q5B40HSdAOs9lvrNitbq/HKUTEiTr3Q12 QxutRIJ5NNFrPYy/nB1Ituhjl3gRFnH3BP5MCQuN2ewz9jVLIDSOK0mbkldqeXcpiH dDPl4A3QsPjpkiQR2i06J1/4tox8Jfw62e2FVYOQ= Received: from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA id 4gwFk85ZRYzFsx; Wed, 8 Jul 2026 13:10:08 +0200 (CEST) Date: Wed, 8 Jul 2026 13:10:07 +0200 From: =?utf-8?Q?Micka=C3=ABl_Sala=C3=BCn?= To: Miguel Ojeda Cc: Miguel Ojeda , linux-kernel@vger.kernel.org, Nathan Chancellor , Andrew Morton , Bart Van Assche , =?utf-8?Q?G=C3=BCnther?= Noack , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH v1] clang-format: Fix formatting of guard() Message-ID: <20260708.yi2Ve3eeGa8a@digikod.net> References: <20260708105713.2073335-1-mic@digikod.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Infomaniak-Routing: alpha On Wed, Jul 08, 2026 at 01:06:12PM +0200, Miguel Ojeda wrote: > On Wed, Jul 8, 2026 at 12:57 PM Mickaël Salaün wrote: > > > > The previous fix was overzealous and included guard() along with > > scoped_guard(), but only the later takes curly braces. > > > > The original fix introduced this issue: > > - guard(rcu)(); > > + guard(rcu) > > + (); > > > > This is especially visible with security/landlock/*.[ch] which is fully > > formatted with clang-format. > > This one would go away on its own if one runs the command above from > where the list is meant to be generated -- but `scoped_guard()` would > be also removed. What do you mean? Running clang-format -i security/landlock/*.[ch] does some changes. > > I guess I can just have a section of explicit ones that come from > outside the line. > > I can pick this one through `clang-format` and take the chance to give > an update to the list. Yes please. > > Thanks! > > Cheers, > Miguel