All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lothar Waßmann" <LW@KARO-electronics.de>
To: u-boot@lists.denx.de
Cc: "Petr Beneš" <petr.benes@ysoft.com>,
	"Mattijs Korpershoek" <mkorpershoek@kernel.org>
Subject: Regression in f_fastboot due to commit 6a92e9827650 ("usb: ci_udc: Check ci_ep->desc before use")
Date: Wed, 8 Jul 2026 07:12:55 +0200	[thread overview]
Message-ID: <20260708071255.13f58e98.LW@KARO-electronics.de> (raw)

Hi,

commit 6a92e9827650 ("usb: ci_udc: Check ci_ep->desc before use") has
the side effect that an empty buffer is being passed on to
rx_handler_command() in drivers/usb/gadget/f_fastboot.c upon
termination of a fastboot session which leads to a
'command  not recognized' error message being printed on the console.

Obviously without the commit the offending USB request had been silently
dropped but is now delivered to the upper levels.

I'm not sure what the correct fix would be.
Should the fastboot driver ignore the empty command buffer or should
the "Moreover, the patch gets rid of possible outstanding requests
if the endpoint's state changes to disabled." part of the commit be
reverted?


Lothar Waßmann

             reply	other threads:[~2026-07-08  5:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08  5:12 Lothar Waßmann [this message]
2026-07-09 15:15 ` Regression in f_fastboot due to commit 6a92e9827650 ("usb: ci_udc: Check ci_ep->desc before use") Mattijs Korpershoek
2026-07-10 21:27   ` Petr Beneš

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260708071255.13f58e98.LW@KARO-electronics.de \
    --to=lw@karo-electronics.de \
    --cc=mkorpershoek@kernel.org \
    --cc=petr.benes@ysoft.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.