From: sashiko-bot@kernel.org
To: "Michal Simek" <michal.simek@amd.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org
Subject: Re: [PATCH v4 1/5] dt-bindings: firmware: xilinx: Add missing example for ZynqMP
Date: Wed, 08 Jul 2026 07:27:44 +0000 [thread overview]
Message-ID: <20260708072744.9854A1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <09439b3fc9dcab12b930113e7a004e94653c970c.1783495122.git.michal.simek@amd.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message incorrectly references `xlnx,zynqmp-clk.yaml` instead of `xlnx,versal-clk.yaml`.
--
--- Patch [1]: [PATCH v4 1/5] dt-bindings: firmware: xilinx: Add missing example for ZynqMP ---
commit f76bb0fabd5ddf2fd379360e863c083c04812eff
Author: Michal Simek <michal.simek@amd.com>
dt-bindings: firmware: xilinx: Add missing example for ZynqMP
This commit adds the clock-controller to the zynqmp-firmware example in
the device tree binding. This allows ZynqMP device trees to properly
validate against the clock schema.
> Document clock-controller under zynqmp-firmware in the binding example so
> ZynqMP DTs validate against xlnx,zynqmp-clk.yaml (Versal example already did).
[Severity: Low]
This isn't a bug, but the commit message references xlnx,zynqmp-clk.yaml,
which does not appear to exist in the repository. Should the message specify
xlnx,versal-clk.yaml instead, since that is what the hardware actually
validates against?
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1783495122.git.michal.simek@amd.com?part=1
next prev parent reply other threads:[~2026-07-08 7:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 7:18 [PATCH v4 0/5] clock: versal-clk: Fix Versal NET clock binding and switch to CCF Michal Simek
2026-07-08 7:18 ` [PATCH v4 1/5] dt-bindings: firmware: xilinx: Add missing example for ZynqMP Michal Simek
2026-07-08 7:27 ` sashiko-bot [this message]
2026-07-08 7:18 ` [PATCH v4 2/5] dt-bindings: clock: versal-clk: Fix mio_clk index range in clock-names pattern Michal Simek
2026-07-08 7:32 ` sashiko-bot
2026-07-08 10:59 ` Michal Simek
2026-07-08 7:18 ` [PATCH v4 3/5] dt-bindings: clock: Move xlnx,zynqmp-clk to its own schema Michal Simek
2026-07-08 7:37 ` sashiko-bot
2026-07-08 11:49 ` Michal Simek
2026-07-08 9:06 ` Rob Herring (Arm)
2026-07-08 7:18 ` [PATCH v4 4/5] dt-bindings: clock: versal-clk: Fix Versal NET clock validation Michal Simek
2026-07-08 7:18 ` [PATCH v4 5/5] arm64: versal-net: Switch Versal NET to firmware clock interface Michal Simek
2026-07-08 7:42 ` sashiko-bot
2026-07-08 11:51 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708072744.9854A1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.