Re: [PATCH v4 net-next 07/14] net: enetc: differentiate phylink capabilities for pseudo-MAC and standalone MAC

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] Unhandled PHY_INTERFACE_MODE_1000BASEX in enetc4_mac_config() causes MAC configuration failure.
--

--- Patch [7]: [PATCH v4 net-next 07/14] net: enetc: differentiate phylink capabilities for pseudo-MAC and standalone MAC ---
commit 77043a189039feeceb8a61d08f960e3ed8ff9d08
Author: Claudiu Manoil <claudiu.manoil@nxp.com>

net: enetc: differentiate phylink capabilities for pseudo-MAC and standalone MAC

The ENETC pseudo-MACs are proprietary internal links that do not
implement any standard MII interface, so restrict their supported PHY
interface modes to PHY_INTERFACE_MODE_INTERNAL only. For standalone
ENETC (v4), expand the supported interface modes to include 10GBASER.

> diff --git a/drivers/net/ethernet/freescale/enetc/enetc4_pf.c b/drivers/net/ethernet/freescale/enetc/enetc4_pf.c
> index f24269a48c26b..75ee117e9b1df 100644
> --- a/drivers/net/ethernet/freescale/enetc/enetc4_pf.c
> +++ b/drivers/net/ethernet/freescale/enetc/enetc4_pf.c
> @@ -602,7 +602,6 @@ static void enetc4_mac_config(struct enetc_pf *pf, unsigned int mode,
>  		val |= IFMODE_SGMII;
>  		break;
>  	case PHY_INTERFACE_MODE_10GBASER:
> -	case PHY_INTERFACE_MODE_XGMII:
>  	case PHY_INTERFACE_MODE_USXGMII:
>  		val |= IFMODE_XGMII;
>  		break;

[Severity: High]
This isn't a bug introduced by this patch, but does enetc4_mac_config()
miss handling for PHY_INTERFACE_MODE_1000BASEX?

Since enetc_phylink_create() explicitly advertises support for
PHY_INTERFACE_MODE_1000BASEX, it appears that mode will fall through to
the default branch in this switch statement, printing an error and
aborting MAC configuration.

Could PHY_INTERFACE_MODE_1000BASEX be handled alongside
PHY_INTERFACE_MODE_SGMII and PHY_INTERFACE_MODE_2500BASEX?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260707081834.710730-1-wei.fang@oss.nxp.com?part=7