Re: [PATCH v2 1/2] dt-bindings: iio: dac: Add DAC8163

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree binding uses the non-standard `clr-gpios` property name for a reset line instead of the standard `reset-gpios`.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: iio: dac: Add DAC8163 ---
commit f211d5a7de6b208a53302eba555c43258dd0918b
Author: Lukas Metz <lukas.metz@gmx.net>

dt-bindings: iio: dac: Add DAC8163

Add device tree binding for the Texas Instruments DAC8163 family
including the DAC7562, DAC7563, DAC8162, DAC8163, DAC8562 and DAC8563.

> diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac8163.yaml b/Documentation/devicetree/bindings/iio/dac/ti,dac8163.yaml
> new file mode 100644
> index 0000000000000..533cc7327c2b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac8163.yaml
[ ... ]
> +  avdd-supply: true
> +
> +  clr-gpios:
> +    description:
> +      The device registers are reset when this pin is asserted. The output is
> +      set to zero (xxx2 devices) or mid-scale (xxx3 devices).
> +    maxItems: 1

[Severity: Low]
Is clr-gpios the correct name for this property? The description indicates it
functions as a reset line. Should this use the standard reset-gpios property
name instead of a datasheet-specific pin name?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260708-dac8163-work-v2-0-3acd1bf20182@gmx.net?part=1