Re: [PATCH v2 3/6] clk: renesas: Add R-Car X5H CPG driver

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Memory and clock registration leak if `devm_kasprintf()` fails during fixed clock registration.
--

--- Patch [3]: [PATCH v2 3/6] clk: renesas: Add R-Car X5H CPG driver ---
commit 1d0eaa24ed7151f3cc9ee126c74cd79bec68356e
Author: Geert Uytterhoeven <geert+renesas@glider.be>
Date:   Wed Jul 8 10:15:08 2026 +0000

clk: renesas: Add R-Car X5H CPG driver

This patch adds a minimal Clock Pulse Generator driver for the R-Car X5H
(R8A78000) SoC. It provides support for the fixed-rate clocks needed by the
current minimal DTS.

> diff --git a/drivers/clk/renesas/r8a78000-cpg.c b/drivers/clk/renesas/r8a78000-cpg.c
> new file mode 100644
> --- /dev/null
> +++ b/drivers/clk/renesas/r8a78000-cpg.c

[ ... ]

> +static int register_fixed_clks(struct r8a78000_cpg_priv *priv)
> +{
> +	struct device *dev = priv->dev;
> +	unsigned long rate;
> +	struct clk_hw *hw;
> +	const char *name;
> +
> +	for (unsigned int i = 0; i < ARRAY_SIZE(fixed_clk_rates); i++) {
> +		rate = fixed_clk_rates[i];
> +		name = devm_kasprintf(dev, GFP_KERNEL, "cpg-%lu", rate);
> +		if (!name)
> +			return -ENOMEM;

[Severity: Medium]
If devm_kasprintf() fails on a later iteration, does this return statement
leak the clocks that were successfully registered in previous iterations?

The cleanup loop for clk_hw_unregister_fixed_rate() is only executed if
clk_hw_register_fixed_rate() fails, and the devres action to unregister
the clocks is not added until the end of the function.

> +
> +		hw = clk_hw_register_fixed_rate(dev, name, NULL, 0, rate);
> +		if (IS_ERR(hw)) {
> +			while (i-- > 0)
> +				clk_hw_unregister_fixed_rate(priv->fixed_hws[i]);
> +			return PTR_ERR(hw);
> +		}
> +
> +		priv->fixed_hws[i] = hw;
> +	}
> +
> +	return devm_add_action_or_reset(dev, unregister_fixed_clks, priv);
> +}

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1783505142.git.geert+renesas@glider.be?part=3