From: Leon Romanovsky <leon@kernel.org>
To: Dawei Feng <dawei.feng@seu.edu.cn>
Cc: dennis.dalessandro@cornelisnetworks.com, jgg@ziepe.ca,
jianhao.xu@seu.edu.cn, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, stable@vger.kernel.org,
zilin@seu.edu.cn
Subject: Re: [PATCH] RDMA/hfi1: fix init_one() probe failure cleanup
Date: Wed, 8 Jul 2026 13:50:18 +0300 [thread overview]
Message-ID: <20260708105018.GN15188@unreal> (raw)
In-Reply-To: <20260706143424.145935-1-dawei.feng@seu.edu.cn>
On Mon, Jul 06, 2026 at 10:34:24PM +0800, Dawei Feng wrote:
> On Sun, 5 Jul 2026 15:23:28 +0300, Leon Romanovsky wrote:
> >Just move hfi1_validate_rcvhdrcnt() to be before hfi1_alloc_devdata()
> >and remove error prints.
>
> Hi, Leon,
>
> I agree that this approach is suitable for the hfi1_validate_rcvhdrcnt()
> failure path. However, it is not generally applicable to the other failure
> paths. The later failures still occur after hfi1_alloc_devdata(), so they
> still need proper cleanup handling to avoid leaking the allocated devdata.
> Therefore, I think the current approach may be more appropriate for this
> fix.
https://lore.kernel.org/all/20260708-clean-init-one-hfi1-v1-0-b9e9641268a5@nvidia.com/
Thanks
prev parent reply other threads:[~2026-07-08 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-27 6:01 [PATCH] RDMA/hfi1: fix init_one() probe failure cleanup Dawei Feng
2026-07-05 12:23 ` Leon Romanovsky
2026-07-06 14:34 ` Dawei Feng
2026-07-08 10:50 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708105018.GN15188@unreal \
--to=leon@kernel.org \
--cc=dawei.feng@seu.edu.cn \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=jgg@ziepe.ca \
--cc=jianhao.xu@seu.edu.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=zilin@seu.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.