Re: [LTP] [PATCH v3 1/4] lapi: Add pkt_cls.h fallback

[Petr Vorel <pvorel@suse.cz>]

Hi Andrea,

> +#include <linux/pkt_cls.h>
> +
> +#ifndef TC_ACT_PIPE
> +# define TC_ACT_PIPE	3
> +#endif
> +
> +#ifndef TCA_MATCHALL_ACT
> +# define TCA_MATCHALL_ACT	2
> +#endif

include/uapi/linux/pkt_cls.h defines it as enum:

enum {
	TCA_MATCHALL_UNSPEC,
	TCA_MATCHALL_CLASSID,
	TCA_MATCHALL_ACT,
	TCA_MATCHALL_FLAGS,
	TCA_MATCHALL_PCNT,
	TCA_MATCHALL_PAD,
	__TCA_MATCHALL_MAX,
};

But it should be safe to define it as you did (there is no reason the value
would change because kernel folks add new members at the end).

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp