From: SJ Park <sj@kernel.org>
To: zjh <jiahuitry@outlook.com>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/damon: prevent migration fallback to non-target nodes
Date: Wed, 8 Jul 2026 07:11:33 -0700 [thread overview]
Message-ID: <20260708141134.123360-1-sj@kernel.org> (raw)
In-Reply-To: <BY5PR02MB6642F4D1A8BA92BFF3A034B4B5FF2@BY5PR02MB6642.namprd02.prod.outlook.com>
Hello jzh,
On Wed, 8 Jul 2026 01:07:54 -0700 zjh <jiahuitry@outlook.com> wrote:
> DAMOS_MIGRATE_{HOT,COLD} passes a target NUMA node to migrate_pages().
> But alloc_migration_target() treats mtc->nid as a preferred node unless
> __GFP_THISNODE is set. Hence target allocation can fall back to another
> node, and migrate_pages() can report success without placing the folio on
> the requested target node.
>
> Make DAMON migration target allocation strict by setting __GFP_THISNODE.
> This is consistent with alloc_misplaced_dst_folio() and
> alloc_demote_folio(), which also use __GFP_THISNODE for migrations to an
> explicit destination node.
Thank you for sharing this patch. So this patch is introducing a small
behavioral change. May I ask why you think the new behavior is better? Have
you find some negative user impacts from the current behavior?
>
> Signed-off-by: zjh <jiahuitry@outlook.com>
We as the kernel community disallow [1] anonymous patch submissions. Is zjh
your preferred identity? Also, it is not a strict rule, but we as the mm
community prefer using a formal name if that's ok.
[1] https://docs.kernel.org/process/submitting-patches.html#developer-s-certificate-of-origin-1-1
Thanks,
SJ
[...]
next prev parent reply other threads:[~2026-07-08 14:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 8:07 [PATCH] mm/damon: prevent migration fallback to non-target nodes zjh
2026-07-08 14:11 ` SJ Park [this message]
2026-07-08 17:55 ` Jiahui Zhang
2026-07-09 0:37 ` SJ Park
2026-07-09 6:38 ` Jiahui Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260708141134.123360-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=jiahuitry@outlook.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.