All of lore.kernel.org
 help / color / mirror / Atom feed
From: phucduc.bui@gmail.com
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	Nick Li <nick.li@foursemi.com>,
	Herve Codina <herve.codina@bootlin.com>
Cc: Support Opensource <support.opensource@diasemi.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>,
	Srinivas Kandagatla <srini@kernel.org>,
	Charles Keepax <ckeepax@opensource.cirrus.com>,
	Richard Fitzgerald <rf@opensource.cirrus.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
	Baojun Xu <baojun.xu@ti.com>, Sen Wang <sen@ti.com>,
	Oder Chiou <oder_chiou@realtek.com>,
	Linus Walleij <linusw@kernel.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
	u.kleine-koenig@baylibre.com, Zhang Yi <zhangyi@everest-semi.com>,
	Marco Crivellari <marco.crivellari@suse.com>,
	Kees Cook <kees@kernel.org>, HyeongJun An <sammiee5311@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Qianfeng Rong <rongqianfeng@vivo.com>,
	linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
	patches@opensource.cirrus.com,
	linux-mediatek@lists.infradead.org,
	linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	bui duc phuc <phucduc.bui@gmail.com>
Subject: [PATCH v2 20/27] ASoC: codecs: rt5668: Use guard() for mutex locks
Date: Wed,  8 Jul 2026 21:17:27 +0700	[thread overview]
Message-ID: <20260708141734.578926-21-phucduc.bui@gmail.com> (raw)
In-Reply-To: <20260708141734.578926-1-phucduc.bui@gmail.com>

From: bui duc phuc <phucduc.bui@gmail.com>

Clean up the code using guard() for mutex locks.
Merely code refactoring, and no behavior change.

Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
---
 sound/soc/codecs/rt5668.c | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/sound/soc/codecs/rt5668.c b/sound/soc/codecs/rt5668.c
index fed6de40b8c8..4154bad27610 100644
--- a/sound/soc/codecs/rt5668.c
+++ b/sound/soc/codecs/rt5668.c
@@ -6,6 +6,7 @@
  * Author: Bard Liao <bardliao@realtek.com>
  */
 
+#include <linux/cleanup.h>
 #include <linux/module.h>
 #include <linux/moduleparam.h>
 #include <linux/init.h>
@@ -986,7 +987,7 @@ static void rt5668_jack_detect_handler(struct work_struct *work)
 		return;
 	}
 
-	mutex_lock(&rt5668->calibrate_mutex);
+	guard(mutex)(&rt5668->calibrate_mutex);
 
 	val = snd_soc_component_read(rt5668->component, RT5668_AJD1_CTRL)
 		& RT5668_JDH_RS_MASK;
@@ -1053,8 +1054,6 @@ static void rt5668_jack_detect_handler(struct work_struct *work)
 		schedule_delayed_work(&rt5668->jd_check_work, 0);
 	else
 		cancel_delayed_work_sync(&rt5668->jd_check_work);
-
-	mutex_unlock(&rt5668->calibrate_mutex);
 }
 
 static const struct snd_kcontrol_new rt5668_snd_controls[] = {
@@ -2356,7 +2355,7 @@ static void rt5668_calibrate(struct rt5668_priv *rt5668)
 {
 	int value, count;
 
-	mutex_lock(&rt5668->calibrate_mutex);
+	guard(mutex)(&rt5668->calibrate_mutex);
 
 	rt5668_reset(rt5668->regmap);
 	regmap_write(rt5668->regmap, RT5668_PWR_ANLG_1, 0xa2bf);
@@ -2400,9 +2399,6 @@ static void rt5668_calibrate(struct rt5668_priv *rt5668)
 	/* restore settings */
 	regmap_write(rt5668->regmap, RT5668_STO1_ADC_MIXER, 0xc0c4);
 	regmap_write(rt5668->regmap, RT5668_PWR_DIG_1, 0x0000);
-
-	mutex_unlock(&rt5668->calibrate_mutex);
-
 }
 
 static int rt5668_i2c_probe(struct i2c_client *i2c)
-- 
2.43.0



  parent reply	other threads:[~2026-07-08 14:21 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08 14:17 [PATCH v2 00/27] ASoC: codecs: Use guard() for mutex & spin locks - part 2 phucduc.bui
2026-07-08 14:17 ` [PATCH v2 01/27] ASoC: codecs: da7213: Use guard() for mutex locks phucduc.bui
2026-07-08 14:17 ` [PATCH v2 02/27] ASoC: codecs: da7219: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 03/27] ASoC: codecs: es8316: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 04/27] ASoC: codecs: es8326: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 05/27] ASoC: codecs: es9356: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 06/27] ASoC: codecs: fs210x: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 07/27] ASoC: codecs: hdac_hdmi: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 08/27] ASoC: codecs: hdmi-codec: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 09/27] ASoC: codecs: idt821034: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 10/27] ASoC: codecs: lpass-macro: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 11/27] ASoC: codecs: madera: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 12/27] ASoC: codecs: max98095: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 13/27] ASoC: codecs: mt6359-accdet: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 14/27] ASoC: codecs: pcm512x: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 15/27] ASoC: codecs: pcm6240: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 16/27] ASoC: codecs: peb2466: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 17/27] ASoC: codecs: rt5514-spi: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 18/27] ASoC: codecs: rt5645: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 19/27] ASoC: codecs: rt5665: " phucduc.bui
2026-07-08 14:17 ` phucduc.bui [this message]
2026-07-08 14:17 ` [PATCH v2 21/27] ASoC: codecs: rt5677: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 22/27] ASoC: codecs: rt5682: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 23/27] ASoC: codecs: rt700: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 24/27] ASoC: codecs: rt711: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 25/27] ASoC: codecs: rt712: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 26/27] ASoC: codecs: rt721: " phucduc.bui
2026-07-08 14:17 ` [PATCH v2 27/27] ASoC: codecs: rt722: " phucduc.bui
2026-07-08 17:22 ` [PATCH v2 00/27] ASoC: codecs: Use guard() for mutex & spin locks - part 2 Mark Brown
2026-07-09  2:33   ` Bui Duc Phuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260708141734.578926-21-phucduc.bui@gmail.com \
    --to=phucduc.bui@gmail.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=arnd@arndb.de \
    --cc=baojun.xu@ti.com \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=herve.codina@bootlin.com \
    --cc=kees@kernel.org \
    --cc=kevin-lu@ti.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=lgirdwood@gmail.com \
    --cc=linusw@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=marco.crivellari@suse.com \
    --cc=matthias.bgg@gmail.com \
    --cc=nick.li@foursemi.com \
    --cc=oder_chiou@realtek.com \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=rf@opensource.cirrus.com \
    --cc=rongqianfeng@vivo.com \
    --cc=sammiee5311@gmail.com \
    --cc=sen@ti.com \
    --cc=shenghao-ding@ti.com \
    --cc=srini@kernel.org \
    --cc=support.opensource@diasemi.com \
    --cc=tiwai@suse.com \
    --cc=u.kleine-koenig@baylibre.com \
    --cc=zhangyi@everest-semi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.