From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 585BC3909A7 for ; Thu, 9 Jul 2026 00:50:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783558226; cv=none; b=azdLCKMkUMir4X8edoID2BogulJixQSKJOJvu2swpoUxcJTzGQ8Jix46yCA2S1SYxj58avi3thANU25gLhkz6HPgq32uF/AcxxmQo9U+Rfu+qbeciEM9VoKlnZV82skYJjKubi7y7R0BkhAwdNn7GW60OO4LOlIx1J0gd/n5mm0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783558226; c=relaxed/simple; bh=jr0jXQ9u/Eriff4ukSa+VuWIPf5TuQwic+1mOZqt0RI=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=mj3i8QVxL/Kleu03WZl9POdJ9KZ+wbV+cEnwJAZVFnONho4VFE9tST518OanyVVjsHoYMYnkpSSaldPr6FA/mtX0eEFBBVjol9zl51T7wsyICZYU7vDkSe4OnhCTY2y6hy9fRQIkyCrQngJTLwpjxx9HDL5ms3U+ypnpMN/kKo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AwbKYkmu; arc=none smtp.client-ip=209.85.128.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AwbKYkmu" Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-80bd5b5b3afso13848767b3.3 for ; Wed, 08 Jul 2026 17:50:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783558224; x=1784163024; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=MMeVGfxElC0Lxj76VZe3jY3LwxYN+PY2gW2pcA4KR74=; b=AwbKYkmumt0RbUIeOX+fB8H7YoBrJdrRF2L5nYlBgWinSpkaHUd32trSwcBHwZ7qMH NZcEhnQqbEwhZmft3s0UToTVmogmBgfv473fUmHSQcGHX7xAWdnWshyIOhS3mLqdnqPf 0YY5hAfCpv6Ycr9JwCIDt4e23gIw7FUTXSIThiECxe1AELU2PIMRN6ocZkaxAykYrxP7 pi6ako2p/sTBNJ9UT7k4oDMJW9XI9fDCLxK2Tqe9/LLgn9X2A3Tqvmt/4QBt4/FmqMCb ZZItDFKvmTnqgAldx7056Hb0aardOjNlzcC/ZXEuit+zq7fYh8f8TBfBVLwsg0C/8ZWL oZsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783558224; x=1784163024; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MMeVGfxElC0Lxj76VZe3jY3LwxYN+PY2gW2pcA4KR74=; b=NMQOPwqfD310dOQUxuiTK+UQzNte3GBreqYyfuAhTGbrCgvfKXq6rwYFOJ9mLuo+hj SAwQkhuFpoF5NHs8oRFkBtUhJBiM4dA8JHqVGYZfcDI/2YV8OPPkxl1We5JHltrGoc8I JgY5D4P5naKI7HzbDXgVhyFMk4qJ1/RceVX6mvEUVaNCWEktWq6QvxowSwlAD5H631g2 nmMGjZu2QBdPFs7CAPWK5UmbrXdZHFEB0wsFmt6mGOEvpENC18soCAUVbWY7S+k87PlF 82ASPGn59H2Zx80PMlNB71Eo5WhUrkR5QwtRGn+Rg1RJg5lcY3KodP5e8InjYvYCLh54 FULg== X-Forwarded-Encrypted: i=1; AHgh+Rr+qGzEWU4R0g0LZeXrJpJ6Zy48PjimHaCrBN5dpo0XIVEL1p03gdvfujrlevdbceDH12Fv/25armiL@vger.kernel.org X-Gm-Message-State: AOJu0Yw43UcITQIWrFHqwOnEKwgk3bnxNF0SsUU8KtWDGM/4lzvAu+gI HQ//NXPERvGezNjQRScsbwRqwBKe+lGc/N8JaSzIab/z5hD1BY4eu2qI5pvoMg== X-Gm-Gg: AfdE7cl+q2dRZ/4C3T+0E3R8O+H8zutbKADFZBXJl8y+CKJd3+5UPl3PQkzRopaTHbt nGvo/4nNMGlQT08W+Ye9F09fDplPN7dScA2H4pMymW6PX0BcINWJA/N9DH1KFUZdx1fpdg1Dv2h 1fNpG308kHSe8xZQ+nUtlSwzmEqngeoLLawd5k+6yTz8eM22YJ8YOLpAsgB/O7zaqgxyl5DDdsA +ZNBEVtKKzApZkI3WnW7pEV+HXTY/1VnoygXYjLkilkU084LDdH9kzWZ7Pr+nyodfFSgfEjdbT7 PhmYk6h8bTLGXyotKeThhDRTx2cka6Ah2GSZ3dGKgQiFgdzLCqdGSldaR+jvcRw4wxjbtrnCEt4 CBPC0BEJZaDYitzFjS4KlFS0jU1fQ4tNLV5KlYLhx8Qg+xUE0qGN1+06cFQKaf9DJdvahZYrAbG eKn6AUQ8Bj3eFlRqsE95Scq4yLWqOAeJ5XsV33NaJ515ohJA38qnnG3/IaCQ== X-Received: by 2002:a05:690c:60c6:b0:81e:6a10:f90f with SMTP id 00721157ae682-81e6a10f9edmr12376517b3.17.1783558224268; Wed, 08 Jul 2026 17:50:24 -0700 (PDT) Received: from fabio-Precision-3551.. ([2804:1b3:a800:b434:bc3c:5012:1fe:ac7c]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81e6befb688sm5645667b3.14.2026.07.08.17.50.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 17:50:22 -0700 (PDT) From: Fabio Estevam To: heiko@sntech.de Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Fabio Estevam Subject: [PATCH] arm64: dts: rockchip: Enable USB device mode on rk3588s-roc-pc Date: Wed, 8 Jul 2026 21:50:05 -0300 Message-ID: <20260709005006.413145-1-festevam@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Fabio Estevam The USB3 OTG controller on the ROC-PC can be used in device mode, but the board description only enabled the DWC3 controller and USB2 PHY. The USBDP PHY remained disabled and the controller had no role-switch default, so DWC3 did not register a UDC and USB gadget drivers such as g_mass_storage failed to bind. Enable the USBDP PHY and describe the controller as a USB role switch with peripheral as the default role. This lets the controller register as a UDC when no external role provider has selected a host role. Tested on a Firefly Station M3 by binding g_mass_storage to expose the eMMC as a USB mass-storage gadget. Signed-off-by: Fabio Estevam --- arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts index 99853880aaac..7150d5f7684d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts @@ -833,6 +833,12 @@ &usb_host0_ohci { &usb_host0_xhci { extcon = <&u2phy0>; + role-switch-default-mode = "peripheral"; + usb-role-switch; + status = "okay"; +}; + +&usbdp_phy0 { status = "okay"; }; -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A69FC43458 for ; Thu, 9 Jul 2026 00:50:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=4G7Vnb8ZmpR4arTn2mgFbb7Bug/Qg1bg6p7ULqAmTTc=; b=v25VxOs/CdCW9t SRWlTFXUWlCmY8mTCqjtfGGzIAVQPpXemY14H5LazJ3jdQ7lk9az1JaWCoc/kCbUvqJdASwnhnjzC FaPb730iSC6vc4cTbS9mEPX7vGOl0Bu8C5KUpfZq/ly66ML7al3ZvnJwbM0xThx2/YfcLTevjBDN8 l6p5AaZL5SzhuGbuQITpQCX5l1P7MXAcEb9IQHR9bska8TUTHH5d3nAud59r9+JLvdNqMFY1rZVV0 y6uktUxWewv2iGCEW+yChZiTUkRI1kq3gJ380j9N1aKEmRScyOzSxQSJpJTIDK9aak8SFD01l0ppO 2v3p9UyZvfhygBHsM7BA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whcyC-00000000fry-0Iwz; Thu, 09 Jul 2026 00:50:28 +0000 Received: from mail-yw1-x1136.google.com ([2607:f8b0:4864:20::1136]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whcyA-00000000fps-0RJx for linux-rockchip@lists.infradead.org; Thu, 09 Jul 2026 00:50:27 +0000 Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-8143daf89c7so15405397b3.1 for ; Wed, 08 Jul 2026 17:50:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783558224; x=1784163024; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=MMeVGfxElC0Lxj76VZe3jY3LwxYN+PY2gW2pcA4KR74=; b=spVcR9dQQ4YoSXk/aU1KbjWOeER6fT/n3ywDMLdYk3oPrxsKGNqDJua3IZjZq6gcK+ Ld0flbqeIWeEcyNJqJer0grgCD1VG05IfvQbgD0CcdkhJ0LVnFnEbW1bLNc4pEPQr+f1 EsVd4rQZbPA+SfVqAnrxK069sTOjzpERu5XxB5aTj4kxrtdF0uxv+mdO1goDUssk8twO jA/hgiI46JcYm2kFQHB6hfxrymPkPVscgEkeuvuldl6b/Cy7CeRBwP3cPrYsJlH+eH9k VuPGtjXHI9RJTDRLJkC1zz9PCS1S6BeHR+jwnFhZTGSRWKWsmd33ufBDfKgyHEfukuwu Jsvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783558224; x=1784163024; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=MMeVGfxElC0Lxj76VZe3jY3LwxYN+PY2gW2pcA4KR74=; b=FyYSavmnkLLazKGqzh6/VllpYl7IyYbkcUGfoBk67U+AkE6CMrTLdWxdegsoKZn95x xmxDrbxDMOWoCJUd0L0XXKXLIGpDJMebSacKDMMMPQLrYMEOCZnCjbtTQm95BjO5DMQ1 /6SA/RV/+m9lqOsU03FyYLKdDCW4sexpF/+VtSZV7s9HEaJyPGQsPQxjMSalR+DzHH+k u1SWwcX11BQZF1xGi5/XtRESHVmw19oLrtI35OL01zqJ0h98aCmctPX34wiBr76+TzPu NQFm9YnG8DBofa3fRfxefS3v5fwInN50ER/s4YVD/T5uDBljfKE1d/rv0bTa9JqJEe3i Caww== X-Forwarded-Encrypted: i=1; AHgh+Rr23PxPljvvUF31PIVLAUVzZASwqsJw0LZO62Jg/94Vj8hIm6ECxMscxLxKF0lQY/T3z1ZQGT6bgHvCPwT0rA==@lists.infradead.org X-Gm-Message-State: AOJu0YywicgVn5DFrqxZtIEdyjKdEa+FNBK9nwTUBrMrEPxNDFnHfb46 4wTzbA4NlCj66fkIftacYLWerKFJFXsdZlR6PqWFO8ZYe//LOdIL3F0L X-Gm-Gg: AfdE7cnUqtCZFzyf1Cbml6CJWrI0c+27+WBbqudjasoDAnMj5eXDRpZMOS0JGt8TJyP z2qYOj4U99T28ll4mtX5h3J7F0YQ1s567QBFPE61lERjVtUqroKhXHFBJuliLlmc+fNqaElJ+pp ZRJd2DFfe8qky9eAG/aipwB9iCU9mKtMIY7odfhIc+Gji7Kinbm2F3aRa5NYNYkZ1//d5qR/u6b vlsCnzIO2cXzb2nKXx+Ht3figpxZj4IWM7EMqMEVGfR3RX5Iqx/Mb6qP50Yv5xeIIcTyRQiZCZX oDpSxIZgMZDD3FVWdPgAfigsUlHEOymPTiCHpokJhgkeCKUi6bLHb3dxuCboRjZRoUWDxdBR27e vm0tvK6DTIpuBJAOIaMtQYIwZzIy01BBDn+xMBOAzqEOxvADnWjO49wXoLHGDFsB4Dt0IKP/B0J HGXrBpWg0Xl26Pj650cLg+lH88r5T1sOtA+mbuzf8J4gvp8p9MWvXZYUDTtg== X-Received: by 2002:a05:690c:60c6:b0:81e:6a10:f90f with SMTP id 00721157ae682-81e6a10f9edmr12376517b3.17.1783558224268; Wed, 08 Jul 2026 17:50:24 -0700 (PDT) Received: from fabio-Precision-3551.. ([2804:1b3:a800:b434:bc3c:5012:1fe:ac7c]) by smtp.gmail.com with ESMTPSA id 00721157ae682-81e6befb688sm5645667b3.14.2026.07.08.17.50.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jul 2026 17:50:22 -0700 (PDT) From: Fabio Estevam To: heiko@sntech.de Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Fabio Estevam Subject: [PATCH] arm64: dts: rockchip: Enable USB device mode on rk3588s-roc-pc Date: Wed, 8 Jul 2026 21:50:05 -0300 Message-ID: <20260709005006.413145-1-festevam@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260708_175026_151435_B1ACFE7B X-CRM114-Status: GOOD ( 10.93 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org From: Fabio Estevam The USB3 OTG controller on the ROC-PC can be used in device mode, but the board description only enabled the DWC3 controller and USB2 PHY. The USBDP PHY remained disabled and the controller had no role-switch default, so DWC3 did not register a UDC and USB gadget drivers such as g_mass_storage failed to bind. Enable the USBDP PHY and describe the controller as a USB role switch with peripheral as the default role. This lets the controller register as a UDC when no external role provider has selected a host role. Tested on a Firefly Station M3 by binding g_mass_storage to expose the eMMC as a USB mass-storage gadget. Signed-off-by: Fabio Estevam --- arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts b/arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts index 99853880aaac..7150d5f7684d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588s-roc-pc.dts @@ -833,6 +833,12 @@ &usb_host0_ohci { &usb_host0_xhci { extcon = <&u2phy0>; + role-switch-default-mode = "peripheral"; + usb-role-switch; + status = "okay"; +}; + +&usbdp_phy0 { status = "okay"; }; -- 2.43.0 _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip