All of lore.kernel.org
 help / color / mirror / Atom feed
From: SJ Park <sj@kernel.org>
To: Gutierrez Asier <gutierrez.asier@huawei-partners.com>
Cc: SJ Park <sj@kernel.org>,
	artem.kuzin@huawei.com, stepanov.anatoly@huawei.com,
	wangkefeng.wang@huawei.com, yanquanmin1@huawei.com,
	zuoze1@huawei.com, damon@lists.linux.dev,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/3] mm/damon: Introduce a huge page collapsing mechanism using auto tuning
Date: Wed,  8 Jul 2026 17:52:23 -0700	[thread overview]
Message-ID: <20260709005224.128135-1-sj@kernel.org> (raw)
In-Reply-To: <8b8cb8b6-41ff-4975-9be2-7256b180fcda@huawei-partners.com>

On Wed, 8 Jul 2026 17:50:57 +0300 Gutierrez Asier <gutierrez.asier@huawei-partners.com> wrote:

> Hi SJ,
> 
> On 7/8/2026 4:22 AM, SJ Park wrote:
> > On Tue, 7 Jul 2026 17:25:36 +0300 Gutierrez Asier <gutierrez.asier@huawei-partners.com> wrote:
[...]
> >> I have no idea, to be honest. I will try to test with different databasesizes with temporal and consistent policies. The behaviour was weird to me,
> >> but I don't know if this was a TEMPORAL policy issue or I didn't set the
> >> DAMON parameters correctly.
> > 
> > Thank you for transparently sharing your thought.  And this is little bit
> > concerning me.  It feels like we don't really have a good theory about what
> > change will make what results for what reason.  It rather feels like we just
> > doing random experiments and showing the random results.
> > 
> > I understand having data first and developing the theory driven by data is also
> > a good approach.  But I feel like this is a time to step back and think about
> > what we're doing.
> > 
> > IIRC, your initial experiment results on the very early version of this series
> > looked promising.  But from a point, it looked like just random.  Maybe I gave
> > you wrong change request, or some test environment has unexpectedly changed.
> > 
> > How about summarizing what tests you did so far, what changes in the kernel and
> > the test setup has made for each iteration, and how the results have changed?
> > 
> > If it has been too long since the older tests, just doing the tests again or
> > dive deep into debugging of your current setup with the all mighty printk() on
> > core DAMON internall code can be an option.
> > 
> > Have you also monitored DAMOS stats while the tests are ongoing?  Maybe that
> > could also be a good debugging option for understanding what's going on as
> > expected vs not.
> The problem I've been having is inconsistent results. This may be due to thefact that I'm testing primarily with database, which contains a lot of
> variable data, like indexes that may be hit sometimes, and other times not,
> different data distribution, etc.

Makes sense.  Testing is another challenging area of arts.

If you find it is too difficult to have a stable test setup, I wouldn't mind
using more artificial test setup for test results on this series' cover letter.
I'd request it to be only makes sense and shows a sane and complete story.

It would be really great if you can apply this on more realistic environments
and share the wins.  But that's not necessarily a blocker of this series in my
opinion.

> 
> I've been trying to get a test as consistent as possible, pinning the
> database to a single NUMA node and the tests script to another one, avoid
> network traffic, etc.
> 
> I am almost done getting some consistent data.

Cool.

> 
> Maybe I can use perf to get DAMOS tracing. Would that make it?

Yes, that should work.

'damo' also provides a wrapper of 'perf' for tracing purpose.  If you want to
try it, I'd suggest something like below:

    damo report trace --event damon:damos_esz damon:damos_stat_after_apply_interval

[...]
> Thanks to you. I will keep testing and keep you posted in the coming days.

You're welcome.  No rush.  Take your time and fun :)


Thanks,
SJ

[...]

  reply	other threads:[~2026-07-09  0:52 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16 15:03 [PATCH v1 0/3] mm/damon: Introduce a huge page collapsing mechanism using auto tuning gutierrez.asier
2026-06-16 15:03 ` [PATCH v1 1/3] mm/damon: Introduce DAMOS_QUOTA_HUGEPAGE " gutierrez.asier
2026-06-16 15:20   ` sashiko-bot
2026-06-16 19:33     ` Gutierrez Asier
2026-06-17  3:31   ` SeongJae Park
2026-06-16 15:03 ` [PATCH v1 2/3] mm/damon: introduce DAMON_HUGEPAGE for hot region hugepage collapsing gutierrez.asier
2026-06-16 15:21   ` sashiko-bot
2026-06-16 19:27     ` Gutierrez Asier
2026-06-17  4:09       ` SeongJae Park
2026-06-17  4:04   ` SeongJae Park
2026-06-18  0:16     ` SeongJae Park
2026-06-18  0:19       ` SeongJae Park
2026-06-18 11:51       ` Gutierrez Asier
2026-06-18 14:57         ` SeongJae Park
2026-06-18 14:59           ` Gutierrez Asier
2026-06-18 15:08             ` SeongJae Park
2026-06-17 16:12   ` Julian Braha
2026-06-18  0:18     ` SeongJae Park
2026-06-16 15:03 ` [PATCH v1 3/3] mm/damon/sysfs: support hugepage_mem_bp quota goal metric gutierrez.asier
2026-06-16 15:21   ` sashiko-bot
2026-06-16 19:35     ` Gutierrez Asier
2026-06-17  4:15       ` SeongJae Park
2026-06-17  4:16   ` SeongJae Park
2026-06-17  1:44 ` [PATCH v1 0/3] mm/damon: Introduce a huge page collapsing mechanism using auto tuning SeongJae Park
2026-06-20 17:11   ` Gutierrez Asier
2026-06-20 20:02     ` SeongJae Park
2026-07-07 13:31       ` Gutierrez Asier
2026-07-07 14:10         ` SJ Park
2026-07-07 14:25           ` Gutierrez Asier
2026-07-08  1:22             ` SJ Park
2026-07-08 14:50               ` Gutierrez Asier
2026-07-09  0:52                 ` SJ Park [this message]
2026-07-06 15:03     ` Gutierrez Asier
2026-07-06 15:16       ` SJ Park
2026-07-13 11:30         ` Gutierrez Asier
2026-07-13 14:45           ` SJ Park
2026-07-13 15:04             ` Gutierrez Asier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260709005224.128135-1-sj@kernel.org \
    --to=sj@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=artem.kuzin@huawei.com \
    --cc=damon@lists.linux.dev \
    --cc=gutierrez.asier@huawei-partners.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=stepanov.anatoly@huawei.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=yanquanmin1@huawei.com \
    --cc=zuoze1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.