Re: [PATCHv2 3/3] ARM: dts: helios4: add SATA regulator supplies

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The struct device reference acquired by of_find_device_by_node() is never released, causing a memory leak.
--

--- Patch [1]: [PATCHv2 3/3] ARM: dts: helios4: add SATA regulator supplies ---
commit 737d149c64d97348e97b79fed6b2378d4f1a140f
Author: Rosen Penev <rosenp@gmail.com>

ARM: dts: helios4: add SATA regulator supplies

The ahci-mvebu driver and libahci_platform request three supplies
on SATA controller and port nodes to avoid regulator core boot notices.
The SATA controller and PHY are powered by the 3.3V I/O rail, while the
four disk bays are powered by the 5V HDD rail.

> diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> index ec134e22bae3e..af1e81638f829 100644
> --- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> +++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> @@ -217,13 +217,17 @@ sata@a8000 {
>  				status = "okay";
>  				#address-cells = <1>;
>  				#size-cells = <0>;
> +				ahci-supply = <&reg_3p3v>;
> +				phy-supply = <&reg_3p3v>;
>  
>  				sata0: sata-port@0 {
>  					reg = <0>;
> +					target-supply = <&reg_5p0v_hdd>;

[Severity: High]
This is a pre-existing issue and was not introduced by this patch, but doesn't
adding these supplies increase the chance of memory leaks during probe
deferrals?

In drivers/ata/libahci_platform.c:ahci_platform_get_resources(), the device
reference acquired by of_find_device_by_node() is never released:

			port_dev = of_find_device_by_node(child);

			if (port_dev) {
				rc = ahci_platform_get_regulator(hpriv, port,
								&port_dev->dev);
				if (rc == -EPROBE_DEFER)
					goto err_out;
			}

If the newly added target-supply regulators return -EPROBE_DEFER, the probe
fails and is retried. This unconditionally leaks a struct platform_device
reference on every retry because put_device() is never called for port_dev.

>  				};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709005005.1587852-4-rosenp@gmail.com?part=1