All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Janne Grunau" <j@jannau.net>
Cc: devicetree@vger.kernel.org, robh@kernel.org,
	linux-watchdog@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 05/11] dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles
Date: Thu, 09 Jul 2026 07:45:25 +0000	[thread overview]
Message-ID: <20260709074526.7DFE31F00A3A@smtp.kernel.org> (raw)
In-Reply-To: <20260709-apple-t603x-initial-devices-v1-5-55b305833123@jannau.net>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The commit message contains a typographical error when listing the newly added compatible strings. It incorrectly claims to add '"apple,t6030-pmgr-pwrstate" for M3 Pro and "apple,t6030-pmgr-pwrstate" for M3 Max and Ultra', repeating 't6030' instead of correctly stating that 'apple,t6031-pmgr-pwrstate' was added for the M3 Max and Ultra, which matches the actual patch contents.
--

--- Patch [5]: [PATCH 05/11] dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles ---
commit a32e592d592072e4f59a9b2c56534397db2aadf2
Author: Janne Grunau <j@jannau.net>

dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles

This commit adds the apple,t6030-pmgr-pwrstate and apple,t6031-pmgr-pwrstate
compatible strings for Apple M3 Pro, Max, and Ultra SoCs.

> dt-bindings: power: apple,pmgr-pwrstate: Add t6030 and t6031 compatibles
>
> The pmgr-powerstate registers on Apple M3 Pro, Max and Ultra SoCs are
> compatible with "apple,t8103-pmgr-pwrstate". Add
> "apple,t6030-pmgr-pwrstate" for M3 Pro and "apple,t6030-pmgr-pwrstate"
> for M3 Max and Ultra as per-SoC compatibles.

[Severity: Low]
This isn't a bug, but should the second compatible string mentioned in the
description be apple,t6031-pmgr-pwrstate to match the changes made in the
patch?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-apple-t603x-initial-devices-v1-0-55b305833123@jannau.net?part=5

  reply	other threads:[~2026-07-09  7:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09  7:30 [PATCH 00/11] Initial Apple M3 Pro, Max and Ultra device trees Janne Grunau
2026-07-09  7:30 ` [PATCH 01/11] dt-bindings: arm: apple: Add M3 Pro/Max/Ultra devices (T603x) Janne Grunau
2026-07-09  7:44   ` sashiko-bot
2026-07-09 17:47   ` Conor Dooley
2026-07-09 17:50     ` Conor Dooley
2026-07-09 18:05       ` Janne Grunau
2026-07-09  7:30 ` [PATCH 02/11] dt-bindings: interrupt-controller: apple,aic2: Invert #interrupt-cells condition Janne Grunau
2026-07-09  7:42   ` sashiko-bot
2026-07-09 17:49   ` Conor Dooley
2026-07-09  7:30 ` [PATCH 03/11] dt-bindings: interrupt-controller: apple,aic2: Add apple,t6031-aic3 compatible Janne Grunau
2026-07-09 17:49   ` Conor Dooley
2026-07-09  7:30 ` [PATCH 04/11] dt-bindings: arm: apple: apple,pmgr: Add t6030 and t6031 compatibles Janne Grunau
2026-07-09  7:44   ` sashiko-bot
2026-07-09 17:50   ` Conor Dooley
2026-07-09  7:30 ` [PATCH 05/11] dt-bindings: power: apple,pmgr-pwrstate: " Janne Grunau
2026-07-09  7:45   ` sashiko-bot [this message]
2026-07-09 17:51   ` Conor Dooley
2026-07-09  7:30 ` [PATCH 06/11] dt-bindings: watchdog: apple,wdt: " Janne Grunau
2026-07-09 17:51   ` Conor Dooley
2026-07-09  7:30 ` [PATCH 07/11] dt-bindings: pinctrl: apple,pinctrl: " Janne Grunau
2026-07-09 17:51   ` Conor Dooley
2026-07-10 19:48   ` Linus Walleij
2026-07-09  7:30 ` [PATCH 08/11] dt-bindings: i2c: apple,i2c: " Janne Grunau
2026-07-09 17:52   ` Conor Dooley
2026-07-09 23:17   ` Piotr Masłowski
2026-07-09  7:30 ` [PATCH 09/11] dt-bindings: pwm: apple,s5l-fpwm: " Janne Grunau
2026-07-09  7:48   ` sashiko-bot
2026-07-09 17:53   ` Conor Dooley
2026-07-09  7:30 ` [PATCH 10/11] arm64: dts: apple: Initial T603[124] (M3 Max and Ultra) device trees Janne Grunau
2026-07-09  7:53   ` sashiko-bot
2026-07-09  7:30 ` [PATCH 11/11] arm64: dts: apple: Initial T6030 (M3 Pro) " Janne Grunau
2026-07-09  7:57   ` sashiko-bot
2026-07-09 12:57 ` [PATCH 00/11] Initial Apple M3 Pro, Max and Ultra " Janne Grunau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260709074526.7DFE31F00A3A@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=j@jannau.net \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.