Re: [PATCH v11 1/3] dt-bindings: pwm: dwc: Document optional resets property

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Inconsistent Related Binding: The related timer binding (snps,dw-apb-timer.yaml) was not updated to support the two reset inputs, causing a mismatch within the same hardware family.
--

--- Patch [1]: [PATCH v11 1/3] dt-bindings: pwm: dwc: Document optional resets property ---
commit 9b39c1c87d6471d2eec01acf8e6da72e82635001
Author: Xuyang Dong <dongxuyang@eswincomputing.com>

dt-bindings: pwm: dwc: Document optional resets property

This commit updates the DesignWare PWM binding to document two optional
active-low reset lines, presetn and timer_N_resetn, to support future
use of resets for this IP block.

> diff --git a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml
> --- a/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml
> +++ b/Documentation/devicetree/bindings/pwm/snps,dw-apb-timers-pwm2.yaml
[ ... ]
> @@ -43,6 +43,11 @@ properties:
>        - const: bus
>        - const: timer
>  
> +  resets:
> +    items:
> +      - description: Interface bus (presetn) reset
> +      - description: PWM timer logic (timer_N_resetn) reset
> +

[Severity: Medium]
Since the DesignWare PWM IP has two reset lines for this hardware family,
does the related timer binding also need a matching update?

Currently, the sibling timer binding restricts resets to a single item:

Documentation/devicetree/bindings/timer/snps,dw-apb-timer.yaml:properties.resets
  resets:
    maxItems: 1

If an SoC device tree author adds both reset lines to a snps,dw-apb-timer
node to match the hardware capabilities described here, dt_binding_check
will reject the valid hardware description.

Could the sibling timer binding be updated in this series to prevent
this inconsistency and allow for both reset lines?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709081337.2022-1-dongxuyang@eswincomputing.com?part=1