From: Max Kellermann <max.kellermann@ionos.com>
To: idryomov@gmail.com, amarkuze@redhat.com,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Max Kellermann <max.kellermann@ionos.com>
Subject: [PATCH] fs/ceph/mds_client: use detach_cap_releases() in ceph_send_cap_releases()
Date: Thu, 9 Jul 2026 12:48:56 +0200 [thread overview]
Message-ID: <20260709104856.900685-1-max.kellermann@ionos.com> (raw)
Eliminate some redundant code.
Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
---
fs/ceph/mds_client.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c
index 853bf698b356..578c1909e18f 100644
--- a/fs/ceph/mds_client.c
+++ b/fs/ceph/mds_client.c
@@ -1799,16 +1799,19 @@ static void __open_export_target_sessions(struct ceph_mds_client *mdsc,
* session caps
*/
-static void detach_cap_releases(struct ceph_mds_session *session,
- struct list_head *target)
+static int detach_cap_releases(struct ceph_mds_session *session,
+ struct list_head *target)
{
struct ceph_client *cl = session->s_mdsc->fsc->client;
+ const int num_cap_releases = session->s_num_cap_releases;
lockdep_assert_held(&session->s_cap_lock);
list_splice_init(&session->s_cap_releases, target);
session->s_num_cap_releases = 0;
doutc(cl, "mds%d\n", session->s_mds);
+
+ return num_cap_releases;
}
static void dispose_cap_releases(struct ceph_mds_client *mdsc,
@@ -2464,9 +2467,7 @@ static void ceph_send_cap_releases(struct ceph_mds_client *mdsc,
spin_lock(&session->s_cap_lock);
again:
- list_splice_init(&session->s_cap_releases, &tmp_list);
- num_cap_releases = session->s_num_cap_releases;
- session->s_num_cap_releases = 0;
+ num_cap_releases = detach_cap_releases(session, &tmp_list);
spin_unlock(&session->s_cap_lock);
while (!list_empty(&tmp_list)) {
--
2.47.3
next reply other threads:[~2026-07-09 10:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 10:48 Max Kellermann [this message]
2026-07-14 4:45 ` [PATCH] fs/ceph/mds_client: use detach_cap_releases() in ceph_send_cap_releases() Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709104856.900685-1-max.kellermann@ionos.com \
--to=max.kellermann@ionos.com \
--cc=amarkuze@redhat.com \
--cc=ceph-devel@vger.kernel.org \
--cc=idryomov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.