Re: [PATCH 42/60] drm/armada: Convert to atomic_create_state

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Missing static modifier and orphaned prototype for armada_plane_create_state.
--

--- Patch [42]: [PATCH 42/60] drm/armada: Convert to atomic_create_state ---
commit ef234958ddf9c7a237937375b8f630e71d5f0286
Author: Maxime Ripard <mripard@kernel.org>

drm/armada: Convert to atomic_create_state

This commit converts the armada plane reset implementation to use
atomic_create_state instead of a custom reset state subclass. The
conversion was performed using a Coccinelle semantic patch.

> diff --git a/drivers/gpu/drm/armada/armada_plane.c b/drivers/gpu/drm/armada/armada_plane.c
> index fe46a8e4508a2..1f5172d6816b3 100644
> --- a/drivers/gpu/drm/armada/armada_plane.c
> +++ b/drivers/gpu/drm/armada/armada_plane.c
[ ... ]
> @@ -256,15 +256,16 @@ static const struct drm_plane_helper_funcs armada_primary_plane_helper_funcs = {
>  	.atomic_disable	= armada_drm_primary_plane_atomic_disable,
>  };
>  
> -void armada_plane_reset(struct drm_plane *plane)
> +struct drm_plane_state *armada_plane_create_state(struct drm_plane *plane)

[Severity: Low]
Should armada_plane_create_state() be marked as static here?

Compiling armada_plane.c without the static modifier triggers a
-Wmissing-prototypes warning for this function since there is no matching
header declaration.

Additionally, since this replaces armada_plane_reset(), does the
armada_plane.h header still contain the obsolete prototype for
armada_plane_reset() that should be cleaned up alongside this change?

>  {
>  	struct armada_plane_state *st;
> -	if (plane->state)
> -		__drm_atomic_helper_plane_destroy_state(plane->state);
> -	kfree(plane->state);
>  	st = kzalloc_obj(*st);
> -	if (st)
> -		__drm_atomic_helper_plane_reset(plane, &st->base);
> +	if (!st)
> +		return ERR_PTR(-ENOMEM);
> +
> +	__drm_atomic_helper_plane_state_init(&st->base, plane);
> +
> +	return &st->base;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709-drm-no-more-plane-reset-v1-0-302d986fe5f0@kernel.org?part=42