From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1649E435EEA for ; Thu, 9 Jul 2026 16:27:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783614427; cv=none; b=TAPTmiihOf6brOhMGNKjKj4NDPcaPNQEQDZip+ZuLnhJLu47ATou8Hp1x6njsarAHCkk309tWnYp/VH8tzt5gUzYgaUFD7dvj/ar3evI1S4EBYdvbRc/m13ycJgNXvxVWp563J0VqNY/PPaxF1i4PLexD2T8abDOhT28g7XQvuk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783614427; c=relaxed/simple; bh=S/xAtxH9kCAjFwM1/MAEgEQMpcNiqhEBM0MEXLopRqg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=FELSPzNx7ooNFNzuOTcd+6ff7zRl9WETchUD2E3B7PSPKRfCwmq92hFdTZiFj80feEHkhClxBJp1AEiEPDU3/ayROsNUSOve+gjg/RCVs0cJKQ28OgEV8iE2squewnaJm2o9pU6WrMBGNCBivyYuADqKr+zKv7azKFlBlHBBcSo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f66IYRb3; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f66IYRb3" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-493b1710405so12634875e9.2 for ; Thu, 09 Jul 2026 09:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783614423; x=1784219223; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=GEOL8DOWD1Msvjz7k5cAG0xDAOqwGsu0BnpwMff10wU=; b=f66IYRb3W3n4wUp60vuJmeagFdempVA19+GvfglfbGXQNr32Jgf6Zu59Uj+bcep6dg jsx4MIO/Rg0Jc8lrVT/RQMxMMW76zzTchDs11lEHMl8wueX5jr2m95gnsMPuCp+FiVia BXcS1RfCaig3WVexG8fiT0f1WyIZI2ZFqmCdfMorSUHquBf0Y5WGXwn3lYxbxm4/2faj NWGL5ZyKcF+WzWoxiQjAkz+rxwePY89gZ4a0ESMuDMMFx4G3ZLECB3j0O5NlKwsrjWw/ 4IqBiE/i3mAHjgYbMO+ob6qHoEPfbgtS+ClBm3imDY87X4M/jBzC1B5Fmge7V4/JxTvX p0Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783614423; x=1784219223; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GEOL8DOWD1Msvjz7k5cAG0xDAOqwGsu0BnpwMff10wU=; b=S8sVURAXM2PhvQBio2wIY96BKI4TJWQxW03QtmBmbeWB6UW/YD66abq2usEt+7F7Q2 U0qqmgG5r9ZP8QTkaA4oMyjims3bFxMotJvftUF13NhU5YGFpuVbU+SoEevJTzLBc5J/ kG35CC3O7h6xJBFSu5nDNXQUtHdRQ5VnJUXnSnc2G9irSu0UF58eZ2SUUfVBcyLAosb2 jRGMUWy04ti8i4KLfF7rTkprcsT7RCn/pwrh35kvtT9fKtO6JiOz8N374k31Rwb3pSQL EMZuuAJtxM0M294ch5my1fmdvNGqVmYcSuZDXLvnxsxWkWQ2QzviEVHPaglaLBW9rN45 qE5g== X-Forwarded-Encrypted: i=1; AHgh+Rq2X/y4UXfKv327UPQWWDuHoIhwv2ndIdGja770OT3Q0FrK7ebbw57oNh+o8QbD7RyiPx4DZiFJJsUDC+E=@vger.kernel.org X-Gm-Message-State: AOJu0YzQGMflhiYSiJgGsKVCbhePgtyNTpuI75moS5w+0jQJ6OjLh/NK gqG/LVDaCm4m3CLOsQTlV5VcKSs8TY2EXh/XUBm0SiRfVaPIbfRqdCvS X-Gm-Gg: AfdE7cnzbGowS8I/x+VA0z4yMxmz1NV72+mH0cw51iwGpMor0MweOjMBnBleqtXW7LG OIQfVZL6ed+YssEWlQ8y5u3uOfT7eLGOUErBsERdGa8uxQ34RBfwJQZlW8leY593fwAEwWkYovK U5jDhS18bXxtdDKxJbhBqILKslyc5NovOm7aAqA1BlmjZjo3Zj2v1klZH3PQYxyLxEoBae5Jdnc 3ILUxE0dbeEim0M17zJ/O2v7sXnMjSiGsHuZN6ouu8/DmIw3J0vrdM1tcRSHE+GMEL7A03dcqs5 0My/1dDCEsI+N4J+p640UfYpiMPEP9w0qfFRhQOqkxX52y3UYyyIFLYDoy14iwKllLIjRd8Yytz EjOCC6rV0GC5kkZxQmCbdnpUjvcKdXTFKec82N6m+EKBJaZ3w6WHoi6RSyCkTtTItIU/MMZRCOI RuFQCmnbXQhhXIEp/IGrghvXotxok/jDUHEFlNIcgegDhUGQ== X-Received: by 2002:a05:600d:6405:10b0:493:eec0:2b8c with SMTP id 5b1f17b1804b1-493eec02c80mr19641245e9.12.1783614423204; Thu, 09 Jul 2026 09:27:03 -0700 (PDT) Received: from pumpkin (host-92-21-50-228.as13285.net. [92.21.50.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb670a41sm70023415e9.0.2026.07.09.09.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 09:27:02 -0700 (PDT) Date: Thu, 9 Jul 2026 17:26:59 +0100 From: David Laight To: Thomas Gleixner Cc: Michal =?UTF-8?B?U3VjaMOhbmVr?= , LKML , Peter Zijlstra , Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Kees Cook , Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sven Schnelle , linux-s390@vger.kernel.org, x86@kernel.org, Mark Rutland , Jinjie Ruan , Andy Lutomirski , Oleg Nesterov , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool Message-ID: <20260709172659.7040db33@pumpkin> In-Reply-To: <87ik6pqdkf.ffs@fw13> References: <20260707181957.433213175@kernel.org> <20260707190254.338083894@kernel.org> <87se5tqkyp.ffs@fw13> <87ik6pqdkf.ffs@fw13> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-parisc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 09 Jul 2026 01:14:24 +0200 Thomas Gleixner wrote: > On Wed, Jul 08 2026 at 22:34, Thomas Gleixner wrote: > > On Wed, Jul 08 2026 at 17:52, Michal Such=C3=A1nek wrote: > > Q: Is it perfect? > > A: No > > > > Q: Can it be made perfect? > > A: No, because you can't change history and established practice. > > > > Just for illustration. Changing the logic in trace_syscall_enter() to: > > > > --- a/kernel/entry/syscall-common.c > > +++ b/kernel/entry/syscall-common.c > > @@ -9,13 +9,15 @@ > > =20 > > bool trace_syscall_enter(struct pt_regs *regs, long *syscall) > > { > > + long orig_syscall =3D *syscall; > > + > > trace_sys_enter(regs, *syscall); > > /* > > * Probes or BPF hooks in the tracepoint may have changed the > > * system call number. Reread it. > > */ > > *syscall =3D syscall_get_nr(current, regs); > > - return *syscall !=3D -1L; > > + return *syscall =3D=3D orig_syscall || *syscall !=3D -1L; > > } > > =20 > > void trace_syscall_exit(struct pt_regs *regs, long ret) > > > > does not make #2 magically go away. It's still the same problem whether > > you like it or not. =20 >=20 > And just to be entirely clear, the syscall() interface has to be correct > in the first place, but then it's all about performance. >=20 > So the sequence of: >=20 > pt_regs =3D PUSH_REGS(); > syscall =3D pt_regs->syscall_reg; > pt_regs->result =3D -ENOSYS; >=20 > arch_syscall(pt_regs, syscall) { > if (likely(syscall_enter_from_user_mode(pt_regs, &syscall) { I guess most architectures inline that to avoid the &syscall. Otherwise you'd want: syscall =3D syscall_enter_from_user_mode(pt_regs, syscall); with the 'error' return being selected to fail the test below (which -1L converted to ~0UL will do nicely). David > if (syscall < SYSCALL_max) > pt_regs->result =3D invoke_syscall(pt_regs, syscall); > } > ,,,, > } > pt_regs->($RETURN_VALUE) =3D pt_regs->result; > POP_REGS(); > return; >=20 > is the correct and obviuosly most efficient way idependent of the -1L > return value overload in the original implementation, which this series > gets rid of for clarity. >=20 > If an architecture decide[sd] to do otherwise and makes up it's own rules > which only cover parts of the problem then it _is_ an architecture > problem and not something which has to be solved by claiming that every > architecture has to implement the same nonsense as you falsely claimed > in your RFC^WPOC^Whack thread: >=20 > "However, the API should be specified in a way that does not require > everyone implementing such flag." >=20 > There is _ZERO_ requirement for any architecture to implement that > flag. Just because S390 decided it's a brilliant idea to do so does not > make it a requirement for everyone. >=20 > No. Every other architecture got it right because they looked at the > historical patterns despite having correct documentation at hand. >=20 > Feel free to prove me wrong with actual facts. >=20 > Thanks, >=20 > tglx >=20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1D62FC44501 for ; Thu, 9 Jul 2026 16:27:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EKYZi4gkjeUFXN+tG9Nm464f+7l2CjBtzuBdHxRweKQ=; b=XzfqtcB9ixMr3L cALlDqeAawxkvOyV+tUsRDBY+iKm0hhSiM2ji0gZurdD2kBaWp7ORzBjzClz/acPZLH3wkydGBjL2 y8WXFuKPnLxiqjnr4tfhXbzBru4pnj9CxFPl99M/KeivU7Vt2ImqqNXqLIQd6nOAkO5maFwptKwMJ TYz8txqBLqCRh919XhgcNZrOqOwZHYPYNiGCHwGGmm8TalxwxGIrN8V2yYlyNKm1Rk1HNuSXwYja5 xIxz5ShGlXnIk8tPy7ckX/EgxMUAHeRU5V/d4ouTl01HVhwtKtCAyldjTDeUrrzn7wsnC0HvVf8kv E6+Cru1shrYSKIMvw7oQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whrae-000000032Wp-3aeD; Thu, 09 Jul 2026 16:27:08 +0000 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whrab-000000032V6-403J for linux-snps-arc@lists.infradead.org; Thu, 09 Jul 2026 16:27:07 +0000 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-493ece78b0cso33945e9.0 for ; Thu, 09 Jul 2026 09:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783614423; x=1784219223; darn=lists.infradead.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=GEOL8DOWD1Msvjz7k5cAG0xDAOqwGsu0BnpwMff10wU=; b=AeIAtOBk9ppvRbASqtFmqsdVQfMtDivwmws+YytjgA9HJz/wdmFbBoIiFKHFAqF+vS 99pkJb1Q12cuQPTmQpCS3kftHi6w6yQptvVO94YJ1Xbchm1r3e8fV1yrJAIwi8uqgcn5 S8+R8wRAkSFDUUCXGND0tK8bx0HP90yYDJ9DlCx8PLmYERl2HUxZNFbEGBUCgxQOzlu0 6xFEwrwplrEITF890qj2tDh1X6EMlUj8BzkErlYcZ/WYPai5ZdhD9J/z2aeoNXGmnIOV etef50DkFdmN1OcnzJBotB9zUUD6Z24f/csEkT//H4GwOSe9KZVstjpP2RlGtIV7rnYE yXdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783614423; x=1784219223; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GEOL8DOWD1Msvjz7k5cAG0xDAOqwGsu0BnpwMff10wU=; b=sgZ4rp0mkOyP25XBBLh9hJG+FY9zcwh1c/gEjAxDI210ErGXdzNcB3v3OX5VtkvA06 TDWbgsarZe3qIneHR1WReF5jQ3+pc/YE57b/963t08jxcZb/GSYXxHavS5ndvH1grjXN spDXqKFIDd7deAujySy1qGOIZVdCNTqwutPrgEJGfIdLDkHSDStrNKm8z9KfCeNn+n+c oHmp9mtSCttEcCUylLEDSFX/Hy++la09A67Kxd5zfFYv4+j0Qmbu3ZJnrbYTjPIBM1Qt 854DVMrDnCgea9K2SYNvb2WNfKpyEbrEBxEaiERy0EV8iSzuNXIwTUNAthP+T08qPoYB mkaw== X-Forwarded-Encrypted: i=1; AHgh+RoinW5/Oq5qpPAGeD4isCOEJIvZrPf1IyncDfvGt40gJIeFr7t+ewGeRbrVROLOtUL84BZMj5ZKSQqqjVmD2w==@lists.infradead.org X-Gm-Message-State: AOJu0Yxi8dT/pQgWfCKku6KdTnTixnsYF9tPAABQjyYH47sx8JMdABOu lrRV/GMMA4fGMsYrayArNMdnbK2loex4P9D2QJ2p6OrGeOAzViM0eRI4 X-Gm-Gg: AfdE7cnz1Bxr9Nciw/9k/N/kPPrpipmajwVHCq60h4GJOPAg0D86AlYaM0vBeSy1z0u BQPSQaZgbZlZpAsRdpg3atoUCct5i8IIneNpQzsaoKTXJBM9N2nDJccQBfAUKd0w0m9rDMYdkvf v/M1uyoITUCguzeO2WStVmRJLOFD6YhvLWSAgnRgNv1k0Y1THz3sIg3noNwzf4ZFo3XzwA/r9M9 oRn98XRPE047PzG8ZvrI8NvHmejiG+Wo52oFlubunXFGupdxTvh8cYcE6Dd9a4ZQshe6WgO4hcd rJR6wm2Kn/UfWdD2kYMAYcq2+uqU5/RNDKRgeLd8saaBdbiy9B9TDc2pS2jGTDUvbjK4IrkAStM YhfOAiIFAgnM17ipx1LD8HrlXXJ5WlJ0uWRrLK8xI8qx4SxztpShWvYPcIlGwwOEkUSJ97duiLg sjV2+d32EasQ4ipmWsjYlQ3ZxvJvAtZfTPjApCANWt1XxAmw== X-Received: by 2002:a05:600d:6405:10b0:493:eec0:2b8c with SMTP id 5b1f17b1804b1-493eec02c80mr19641245e9.12.1783614423204; Thu, 09 Jul 2026 09:27:03 -0700 (PDT) Received: from pumpkin (host-92-21-50-228.as13285.net. [92.21.50.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb670a41sm70023415e9.0.2026.07.09.09.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 09:27:02 -0700 (PDT) Date: Thu, 9 Jul 2026 17:26:59 +0100 From: David Laight To: Thomas Gleixner Cc: Michal =?UTF-8?B?U3VjaMOhbmVr?= , LKML , Peter Zijlstra , Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Kees Cook , Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sven Schnelle , linux-s390@vger.kernel.org, x86@kernel.org, Mark Rutland , Jinjie Ruan , Andy Lutomirski , Oleg Nesterov , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool Message-ID: <20260709172659.7040db33@pumpkin> In-Reply-To: <87ik6pqdkf.ffs@fw13> References: <20260707181957.433213175@kernel.org> <20260707190254.338083894@kernel.org> <87se5tqkyp.ffs@fw13> <87ik6pqdkf.ffs@fw13> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260709_092706_026529_CFED2A92 X-CRM114-Status: GOOD ( 30.99 ) X-BeenThere: linux-snps-arc@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+linux-snps-arc=archiver.kernel.org@lists.infradead.org T24gVGh1LCAwOSBKdWwgMjAyNiAwMToxNDoyNCArMDIwMApUaG9tYXMgR2xlaXhuZXIgPHRnbHhA a2VybmVsLm9yZz4gd3JvdGU6Cgo+IE9uIFdlZCwgSnVsIDA4IDIwMjYgYXQgMjI6MzQsIFRob21h cyBHbGVpeG5lciB3cm90ZToKPiA+IE9uIFdlZCwgSnVsIDA4IDIwMjYgYXQgMTc6NTIsIE1pY2hh bCBTdWNow6FuZWsgd3JvdGU6Cj4gPiBROiBJcyBpdCBwZXJmZWN0Pwo+ID4gQTogTm8KPiA+Cj4g PiBROiBDYW4gaXQgYmUgbWFkZSBwZXJmZWN0Pwo+ID4gQTogTm8sIGJlY2F1c2UgeW91IGNhbid0 IGNoYW5nZSBoaXN0b3J5IGFuZCBlc3RhYmxpc2hlZCBwcmFjdGljZS4KPiA+Cj4gPiBKdXN0IGZv ciBpbGx1c3RyYXRpb24uIENoYW5naW5nIHRoZSBsb2dpYyBpbiB0cmFjZV9zeXNjYWxsX2VudGVy KCkgdG86Cj4gPgo+ID4gLS0tIGEva2VybmVsL2VudHJ5L3N5c2NhbGwtY29tbW9uLmMKPiA+ICsr KyBiL2tlcm5lbC9lbnRyeS9zeXNjYWxsLWNvbW1vbi5jCj4gPiBAQCAtOSwxMyArOSwxNSBAQAo+ ID4gIAo+ID4gIGJvb2wgdHJhY2Vfc3lzY2FsbF9lbnRlcihzdHJ1Y3QgcHRfcmVncyAqcmVncywg bG9uZyAqc3lzY2FsbCkKPiA+ICB7Cj4gPiArCWxvbmcgb3JpZ19zeXNjYWxsID0gKnN5c2NhbGw7 Cj4gPiArCj4gPiAgCXRyYWNlX3N5c19lbnRlcihyZWdzLCAqc3lzY2FsbCk7Cj4gPiAgCS8qCj4g PiAgCSAqIFByb2JlcyBvciBCUEYgaG9va3MgaW4gdGhlIHRyYWNlcG9pbnQgbWF5IGhhdmUgY2hh bmdlZCB0aGUKPiA+ICAJICogc3lzdGVtIGNhbGwgbnVtYmVyLiBSZXJlYWQgaXQuCj4gPiAgCSAq Lwo+ID4gIAkqc3lzY2FsbCA9IHN5c2NhbGxfZ2V0X25yKGN1cnJlbnQsIHJlZ3MpOwo+ID4gLQly ZXR1cm4gKnN5c2NhbGwgIT0gLTFMOwo+ID4gKwlyZXR1cm4gKnN5c2NhbGwgPT0gb3JpZ19zeXNj YWxsIHx8ICpzeXNjYWxsICE9IC0xTDsKPiA+ICB9Cj4gPiAgCj4gPiAgdm9pZCB0cmFjZV9zeXNj YWxsX2V4aXQoc3RydWN0IHB0X3JlZ3MgKnJlZ3MsIGxvbmcgcmV0KQo+ID4KPiA+IGRvZXMgbm90 IG1ha2UgIzIgbWFnaWNhbGx5IGdvIGF3YXkuIEl0J3Mgc3RpbGwgdGhlIHNhbWUgcHJvYmxlbSB3 aGV0aGVyCj4gPiB5b3UgbGlrZSBpdCBvciBub3QuICAKPiAKPiBBbmQganVzdCB0byBiZSBlbnRp cmVseSBjbGVhciwgdGhlIHN5c2NhbGwoKSBpbnRlcmZhY2UgaGFzIHRvIGJlIGNvcnJlY3QKPiBp biB0aGUgZmlyc3QgcGxhY2UsIGJ1dCB0aGVuIGl0J3MgYWxsIGFib3V0IHBlcmZvcm1hbmNlLgo+ IAo+IFNvIHRoZSBzZXF1ZW5jZSBvZjoKPiAKPiAgICBwdF9yZWdzID0gUFVTSF9SRUdTKCk7Cj4g ICAgc3lzY2FsbCA9IHB0X3JlZ3MtPnN5c2NhbGxfcmVnOwo+ICAgIHB0X3JlZ3MtPnJlc3VsdCA9 IC1FTk9TWVM7Cj4gCj4gICAgYXJjaF9zeXNjYWxsKHB0X3JlZ3MsIHN5c2NhbGwpIHsKPiAgICAg ICBpZiAobGlrZWx5KHN5c2NhbGxfZW50ZXJfZnJvbV91c2VyX21vZGUocHRfcmVncywgJnN5c2Nh bGwpIHsKCkkgZ3Vlc3MgbW9zdCBhcmNoaXRlY3R1cmVzIGlubGluZSB0aGF0IHRvIGF2b2lkIHRo ZSAmc3lzY2FsbC4KT3RoZXJ3aXNlIHlvdSdkIHdhbnQ6CglzeXNjYWxsID0gc3lzY2FsbF9lbnRl cl9mcm9tX3VzZXJfbW9kZShwdF9yZWdzLCBzeXNjYWxsKTsKd2l0aCB0aGUgJ2Vycm9yJyByZXR1 cm4gYmVpbmcgc2VsZWN0ZWQgdG8gZmFpbCB0aGUgdGVzdCBiZWxvdwood2hpY2ggLTFMIGNvbnZl cnRlZCB0byB+MFVMIHdpbGwgZG8gbmljZWx5KS4KCglEYXZpZAoKPiAgICAgICAgICBpZiAoc3lz Y2FsbCA8IFNZU0NBTExfbWF4KQo+ICAgICAgICAgICAgIHB0X3JlZ3MtPnJlc3VsdCA9IGludm9r ZV9zeXNjYWxsKHB0X3JlZ3MsIHN5c2NhbGwpOwo+ICAgICAgIH0KPiAgICAgICAsLCwsCj4gICAg fQo+ICAgIHB0X3JlZ3MtPigkUkVUVVJOX1ZBTFVFKSA9IHB0X3JlZ3MtPnJlc3VsdDsKPiAgICBQ T1BfUkVHUygpOwo+ICAgIHJldHVybjsKPiAKPiBpcyB0aGUgY29ycmVjdCBhbmQgb2J2aXVvc2x5 IG1vc3QgZWZmaWNpZW50IHdheSBpZGVwZW5kZW50IG9mIHRoZSAtMUwKPiByZXR1cm4gdmFsdWUg b3ZlcmxvYWQgaW4gdGhlIG9yaWdpbmFsIGltcGxlbWVudGF0aW9uLCB3aGljaCB0aGlzIHNlcmll cwo+IGdldHMgcmlkIG9mIGZvciBjbGFyaXR5Lgo+IAo+IElmIGFuIGFyY2hpdGVjdHVyZSBkZWNp ZGVbc2RdIHRvIGRvIG90aGVyd2lzZSBhbmQgbWFrZXMgdXAgaXQncyBvd24gcnVsZXMKPiB3aGlj aCBvbmx5IGNvdmVyIHBhcnRzIG9mIHRoZSBwcm9ibGVtIHRoZW4gaXQgX2lzXyBhbiBhcmNoaXRl Y3R1cmUKPiBwcm9ibGVtIGFuZCBub3Qgc29tZXRoaW5nIHdoaWNoIGhhcyB0byBiZSBzb2x2ZWQg YnkgY2xhaW1pbmcgdGhhdCBldmVyeQo+IGFyY2hpdGVjdHVyZSBoYXMgdG8gaW1wbGVtZW50IHRo ZSBzYW1lIG5vbnNlbnNlIGFzIHlvdSBmYWxzZWx5IGNsYWltZWQKPiBpbiB5b3VyIFJGQ15XUE9D XldoYWNrIHRocmVhZDoKPiAKPiAgICJIb3dldmVyLCB0aGUgQVBJIHNob3VsZCBiZSBzcGVjaWZp ZWQgaW4gYSB3YXkgdGhhdCBkb2VzIG5vdCByZXF1aXJlCj4gICAgZXZlcnlvbmUgaW1wbGVtZW50 aW5nIHN1Y2ggZmxhZy4iCj4gCj4gVGhlcmUgaXMgX1pFUk9fIHJlcXVpcmVtZW50IGZvciBhbnkg YXJjaGl0ZWN0dXJlIHRvIGltcGxlbWVudCB0aGF0Cj4gZmxhZy4gSnVzdCBiZWNhdXNlIFMzOTAg ZGVjaWRlZCBpdCdzIGEgYnJpbGxpYW50IGlkZWEgdG8gZG8gc28gZG9lcyBub3QKPiBtYWtlIGl0 IGEgcmVxdWlyZW1lbnQgZm9yIGV2ZXJ5b25lLgo+IAo+IE5vLiBFdmVyeSBvdGhlciBhcmNoaXRl Y3R1cmUgZ290IGl0IHJpZ2h0IGJlY2F1c2UgdGhleSBsb29rZWQgYXQgdGhlCj4gaGlzdG9yaWNh bCBwYXR0ZXJucyBkZXNwaXRlIGhhdmluZyBjb3JyZWN0IGRvY3VtZW50YXRpb24gYXQgaGFuZC4K PiAKPiBGZWVsIGZyZWUgdG8gcHJvdmUgbWUgd3Jvbmcgd2l0aCBhY3R1YWwgZmFjdHMuCj4gCj4g VGhhbmtzLAo+IAo+ICAgICAgICAgdGdseAo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXNucHMtYXJjIG1haWxpbmcgbGlzdApsaW51eC1z bnBzLWFyY0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtc25wcy1hcmMK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28A2AC43458 for ; Thu, 9 Jul 2026 16:27:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HaqZAnzn9tmBA6QnfP2JzetQTY5+hvC2H+ym4E7o/Sg=; b=UcWg5MYRDOQYOl dRnnc45XA3EYr+RlFxDl2JmySBNQGF6h4WukTfR+WVt1FOJTctqAXp05N2enE8tjFtkWORmHHkc5i qgGt7p/YrVElboYzzkGg01GURQrFxUzF4uHh9Wj2P+xSuskrTEgQwPfQtzSyNn7qpHR3A7pXafnl+ reR2TBjAds9fVzMa+B2XiTyy94GLqh+CHQ3q2mUNRbRLmP1W6mVnj4KmEK1aD89XTwGPuUj7Kr/5U dE3CAVlyYxMdsMea/o3ur2AFy0i4kACgNdWCN72+ffjxe4Y7DkSV3yL1lwfBUiMiGC5CBkyJbcb3+ F8bVgTvS4oJcglsQA38A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whraf-000000032XA-3rWj; Thu, 09 Jul 2026 16:27:09 +0000 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whrab-000000032V5-41JQ for linux-riscv@lists.infradead.org; Thu, 09 Jul 2026 16:27:08 +0000 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-493b7612475so18619155e9.3 for ; Thu, 09 Jul 2026 09:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783614423; x=1784219223; darn=lists.infradead.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=GEOL8DOWD1Msvjz7k5cAG0xDAOqwGsu0BnpwMff10wU=; b=AeIAtOBk9ppvRbASqtFmqsdVQfMtDivwmws+YytjgA9HJz/wdmFbBoIiFKHFAqF+vS 99pkJb1Q12cuQPTmQpCS3kftHi6w6yQptvVO94YJ1Xbchm1r3e8fV1yrJAIwi8uqgcn5 S8+R8wRAkSFDUUCXGND0tK8bx0HP90yYDJ9DlCx8PLmYERl2HUxZNFbEGBUCgxQOzlu0 6xFEwrwplrEITF890qj2tDh1X6EMlUj8BzkErlYcZ/WYPai5ZdhD9J/z2aeoNXGmnIOV etef50DkFdmN1OcnzJBotB9zUUD6Z24f/csEkT//H4GwOSe9KZVstjpP2RlGtIV7rnYE yXdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783614423; x=1784219223; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=GEOL8DOWD1Msvjz7k5cAG0xDAOqwGsu0BnpwMff10wU=; b=fr67b0jP8KtGjuJ/Msyi1s+rR6Svlj/gZi6tjJgQ6acXNiJSAukOVbk7G40s2iPVj3 vvNS7KCi3xDADm5CFzFFShET0q5Q1r2zqo0BHQ2oKP0iGidi4qWz+VB3PcBJM6TtBBVy sM04f4ujGHhFUuz0CpOVtt/db2Iiffu8mrqjqrDzYtIXGHN6c9nTXah51ZrGRWaLz7AJ OERnrYnIynbskpO3Z76zaTPVCVlETAzt9lkJGmZBULsM4IZMK8HVMZfXsTcreUDwvvP3 lKuUC+LWaIl1ncWo4uaLKIpV3SlvLgH1bp4HWnQ+0n6cLIrz6n4x0rwreupE94FfEHlW dPlw== X-Forwarded-Encrypted: i=1; AHgh+RqBPG9655ccHqrCvXWJCp+YgvK3IqSiphWy39ElF4tvzgvF1uIC2JjRMMbUF/eR9A/KpxjFXblXs2BFug==@lists.infradead.org X-Gm-Message-State: AOJu0YwWWBS2dqsnrL70XkvKbHmpFg5Gwf42GbwVQM/vvoLBPDs/PINs JVBNI7piaAeP7q2VVX7lEtb6f/e/LYx5EYVN0xtH5cwLz30u1nilNPhD X-Gm-Gg: AfdE7ckHDGRlErofANDw4pm5vXV0AzRNM/Deu0jPIw9z6U4Y2Q0a5Aqh4RIwuJspPjn ytW5Z1EVpPDAm0zQc0HHuucBcjrZtVE+wnTmXqpBjZXAJZZsP5rvdjO73saAwmhDHrd5TOhhHm7 m5eVl8SerPjTK4bqITqJdGk3XBCGmu/oi4/t39Z738kQHWiCJT92zU4OzwLMze0pG3/l/pXEzqG OYxm3FmFlX1H6vHQcVn8Ve3Qk3TcD8mJAhKmFfVB/3F3fP1zqnNu/1VXM/eGa/c5KIL6milNn9z nAxuzrNRXPZdS/Uwv+cOUBRmSYfUjd5gXnb97a3oSsfIY/Do6CeWYojtbxU1LTNGA432zTIp+WV 6lWrEyl6QGkPoIvy9HbCc5cxbxV1i9OcOZTaIKrE5f7/z3Doc1v3EaFrpGkMue4p68jX5G2NNH2 NtbefZ/+iKUJZt1Gmwpo2dy2LQDJK7yygKbeIujJzs84PUrg== X-Received: by 2002:a05:600d:6405:10b0:493:eec0:2b8c with SMTP id 5b1f17b1804b1-493eec02c80mr19641245e9.12.1783614423204; Thu, 09 Jul 2026 09:27:03 -0700 (PDT) Received: from pumpkin (host-92-21-50-228.as13285.net. [92.21.50.228]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb670a41sm70023415e9.0.2026.07.09.09.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jul 2026 09:27:02 -0700 (PDT) Date: Thu, 9 Jul 2026 17:26:59 +0100 From: David Laight To: Thomas Gleixner Cc: Michal =?UTF-8?B?U3VjaMOhbmVr?= , LKML , Peter Zijlstra , Michael Ellerman , Shrikanth Hegde , linuxppc-dev@lists.ozlabs.org, Kees Cook , Huacai Chen , loongarch@lists.linux.dev, Paul Walmsley , Palmer Dabbelt , linux-riscv@lists.infradead.org, Sven Schnelle , linux-s390@vger.kernel.org, x86@kernel.org, Mark Rutland , Jinjie Ruan , Andy Lutomirski , Oleg Nesterov , Richard Henderson , Russell King , Catalin Marinas , Guo Ren , Geert Uytterhoeven , Thomas Bogendoerfer , Helge Deller , Yoshinori Sato , Richard Weinberger , Chris Zankel , linux-arm-kernel@lists.infradead.org, linux-alpha@vger.kernel.org, linux-csky@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org, linux-um@lists.infradead.org, Arnd Bergmann , Vineet Gupta , Will Deacon , Brian Cain , Michal Simek , Dinh Nguyen , "David S. Miller" , Andreas Larsson , linux-snps-arc@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-openrisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, Jonathan Corbet , linux-doc@vger.kernel.org Subject: Re: [patch 13/18] entry: Make trace_syscall_enter() return type bool Message-ID: <20260709172659.7040db33@pumpkin> In-Reply-To: <87ik6pqdkf.ffs@fw13> References: <20260707181957.433213175@kernel.org> <20260707190254.338083894@kernel.org> <87se5tqkyp.ffs@fw13> <87ik6pqdkf.ffs@fw13> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260709_092706_027775_35AB8DCE X-CRM114-Status: GOOD ( 30.99 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gVGh1LCAwOSBKdWwgMjAyNiAwMToxNDoyNCArMDIwMApUaG9tYXMgR2xlaXhuZXIgPHRnbHhA a2VybmVsLm9yZz4gd3JvdGU6Cgo+IE9uIFdlZCwgSnVsIDA4IDIwMjYgYXQgMjI6MzQsIFRob21h cyBHbGVpeG5lciB3cm90ZToKPiA+IE9uIFdlZCwgSnVsIDA4IDIwMjYgYXQgMTc6NTIsIE1pY2hh bCBTdWNow6FuZWsgd3JvdGU6Cj4gPiBROiBJcyBpdCBwZXJmZWN0Pwo+ID4gQTogTm8KPiA+Cj4g PiBROiBDYW4gaXQgYmUgbWFkZSBwZXJmZWN0Pwo+ID4gQTogTm8sIGJlY2F1c2UgeW91IGNhbid0 IGNoYW5nZSBoaXN0b3J5IGFuZCBlc3RhYmxpc2hlZCBwcmFjdGljZS4KPiA+Cj4gPiBKdXN0IGZv ciBpbGx1c3RyYXRpb24uIENoYW5naW5nIHRoZSBsb2dpYyBpbiB0cmFjZV9zeXNjYWxsX2VudGVy KCkgdG86Cj4gPgo+ID4gLS0tIGEva2VybmVsL2VudHJ5L3N5c2NhbGwtY29tbW9uLmMKPiA+ICsr KyBiL2tlcm5lbC9lbnRyeS9zeXNjYWxsLWNvbW1vbi5jCj4gPiBAQCAtOSwxMyArOSwxNSBAQAo+ ID4gIAo+ID4gIGJvb2wgdHJhY2Vfc3lzY2FsbF9lbnRlcihzdHJ1Y3QgcHRfcmVncyAqcmVncywg bG9uZyAqc3lzY2FsbCkKPiA+ICB7Cj4gPiArCWxvbmcgb3JpZ19zeXNjYWxsID0gKnN5c2NhbGw7 Cj4gPiArCj4gPiAgCXRyYWNlX3N5c19lbnRlcihyZWdzLCAqc3lzY2FsbCk7Cj4gPiAgCS8qCj4g PiAgCSAqIFByb2JlcyBvciBCUEYgaG9va3MgaW4gdGhlIHRyYWNlcG9pbnQgbWF5IGhhdmUgY2hh bmdlZCB0aGUKPiA+ICAJICogc3lzdGVtIGNhbGwgbnVtYmVyLiBSZXJlYWQgaXQuCj4gPiAgCSAq Lwo+ID4gIAkqc3lzY2FsbCA9IHN5c2NhbGxfZ2V0X25yKGN1cnJlbnQsIHJlZ3MpOwo+ID4gLQly ZXR1cm4gKnN5c2NhbGwgIT0gLTFMOwo+ID4gKwlyZXR1cm4gKnN5c2NhbGwgPT0gb3JpZ19zeXNj YWxsIHx8ICpzeXNjYWxsICE9IC0xTDsKPiA+ICB9Cj4gPiAgCj4gPiAgdm9pZCB0cmFjZV9zeXNj YWxsX2V4aXQoc3RydWN0IHB0X3JlZ3MgKnJlZ3MsIGxvbmcgcmV0KQo+ID4KPiA+IGRvZXMgbm90 IG1ha2UgIzIgbWFnaWNhbGx5IGdvIGF3YXkuIEl0J3Mgc3RpbGwgdGhlIHNhbWUgcHJvYmxlbSB3 aGV0aGVyCj4gPiB5b3UgbGlrZSBpdCBvciBub3QuICAKPiAKPiBBbmQganVzdCB0byBiZSBlbnRp cmVseSBjbGVhciwgdGhlIHN5c2NhbGwoKSBpbnRlcmZhY2UgaGFzIHRvIGJlIGNvcnJlY3QKPiBp biB0aGUgZmlyc3QgcGxhY2UsIGJ1dCB0aGVuIGl0J3MgYWxsIGFib3V0IHBlcmZvcm1hbmNlLgo+ IAo+IFNvIHRoZSBzZXF1ZW5jZSBvZjoKPiAKPiAgICBwdF9yZWdzID0gUFVTSF9SRUdTKCk7Cj4g ICAgc3lzY2FsbCA9IHB0X3JlZ3MtPnN5c2NhbGxfcmVnOwo+ICAgIHB0X3JlZ3MtPnJlc3VsdCA9 IC1FTk9TWVM7Cj4gCj4gICAgYXJjaF9zeXNjYWxsKHB0X3JlZ3MsIHN5c2NhbGwpIHsKPiAgICAg ICBpZiAobGlrZWx5KHN5c2NhbGxfZW50ZXJfZnJvbV91c2VyX21vZGUocHRfcmVncywgJnN5c2Nh bGwpIHsKCkkgZ3Vlc3MgbW9zdCBhcmNoaXRlY3R1cmVzIGlubGluZSB0aGF0IHRvIGF2b2lkIHRo ZSAmc3lzY2FsbC4KT3RoZXJ3aXNlIHlvdSdkIHdhbnQ6CglzeXNjYWxsID0gc3lzY2FsbF9lbnRl cl9mcm9tX3VzZXJfbW9kZShwdF9yZWdzLCBzeXNjYWxsKTsKd2l0aCB0aGUgJ2Vycm9yJyByZXR1 cm4gYmVpbmcgc2VsZWN0ZWQgdG8gZmFpbCB0aGUgdGVzdCBiZWxvdwood2hpY2ggLTFMIGNvbnZl cnRlZCB0byB+MFVMIHdpbGwgZG8gbmljZWx5KS4KCglEYXZpZAoKPiAgICAgICAgICBpZiAoc3lz Y2FsbCA8IFNZU0NBTExfbWF4KQo+ICAgICAgICAgICAgIHB0X3JlZ3MtPnJlc3VsdCA9IGludm9r ZV9zeXNjYWxsKHB0X3JlZ3MsIHN5c2NhbGwpOwo+ICAgICAgIH0KPiAgICAgICAsLCwsCj4gICAg fQo+ICAgIHB0X3JlZ3MtPigkUkVUVVJOX1ZBTFVFKSA9IHB0X3JlZ3MtPnJlc3VsdDsKPiAgICBQ T1BfUkVHUygpOwo+ICAgIHJldHVybjsKPiAKPiBpcyB0aGUgY29ycmVjdCBhbmQgb2J2aXVvc2x5 IG1vc3QgZWZmaWNpZW50IHdheSBpZGVwZW5kZW50IG9mIHRoZSAtMUwKPiByZXR1cm4gdmFsdWUg b3ZlcmxvYWQgaW4gdGhlIG9yaWdpbmFsIGltcGxlbWVudGF0aW9uLCB3aGljaCB0aGlzIHNlcmll cwo+IGdldHMgcmlkIG9mIGZvciBjbGFyaXR5Lgo+IAo+IElmIGFuIGFyY2hpdGVjdHVyZSBkZWNp ZGVbc2RdIHRvIGRvIG90aGVyd2lzZSBhbmQgbWFrZXMgdXAgaXQncyBvd24gcnVsZXMKPiB3aGlj aCBvbmx5IGNvdmVyIHBhcnRzIG9mIHRoZSBwcm9ibGVtIHRoZW4gaXQgX2lzXyBhbiBhcmNoaXRl Y3R1cmUKPiBwcm9ibGVtIGFuZCBub3Qgc29tZXRoaW5nIHdoaWNoIGhhcyB0byBiZSBzb2x2ZWQg YnkgY2xhaW1pbmcgdGhhdCBldmVyeQo+IGFyY2hpdGVjdHVyZSBoYXMgdG8gaW1wbGVtZW50IHRo ZSBzYW1lIG5vbnNlbnNlIGFzIHlvdSBmYWxzZWx5IGNsYWltZWQKPiBpbiB5b3VyIFJGQ15XUE9D XldoYWNrIHRocmVhZDoKPiAKPiAgICJIb3dldmVyLCB0aGUgQVBJIHNob3VsZCBiZSBzcGVjaWZp ZWQgaW4gYSB3YXkgdGhhdCBkb2VzIG5vdCByZXF1aXJlCj4gICAgZXZlcnlvbmUgaW1wbGVtZW50 aW5nIHN1Y2ggZmxhZy4iCj4gCj4gVGhlcmUgaXMgX1pFUk9fIHJlcXVpcmVtZW50IGZvciBhbnkg YXJjaGl0ZWN0dXJlIHRvIGltcGxlbWVudCB0aGF0Cj4gZmxhZy4gSnVzdCBiZWNhdXNlIFMzOTAg ZGVjaWRlZCBpdCdzIGEgYnJpbGxpYW50IGlkZWEgdG8gZG8gc28gZG9lcyBub3QKPiBtYWtlIGl0 IGEgcmVxdWlyZW1lbnQgZm9yIGV2ZXJ5b25lLgo+IAo+IE5vLiBFdmVyeSBvdGhlciBhcmNoaXRl Y3R1cmUgZ290IGl0IHJpZ2h0IGJlY2F1c2UgdGhleSBsb29rZWQgYXQgdGhlCj4gaGlzdG9yaWNh bCBwYXR0ZXJucyBkZXNwaXRlIGhhdmluZyBjb3JyZWN0IGRvY3VtZW50YXRpb24gYXQgaGFuZC4K PiAKPiBGZWVsIGZyZWUgdG8gcHJvdmUgbWUgd3Jvbmcgd2l0aCBhY3R1YWwgZmFjdHMuCj4gCj4g VGhhbmtzLAo+IAo+ICAgICAgICAgdGdseAo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmxpbnV4LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNj dkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtcmlzY3YK