From: Nikolay Kulikov <nikolayof23@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-staging@lists.linux.dev, Nikolay Kulikov <nikolayof23@gmail.com>
Subject: [PATCH 2/9] staging: rtl8723bs: remove unused 'PolarityCtl' from struct hal_com_data
Date: Thu, 9 Jul 2026 21:15:09 +0300 [thread overview]
Message-ID: <20260709182627.16327-3-nikolayof23@gmail.com> (raw)
In-Reply-To: <20260709182627.16327-1-nikolayof23@gmail.com>
This field is determined by the value of a bit from the hardware, but
the variable is not used after assignment.
Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 1 -
drivers/staging/rtl8723bs/include/hal_com_reg.h | 1 -
drivers/staging/rtl8723bs/include/hal_data.h | 8 --------
3 files changed, 10 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
index 58c9b5de4ae2..b7478f5f38f1 100644
--- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
+++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
@@ -838,7 +838,6 @@ static void ReadChipVersion8723B(struct adapter *padapter)
pHalData->MultiFunc |= ((value32 & WL_FUNC_EN) ? RT_MULTI_FUNC_WIFI : 0);
pHalData->MultiFunc |= ((value32 & BT_FUNC_EN) ? RT_MULTI_FUNC_BT : 0);
pHalData->MultiFunc |= ((value32 & GPS_FUNC_EN) ? RT_MULTI_FUNC_GPS : 0);
- pHalData->PolarityCtl = ((value32 & WL_HWPDN_SL) ? RT_POLARITY_HIGH_ACT : RT_POLARITY_LOW_ACT);
}
void rtl8723b_read_chip_version(struct adapter *padapter)
diff --git a/drivers/staging/rtl8723bs/include/hal_com_reg.h b/drivers/staging/rtl8723bs/include/hal_com_reg.h
index 06cbc3f92baf..6aa95a10a0f4 100644
--- a/drivers/staging/rtl8723bs/include/hal_com_reg.h
+++ b/drivers/staging/rtl8723bs/include/hal_com_reg.h
@@ -590,7 +590,6 @@
#define C2H_EVT_FW_CLOSE 0xFF /* Set by FW indicating that FW had set the C2H command message and it's not yet read by driver. */
/* 2REG_MULTI_FUNC_CTRL(For RTL8723 Only) */
-#define WL_HWPDN_SL BIT(1) /* WiFi HW PDn polarity control */
#define WL_FUNC_EN BIT(2) /* WiFi function enable */
#define BT_FUNC_EN BIT(18) /* BT function enable */
#define GPS_FUNC_EN BIT(22) /* GPS function enable */
diff --git a/drivers/staging/rtl8723bs/include/hal_data.h b/drivers/staging/rtl8723bs/include/hal_data.h
index 2c630c6b5f97..ebbbc8e03d6a 100644
--- a/drivers/staging/rtl8723bs/include/hal_data.h
+++ b/drivers/staging/rtl8723bs/include/hal_data.h
@@ -21,13 +21,6 @@ enum rt_multi_func {
RT_MULTI_FUNC_BT = 0x02,
RT_MULTI_FUNC_GPS = 0x04,
};
-/* */
-/* <Roger_Notes> For RTL8723 WiFi PDn/GPIO polarity control configuration. 2010.10.08. */
-/* */
-enum rt_polarity_ctl {
- RT_POLARITY_LOW_ACT = 0,
- RT_POLARITY_HIGH_ACT = 1,
-};
/* For RTL8723 regulator mode. by tynli. 2011.01.14. */
enum rt_regulator_mode {
@@ -163,7 +156,6 @@ struct dm_priv {
struct hal_com_data {
enum rt_multi_func MultiFunc; /* For multi-function consideration. */
- enum rt_polarity_ctl PolarityCtl; /* For Wifi PDn Polarity control. */
enum rt_regulator_mode RegulatorMode; /* switching regulator or LDO */
u16 FirmwareVersion;
--
2.54.0
next prev parent reply other threads:[~2026-07-09 18:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-09 18:15 [PATCH 0/9] staging: rtl8723bs: remove some fields from the Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 1/9] staging: rtl8723bs: remove dead fields from struct hal_com_data Nikolay Kulikov
2026-07-09 18:15 ` Nikolay Kulikov [this message]
2026-07-09 18:15 ` [PATCH 3/9] staging: rtl8723bs: remove unused RegulatorMode " Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 4/9] staging: rtl8723bs: remove unused 'MultiFunc' " Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 5/9] staging: rtl8723bs: remove unused 'EEPROMCustomerID' from hal_com_data Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 6/9] staging: rtl8723bs: remove unused ForcedDataRate " Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 7/9] staging: rtl8723bs: remove unused EEPROMVersion from struct hal_com_data Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 8/9] staging: rtl8723bs: remove unused EEPROMBluetoothType from hal_com_data Nikolay Kulikov
2026-07-09 18:15 ` [PATCH 9/9] staging: rtl8723bs: remove unused 'bTXPowerDataReadFromEEPORM' Nikolay Kulikov
2026-07-10 14:50 ` [PATCH 0/9] staging: rtl8723bs: remove some fields from the Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260709182627.16327-3-nikolayof23@gmail.com \
--to=nikolayof23@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.