All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Robin Murphy" <robin.murphy@arm.com>
Cc: conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org,
	linux-perf-users@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: perf: Add Arm Bus Monitor Unit
Date: Thu, 09 Jul 2026 19:26:56 +0000	[thread overview]
Message-ID: <20260709192656.C41AF1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <1cd17d9c07e9695e1dffdeaa5409f0a1db8ccb81.1783439341.git.robin.murphy@arm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The YAML device tree binding schema is missing the mandatory `examples` section.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: perf: Add Arm Bus Monitor Unit ---
commit d43448a74f2d7de7e06899d55b1561b64c21375c
Author: Robin Murphy <robin.murphy@arm.com>

dt-bindings: perf: Add Arm Bus Monitor Unit

This commit adds a new device tree binding schema for the Arm Bus Monitor
Unit. It defines the required properties, including a mandatory label to allow
end users to correlate instances with platform documentation.

> diff --git a/Documentation/devicetree/bindings/perf/arm,bus-monitor-unit.yaml b/Documentation/devicetree/bindings/perf/arm,bus-monitor-unit.yaml
> new file mode 100644
> index 0000000000000..3cdc3a05b9a63
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/perf/arm,bus-monitor-unit.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg
> +  - label
> +
> +additionalProperties: false

[Severity: Low]
Does this binding schema omit the mandatory examples section? Standard device
tree bindings typically require an examples block at the end of the file to
provide a reference node implementation and allow full validation by the
dt_binding_check tool.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1783439341.git.robin.murphy@arm.com?part=1

  reply	other threads:[~2026-07-09 19:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09 19:22 [PATCH 0/2] perf: Support Arm Bus Monitor Unit Robin Murphy
2026-07-09 19:22 ` [PATCH 1/2] dt-bindings: perf: Add " Robin Murphy
2026-07-09 19:26   ` sashiko-bot [this message]
2026-07-13  7:26   ` Krzysztof Kozlowski
2026-07-13 12:59     ` Robin Murphy
2026-07-09 19:22 ` [PATCH 2/2] perf: Add Arm Bus Monitor Unit driver Robin Murphy
2026-07-09 19:36   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260709192656.C41AF1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.