From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A488C43458 for ; Thu, 9 Jul 2026 19:27:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rrIE+LTt433X+ywAIC4/I/480NZstiTToOPXqndI2Hc=; b=ADveYBm/x+f7UJ U66IY+zbNRtEw7wefAOqxG8JlD7iDmbZ1n9dJ+43Y/Tv4HFQ8VPsQUXzx6Tzs68xHvuaSPFthZW6i 9ypyd78bV4vmCNtGlgBNUTqHjv1H4a1yj5CpgJjELP1ZphKdJAvSLreCRyuHE0gt14k296CTcSFoz L4tUSNL/LJW/o+kXB4vVPbF95KifBtDvz/n46rSE7u5H0uXI9dhOj1PXsK76JBwB/ncGWpbC4AJZU xhCEQNx7DMaDBOLjtPw0ezKracr2wltLdM6y/VovvtZT5NCR/Mz3Ig35pXTy2QBESq2Q6a0bV/UVR ppUxHDSSoSgPZSMvipzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whuPS-00000003St4-1NwU; Thu, 09 Jul 2026 19:27:46 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whuPQ-00000003Ssy-29IV for linux-phy@lists.infradead.org; Thu, 09 Jul 2026 19:27:44 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id F053D6137D; Thu, 9 Jul 2026 19:27:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 431BA1F000E9; Thu, 9 Jul 2026 19:27:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783625263; bh=ojimdSKL7yFLNVHqovzToUoR66kYEIlZT9Kj2ekQW4w=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VnhH1L+orH83KASf4caE5eJ+sZ/++TaX2uSseXXU8iPUrbIpl0JmD9SLX/3LOKHq8 aRH7e6SZqWJNRP8BvyIAbLvZBsofJroFqBXY51I8kpoyB8bhCs7qMEWsOqDwCOdorZ 6zqxJGNeTfXePzQODNV5jIzkdmum6wINiHagmUMIp+iKSJKMNQZKv1lbHFIGX422uW LYzG1miYIUBPQI+CRVR1aWr1KtczPzC1laLRx+xI0s6m8uB/kIJOOTvwX5XvfG6kwJ rRmjgJ3aVado8Ve2kajLffvVXCKYjgW8in/l0odxcDC9G9qB2x1kJ/RD/a1Q7Mariu rrmWk6dE20KVA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 21/36] phy: rockchip: usbdp: Properly handle TYPEC_STATE_SAFE and TYPEC_STATE_USB To: "Sebastian Reichel" Cc: vkoul@kernel.org, olteanv@gmail.com, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, robh@kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org In-Reply-To: <20260709-rockchip-usbdp-cleanup-v11-21-a149ac60f76c@collabora.com> References: <20260709-rockchip-usbdp-cleanup-v11-0-a149ac60f76c@collabora.com> <20260709-rockchip-usbdp-cleanup-v11-21-a149ac60f76c@collabora.com> Date: Thu, 09 Jul 2026 19:27:42 +0000 Message-Id: <20260709192743.431BA1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBFeGl0aW5nIERQIEFsdE1vZGUgZmFpbHMgdG8gcGh5c2ljYWxseSByZXN0b3JlIFVT QiBsYW5lIG11eGluZyBpZiB0aGUgVVNCIGNvbnRyb2xsZXIgcmVtYWlucyBsb2dpY2FsbHkgYWN0 aXZlLgotIFtIaWdoXSBgcmtfdWRwaHlfdXNiM19waHlfZXhpdGAgbGVha3MgdGhlIFVTQiBQSFkg cG93ZXIgc3RhdGUgaWYgdGhlIFR5cGUtQyBtdXggbW9kZSB3YXMgY2hhbmdlZCB0byBEUC1vbmx5 IGJlZm9yZSB0aGUgVVNCIGNvbnRyb2xsZXIgY2FsbHMgYHBoeV9leGl0YC4KLS0KCi0tLSBQYXRj aCBbMjFdOiBbUEFUQ0ggdjExIDIxLzM2XSBwaHk6IHJvY2tjaGlwOiB1c2JkcDogUHJvcGVybHkg aGFuZGxlIFRZUEVDX1NUQVRFX1NBRkUgYW5kIFRZUEVDX1NUQVRFX1VTQiAtLS0KY29tbWl0IDg2 NjNhNWU3NDU5NTUyNzA3YjNlZjgyMTkwODg1ZDVmNWIwMmFhNmIKQXV0aG9yOiBTZWJhc3RpYW4g UmVpY2hlbCA8c2ViYXN0aWFuLnJlaWNoZWxAY29sbGFib3JhLmNvbT4KCnBoeTogcm9ja2NoaXA6 IHVzYmRwOiBQcm9wZXJseSBoYW5kbGUgVFlQRUNfU1RBVEVfU0FGRSBhbmQgVFlQRUNfU1RBVEVf VVNCCgpUaGlzIGNvbW1pdCBhZGRzIHN1cHBvcnQgZm9yIFRZUEVDX1NUQVRFX1NBRkUgYW5kIFRZ UEVDX1NUQVRFX1VTQiBUeXBlLUMKc3RhdGUgZXZlbnRzIHRvIGVuc3VyZSBtdXhpbmcgaXMgcHJv cGVybHkgdXBkYXRlZCB3aGVuIGV4aXRpbmcgRFAgQWx0TW9kZS4KSXQgZml4ZXMgYW4gaXNzdWUg aW4gdGhlIHJvY2tjaGlwIHVzYmRwIGNvbWJvIHBoeSBkcml2ZXIuCgpGaXhlczogMmY3MGJiZGRl YjQ1ICgicGh5OiByb2NrY2hpcDogYWRkIHVzYmRwIGNvbWJvIHBoeSBkcml2ZXIiKQpSZXBvcnRl ZC1ieTogU2FzaGlrbyA8c2FzaGlrby1ib3RAa2VybmVsLm9yZz4KQ2xvc2VzOiBodHRwczovL3Nh c2hpa28uZGV2LyMvbWVzc2FnZS8yMDI2MDYxOTE1NTAyMC5DQzczNjFGMDAwRTklNDBzbXRwLmtl cm5lbC5vcmcKCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hp cC11c2JkcC5jIGIvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLXVzYmRwLmMKPiBp bmRleCA0ZTU0MDIwZDE3NTUxLi4wMzk5Y2JmOTZlMTk1IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv cGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC11c2JkcC5jCj4gKysrIGIvZHJpdmVycy9waHkvcm9j a2NoaXAvcGh5LXJvY2tjaGlwLXVzYmRwLmMKPiBAQCAtMTI5MywxNyArMTI5MywyNiBAQCBzdGF0 aWMgY29uc3Qgc3RydWN0IHBoeV9vcHMgcmtfdWRwaHlfdXNiM19waHlfb3BzID0gewo+ICAJLm93 bmVyCQk9IFRISVNfTU9EVUxFLAo+ICB9OwoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlzIGEgcHJl LWV4aXN0aW5nIGlzc3VlLCBidXQgSSBhbSB3b25kZXJpbmcgaWYgcmtfdWRwaHlfdXNiM19waHlf ZXhpdCgpCmxlYWtzIHRoZSBVU0IgUEhZIHBvd2VyIHN0YXRlIHdoZW4gdGhlIFR5cGUtQyBtdXgg bW9kZSBpcyBjaGFuZ2VkIHRvIERQLW9ubHkKYmVmb3JlIHRoZSBVU0IgY29udHJvbGxlciBjYWxs cyBwaHlfZXhpdCgpPwoKSWYgdGhlIFR5cGUtQyBtdXggc3dpdGNoZXMgdG8gNC1sYW5lIERQIEFs dE1vZGUsIHVkcGh5LT5tb2RlIGJlY29tZXMKVURQSFlfTU9ERV9EUC4gSWYgdGhlIFVTQiBjb250 cm9sbGVyIHRoZW4gc3VzcGVuZHMgb3IgaXMgdW5ib3VuZCwgaXQgY2FsbHMKcmtfdWRwaHlfdXNi M19waHlfZXhpdCgpLCB3aGljaCByZXR1cm5zIGVhcmx5OgoKZHJpdmVycy9waHkvcm9ja2NoaXAv cGh5LXJvY2tjaGlwLXVzYmRwLmM6cmtfdWRwaHlfdXNiM19waHlfZXhpdCgpIHsKICAgIC4uLgog ICAgLyogRFAgb25seSBvciBoaWdoLXNwZWVkICovCiAgICBpZiAoISh1ZHBoeS0+bW9kZSAmIFVE UEhZX01PREVfVVNCKSB8fCB1ZHBoeS0+aHMpCiAgICAgICAgZ290byB1bmxvY2s7CgogICAgcmtf dWRwaHlfcG93ZXJfb2ZmKHVkcGh5LCBVRFBIWV9NT0RFX1VTQik7CiAgICAuLi4KfQoKVGhpcyBz a2lwcyBya191ZHBoeV9wb3dlcl9vZmYoKSwgbGVhdmluZyBVRFBIWV9NT0RFX1VTQiBzZXQgaW4g dWRwaHktPnN0YXR1cy4KU2luY2Ugc3RhdHVzIG5ldmVyIHJlYWNoZXMgVURQSFlfTU9ERV9OT05F IHdoZW4gRFAgbGF0ZXIgcG93ZXJzIG9mZiwKcmtfdWRwaHlfZGlzYWJsZSgpIGlzIG5ldmVyIGNh bGxlZC4gV2lsbCB0aGUgUEhZIGNsb2NrcyBhbmQgcmVzZXRzIHJlbWFpbgpwZXJtYW5lbnRseSBh Y3RpdmUgd2hlbiB0aGV5IHNob3VsZCBiZSBzdXNwZW5kZWQ/Cgo+ICAKPiArc3RhdGljIGJvb2wg cmtfdWRwaHlfaXNfc3VwcG9ydGVkX21vZGUoc3RydWN0IHR5cGVjX211eF9zdGF0ZSAqc3RhdGUp Cj4gK3sKPiArCS8qIEhhbmRsZSBTYWZlIFN0YXRlIGFuZCBVU0IgU3RhdGUgKi8KPiArCWlmIChz dGF0ZS0+bW9kZSA8IFRZUEVDX1NUQVRFX01PREFMKQo+ICsJCXJldHVybiB0cnVlOwo+ICsKPiAr CS8qIEhhbmRsZSBEUCBBbHRNb2RlICovCj4gKwlpZiAoc3RhdGUtPmFsdCAmJiBzdGF0ZS0+YWx0 LT5zdmlkID09IFVTQl9UWVBFQ19EUF9TSUQpCj4gKwkJcmV0dXJuIHRydWU7Cj4gKwo+ICsJcmV0 dXJuIGZhbHNlOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IHJrX3VkcGh5X3R5cGVjX211eF9zZXQo c3RydWN0IHR5cGVjX211eF9kZXYgKm11eCwKPiAgCQkJCSAgc3RydWN0IHR5cGVjX211eF9zdGF0 ZSAqc3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBya191ZHBoeSAqdWRwaHkgPSB0eXBlY19tdXhfZ2V0 X2RydmRhdGEobXV4KTsKPiAgCj4gLQkvKgo+IC0JICogSWdub3JlIG11eCBldmVudHMgbm90IGlu dm9sdmluZyBEUCBBbHRNb2RlLCBiZWNhdXNlCj4gLQkgKiB0aGUgbW9kZSBmaWVsZCBpcyBiZWlu ZyByZXVzZWQsIGUuZy4gc3RhdGUtPm1vZGUgPT0gNAo+IC0JICogY291bGQgYmUgZWl0aGVyIFRZ UEVDX01PREVfVVNCNCBvciBUWVBFQ19EUF9TVEFURV9DLgo+IC0JICovCj4gLQlpZiAoIXN0YXRl LT5hbHQgfHwgc3RhdGUtPmFsdC0+c3ZpZCAhPSBVU0JfVFlQRUNfRFBfU0lEKQo+ICsJLyogSWdu b3JlIG11eCBldmVudHMgbm90IGludm9sdmluZyBVU0Igb3IgRFAgKi8KPiArCWlmICghcmtfdWRw aHlfaXNfc3VwcG9ydGVkX21vZGUoc3RhdGUpKQo+ICAJCXJldHVybiAwOwo+ICAKPiAgCW11dGV4 X2xvY2soJnVkcGh5LT5tdXRleCk7CgpbU2V2ZXJpdHk6IEhpZ2hdClRoaXMgaXMgYSBwcmUtZXhp c3RpbmcgaXNzdWUsIGJ1dCBjYW4gdGhlIFBIWSBnZXQgcGVybWFuZW50bHkgc3R1Y2sgaW4gNC1s YW5lCkRQIG1vZGUgd2hlbiBleGl0aW5nIERQIEFsdE1vZGUgaWYgdGhlIFVTQiBjb250cm9sbGVy IHJlbWFpbnMgbG9naWNhbGx5IGFjdGl2ZT8KCldoZW4gcmtfdWRwaHlfdHlwZWNfbXV4X3NldCgp IGhhbmRsZXMgdGhlIHRyYW5zaXRpb24gdG8gVFlQRUNfU1RBVEVfU0FGRQpvciBUWVBFQ19TVEFU RV9VU0IsIGl0IHVwZGF0ZXMgdGhlIHNvZnR3YXJlIG1vZGUgYW5kIHNldHMgcGh5X25lZWRzX3Jl aW5pdAp0byB0cnVlIHZpYSBya191ZHBoeV9zZXRfdHlwZWNfc3RhdGUoKSBsYXRlciBpbiB0aGlz IGZ1bmN0aW9uOgoKZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLXVzYmRwLmM6cmtf dWRwaHlfdHlwZWNfbXV4X3NldCgpIHsKICAgIC4uLgogICAgcmtfdWRwaHlfc2V0X3R5cGVjX3N0 YXRlKHVkcGh5LCBzdGF0ZS0+bW9kZSk7CiAgICAuLi4KfQoKSG93ZXZlciwgdGhlIGhhcmR3YXJl IG11eGluZyBpcyBvbmx5IHVwZGF0ZWQgaW4gcmtfdWRwaHlfcG93ZXJfb24oKToKCmRyaXZlcnMv cGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC11c2JkcC5jOnJrX3VkcGh5X3Bvd2VyX29uKCkgewog ICAgLi4uCiAgICB9IGVsc2UgaWYgKHVkcGh5LT5waHlfbmVlZHNfcmVpbml0KSB7CiAgICAgICAg aWYgKHVkcGh5LT5tb2RlID09IFVEUEhZX01PREVfRFApCiAgICAgICAgICAgIHJrX3VkcGh5X3Uz X3BvcnRfZGlzYWJsZSh1ZHBoeSwgdHJ1ZSk7CgogICAgICAgIHJldCA9IHJrX3VkcGh5X2luaXQo dWRwaHkpOwogICAgLi4uCn0KCklmIHRoZSBVU0IgY29udHJvbGxlciAoZS5nLiBkd2MzKSBpcyBh bHJlYWR5IGFjdGl2ZSwgaXQgd2lsbCBub3QgY2FsbApwaHlfcG93ZXJfb24oKSBhZ2Fpbi4gVGhp cyBjYXVzZXMgdGhlIGhhcmR3YXJlIHJlLWluaXRpYWxpemF0aW9uIHRvIGJlIG1pc3NlZCwKbGVh dmluZyB0aGUgUEhZIHBoeXNpY2FsbHkgaW4gNC1sYW5lIERQIG1vZGUuIElzIGl0IHBvc3NpYmxl IGZvciBVU0IgMy54CnRvIGJlY29tZSBjb21wbGV0ZWx5IHVucmVzcG9uc2l2ZSBpbiB0aGlzIHN0 YXRlLCBldmVuIHRob3VnaCB0aGUgVHlwZS1DCnN1YnN5c3RlbSBjb3JyZWN0bHkgcmV0dXJuZWQg dG8gVVNCIG1vZGU/CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRl di8jL3BhdGNoc2V0LzIwMjYwNzA5LXJvY2tjaGlwLXVzYmRwLWNsZWFudXAtdjExLTAtYTE0OWFj NjBmNzZjQGNvbGxhYm9yYS5jb20/cGFydD0yMQoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QK bGludXgtcGh5QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1556C3B42D6 for ; Thu, 9 Jul 2026 19:27:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783625265; cv=none; b=lpDG/L0vlc8+zNcr2BiBa1uQ2NlmTKKMlyLPfz3HFXPK5qJmwPkQlNyMIyKrrlQ7F+RFz+N0p58Wqdw9DMI37eUPAK21y5H9JHeBXd4YKXrkG/Tz4sXBIFGwkw9P5bBb9e/IBXusBFLOC7TNmYYdAbdh7hqNonx1KwiR92jIHok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783625265; c=relaxed/simple; bh=NOihqgHUC/MQKpm7AxH3D1OWfH3No/TLqLAdWucjJxs=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=iEEJ6gsVs32Re2kdrQ/Go42JUydlihykUYmDu6t+UEXiCalSIzlq1kd2ERstw/6r+PgksuYNx5isGL21lsGvDqoFxb9fGWdVpOaF2trdfKTgGyyDwEZpwicZnc9DlQE9ca5CXWhBEuduD5U1YNYq4yPo+Jym8BFh0O9b5xfOZpM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VnhH1L+o; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VnhH1L+o" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 431BA1F000E9; Thu, 9 Jul 2026 19:27:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783625263; bh=ojimdSKL7yFLNVHqovzToUoR66kYEIlZT9Kj2ekQW4w=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VnhH1L+orH83KASf4caE5eJ+sZ/++TaX2uSseXXU8iPUrbIpl0JmD9SLX/3LOKHq8 aRH7e6SZqWJNRP8BvyIAbLvZBsofJroFqBXY51I8kpoyB8bhCs7qMEWsOqDwCOdorZ 6zqxJGNeTfXePzQODNV5jIzkdmum6wINiHagmUMIp+iKSJKMNQZKv1lbHFIGX422uW LYzG1miYIUBPQI+CRVR1aWr1KtczPzC1laLRx+xI0s6m8uB/kIJOOTvwX5XvfG6kwJ rRmjgJ3aVado8Ve2kajLffvVXCKYjgW8in/l0odxcDC9G9qB2x1kJ/RD/a1Q7Mariu rrmWk6dE20KVA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 21/36] phy: rockchip: usbdp: Properly handle TYPEC_STATE_SAFE and TYPEC_STATE_USB Reply-To: sashiko-reviews@lists.linux.dev To: "Sebastian Reichel" Cc: vkoul@kernel.org, olteanv@gmail.com, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, robh@kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org In-Reply-To: <20260709-rockchip-usbdp-cleanup-v11-21-a149ac60f76c@collabora.com> References: <20260709-rockchip-usbdp-cleanup-v11-0-a149ac60f76c@collabora.com> <20260709-rockchip-usbdp-cleanup-v11-21-a149ac60f76c@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 09 Jul 2026 19:27:42 +0000 Message-Id: <20260709192743.431BA1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: Pre-existing issues: - [High] Exiting DP AltMode fails to physically restore USB lane muxing if = the USB controller remains logically active. - [High] `rk_udphy_usb3_phy_exit` leaks the USB PHY power state if the Type= -C mux mode was changed to DP-only before the USB controller calls `phy_exi= t`. -- --- Patch [21]: [PATCH v11 21/36] phy: rockchip: usbdp: Properly handle TYP= EC_STATE_SAFE and TYPEC_STATE_USB --- commit 8663a5e7459552707b3ef82190885d5f5b02aa6b Author: Sebastian Reichel phy: rockchip: usbdp: Properly handle TYPEC_STATE_SAFE and TYPEC_STATE_USB This commit adds support for TYPEC_STATE_SAFE and TYPEC_STATE_USB Type-C state events to ensure muxing is properly updated when exiting DP AltMode. It fixes an issue in the rockchip usbdp combo phy driver. Fixes: 2f70bbddeb45 ("phy: rockchip: add usbdp combo phy driver") Reported-by: Sashiko Closes: https://sashiko.dev/#/message/20260619155020.CC7361F000E9%40smtp.ke= rnel.org > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rock= chip/phy-rockchip-usbdp.c > index 4e54020d17551..0399cbf96e195 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -1293,17 +1293,26 @@ static const struct phy_ops rk_udphy_usb3_phy_ops= =3D { > .owner =3D THIS_MODULE, > }; [Severity: High] This is a pre-existing issue, but I am wondering if rk_udphy_usb3_phy_exit() leaks the USB PHY power state when the Type-C mux mode is changed to DP-only before the USB controller calls phy_exit()? If the Type-C mux switches to 4-lane DP AltMode, udphy->mode becomes UDPHY_MODE_DP. If the USB controller then suspends or is unbound, it calls rk_udphy_usb3_phy_exit(), which returns early: drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_usb3_phy_exit() { ... /* DP only or high-speed */ if (!(udphy->mode & UDPHY_MODE_USB) || udphy->hs) goto unlock; rk_udphy_power_off(udphy, UDPHY_MODE_USB); ... } This skips rk_udphy_power_off(), leaving UDPHY_MODE_USB set in udphy->statu= s. Since status never reaches UDPHY_MODE_NONE when DP later powers off, rk_udphy_disable() is never called. Will the PHY clocks and resets remain permanently active when they should be suspended? > =20 > +static bool rk_udphy_is_supported_mode(struct typec_mux_state *state) > +{ > + /* Handle Safe State and USB State */ > + if (state->mode < TYPEC_STATE_MODAL) > + return true; > + > + /* Handle DP AltMode */ > + if (state->alt && state->alt->svid =3D=3D USB_TYPEC_DP_SID) > + return true; > + > + return false; > +} > + > static int rk_udphy_typec_mux_set(struct typec_mux_dev *mux, > struct typec_mux_state *state) > { > struct rk_udphy *udphy =3D typec_mux_get_drvdata(mux); > =20 > - /* > - * Ignore mux events not involving DP AltMode, because > - * the mode field is being reused, e.g. state->mode =3D=3D 4 > - * could be either TYPEC_MODE_USB4 or TYPEC_DP_STATE_C. > - */ > - if (!state->alt || state->alt->svid !=3D USB_TYPEC_DP_SID) > + /* Ignore mux events not involving USB or DP */ > + if (!rk_udphy_is_supported_mode(state)) > return 0; > =20 > mutex_lock(&udphy->mutex); [Severity: High] This is a pre-existing issue, but can the PHY get permanently stuck in 4-la= ne DP mode when exiting DP AltMode if the USB controller remains logically act= ive? When rk_udphy_typec_mux_set() handles the transition to TYPEC_STATE_SAFE or TYPEC_STATE_USB, it updates the software mode and sets phy_needs_reinit to true via rk_udphy_set_typec_state() later in this function: drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_typec_mux_set() { ... rk_udphy_set_typec_state(udphy, state->mode); ... } However, the hardware muxing is only updated in rk_udphy_power_on(): drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_power_on() { ... } else if (udphy->phy_needs_reinit) { if (udphy->mode =3D=3D UDPHY_MODE_DP) rk_udphy_u3_port_disable(udphy, true); ret =3D rk_udphy_init(udphy); ... } If the USB controller (e.g. dwc3) is already active, it will not call phy_power_on() again. This causes the hardware re-initialization to be miss= ed, leaving the PHY physically in 4-lane DP mode. Is it possible for USB 3.x to become completely unresponsive in this state, even though the Type-C subsystem correctly returned to USB mode? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260709-rockchip-u= sbdp-cleanup-v11-0-a149ac60f76c@collabora.com?part=3D21