From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70B914499B9 for ; Thu, 9 Jul 2026 19:35:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783625714; cv=none; b=g5siGqHyiXv8sk7zoDRzwLQvQ8vn3oCdnnFqJe4/togY554BDqkZq8U25azvlfWXt8dqs2yFWBSNdvaTu1Vpb1bfdvOoVt/0o39GsQNo/ojtkSmKMQB/BLimwxRpZx74OsHodDa9HxPopOl5SCnjhlBuCD6b7dZBTCtUzxsgFv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783625714; c=relaxed/simple; bh=3BCbP4rZr/HuMGnAB1QxnTzUBAOgcfHWR39dHV3WPs8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=l8o5/TnapMy3t7XUTYrNmcMvGiIafftrxunVyJbSrSVzIjUxottEp2t1Wgx1oXWA2QW59KwrCQy1AMioxwvDDHTbh7vUgT3cf2UQ9WBaLjevujumcL18+vvEyyDs+l+pBv46kigg5rL0AJZ/fQ6Ry4wSFdPzxG9Q5DpLGiu1Xm8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KsV5m5GK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KsV5m5GK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49EDA1F000E9; Thu, 9 Jul 2026 19:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783625711; bh=//PSvNaFDhOc7sMde8qt3Bb/n34rOtOVhiD77ReltBo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KsV5m5GKgLCOMn8vTzmoUN7noqmUvlWuVzynRRRjuVxCDXXi+fi9UDgWG3KRTKEA4 UaxUnViKVHdUsbi4IdPbBAtUjYxSFFOugCcewr9o9dXfoELQO6NHjvM+2LaHgvDKIb 289tVzcZiK7Qo2+fhO88S526ZhBj5bAFk3hUdcjn3SYER88yIzegCX+P6dEpTOuUOD x3Gd+zW0fVp4QOJZPntglkc6ToWIilD5DChj51YMJjq4gP9PJOYzaWZs8RbnAuRDJo CmZ5vqCQEEwjIxVl6zJvsuu/5qpKE98ft318T0I7vtGxmIwGQQt3iAUFmUt9ssUW6y 0MDdPIBvY6CNQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 33/36] phy: rockchip: usbdp: Rename mode to hw_mode Reply-To: sashiko-reviews@lists.linux.dev To: "Sebastian Reichel" Cc: conor+dt@kernel.org, vkoul@kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, olteanv@gmail.com, robh@kernel.org In-Reply-To: <20260709-rockchip-usbdp-cleanup-v11-33-a149ac60f76c@collabora.com> References: <20260709-rockchip-usbdp-cleanup-v11-0-a149ac60f76c@collabora.com> <20260709-rockchip-usbdp-cleanup-v11-33-a149ac60f76c@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 09 Jul 2026 19:35:10 +0000 Message-Id: <20260709193511.49EDA1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: Pre-existing issues: - [High] TYPEC_STATE_USB and TYPEC_STATE_SAFE mux events incorrectly config= ure the PHY for DisplayPort instead of USB-only. - [High] rk_udphy_power_off and rk_udphy_usb3_phy_exit incorrectly use hw_m= ode to bypass power-off, permanently leaking the PHY state and preventing r= k_udphy_disable() from being called. -- --- Patch [33]: [PATCH v11 33/36] phy: rockchip: usbdp: Rename mode to hw_m= ode --- commit 6f61047a0ab430913024fc15e4a26038f67189e4 Author: Sebastian Reichel phy: rockchip: usbdp: Rename mode to hw_mode Rename mode field to hw_mode to make clear that this is the modes currently supported by the hardware, but not necessarily requested by software. It is only set by either the USB-C state machine or device-tree if the PHY is used in a fixed routing setup. > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rock= chip/phy-rockchip-usbdp.c > index 3fb6eea2979b9..e2cd72643a7d7 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c [ ... ] > @@ -616,12 +616,12 @@ static void rk_udphy_set_typec_state(struct rk_udph= y *udphy, unsigned long state > udphy->lane_mux_sel[2] =3D PHY_LANE_MUX_DP; > udphy->lane_mux_sel[3] =3D PHY_LANE_MUX_DP; > } > - mode =3D UDPHY_MODE_DP_USB; > + hw_mode =3D UDPHY_MODE_DP_USB; [Severity: High] This isn't a bug introduced by this patch, but since the switch statement l= acks explicit cases for TYPEC_STATE_USB and TYPEC_STATE_SAFE, do they fall throu= gh to the default case here and incorrectly configure the PHY for DisplayPort instead of USB-only? If a standard USB device is connected or the port is in a safe/unattached s= tate, the Type-C subsystem fires a mux event with state->mode =3D TYPEC_STATE_USB= (or TYPEC_STATE_SAFE), and it seems they would erroneously be assigned=20 UDPHY_MODE_DP_USB with two DisplayPort lanes instead of just UDPHY_MODE_USB. > udphy->dp_lanes =3D 2; > break; > } [ ... ] > @@ -1033,7 +1033,7 @@ static int rk_udphy_power_on(struct rk_udphy *udphy= , u8 mode) > =20 > static void rk_udphy_power_off(struct rk_udphy *udphy, u8 mode) > { > - if (!(udphy->mode & mode)) { > + if (!(udphy->hw_mode & mode)) { [Severity: High] This is a pre-existing issue, but does using hw_mode here bypass the power-= off sequence and permanently leak the physical PHY state? If a Type-C event changes the hardware mode to DP-only (hw_mode =3D UDPHY_MODE_DP), the USB mode is dropped. If rk_udphy_power_off() is called afterwards, this check will bypass physical shutdown since the requested mo= de was already removed from hw_mode, preventing rk_udphy_disable() from being called. > dev_info(udphy->dev, "mode 0x%02x is not support\n", mode); > return; > } [ ... ] > @@ -1307,7 +1307,7 @@ static int rk_udphy_usb3_phy_exit(struct phy *phy) > guard(mutex)(&udphy->mutex); > =20 > /* DP only or high-speed */ > - if (!(udphy->mode & UDPHY_MODE_USB) || udphy->hs) { > + if (!(udphy->hw_mode & UDPHY_MODE_USB) || udphy->hs) { [Severity: High] This is a pre-existing issue, but this appears to have the same flaw as rk_udphy_power_off() above. When the USB consumer subsequently calls phy_exit(), and hw_mode has already dropped the USB mode, this returns early without delegating to rk_udphy_power_off(). If the PHY status reached UDPHY_MODE_NONE, rk_udphy_disable() is never called, and the PHY remains physically powered = on indefinitely. > udphy->status &=3D ~UDPHY_MODE_USB; > return 0; > } --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260709-rockchip-u= sbdp-cleanup-v11-0-a149ac60f76c@collabora.com?part=3D33 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0674CC43458 for ; Thu, 9 Jul 2026 19:35:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qvNaSrndMuTnq5TVz85sH3TWafh0j7kNh2K5NxUcCOs=; b=Uk1VKGM9HfDoPF Pn/zyrZ0qUu+6vzjWvEFPXLwYuQ95yU3XGl/SG3omcWKzaKUPQcWt/NETj9uTFiuuqyVFomPuIGD7 ozH9CK5j8oSx8+/H+2KxaZMa/IGff7GOHTKcZPo2JBWtw35HZi0W8NM71iIFXx9mzs63XshCD86Po vNmpOMD8OjhW8ek3yat+laUWFap9Y48YaYLTOuHWAn6lI4IeOYNwlTnetqQ0d0I4GwNkT0HXscq9c lxcpKNv0wJnGpyj5sDGlzylRI7Ncz2y6NGQ7D7EpLQmWfS+GBIb8DBOjrDMmuJ4N78tqF/1Qq9kzz qyaywBnRV+SQDmLGAaWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1whuWf-00000003Tte-3JnD; Thu, 09 Jul 2026 19:35:13 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1whuWe-00000003TtT-3HJ3 for linux-phy@lists.infradead.org; Thu, 09 Jul 2026 19:35:12 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 0716F600C3; Thu, 9 Jul 2026 19:35:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 49EDA1F000E9; Thu, 9 Jul 2026 19:35:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783625711; bh=//PSvNaFDhOc7sMde8qt3Bb/n34rOtOVhiD77ReltBo=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KsV5m5GKgLCOMn8vTzmoUN7noqmUvlWuVzynRRRjuVxCDXXi+fi9UDgWG3KRTKEA4 UaxUnViKVHdUsbi4IdPbBAtUjYxSFFOugCcewr9o9dXfoELQO6NHjvM+2LaHgvDKIb 289tVzcZiK7Qo2+fhO88S526ZhBj5bAFk3hUdcjn3SYER88yIzegCX+P6dEpTOuUOD x3Gd+zW0fVp4QOJZPntglkc6ToWIilD5DChj51YMJjq4gP9PJOYzaWZs8RbnAuRDJo CmZ5vqCQEEwjIxVl6zJvsuu/5qpKE98ft318T0I7vtGxmIwGQQt3iAUFmUt9ssUW6y 0MDdPIBvY6CNQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 33/36] phy: rockchip: usbdp: Rename mode to hw_mode To: "Sebastian Reichel" Cc: conor+dt@kernel.org, vkoul@kernel.org, devicetree@vger.kernel.org, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, olteanv@gmail.com, robh@kernel.org In-Reply-To: <20260709-rockchip-usbdp-cleanup-v11-33-a149ac60f76c@collabora.com> References: <20260709-rockchip-usbdp-cleanup-v11-0-a149ac60f76c@collabora.com> <20260709-rockchip-usbdp-cleanup-v11-33-a149ac60f76c@collabora.com> Date: Thu, 09 Jul 2026 19:35:10 +0000 Message-Id: <20260709193511.49EDA1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBUWVBFQ19TVEFURV9VU0IgYW5kIFRZUEVDX1NUQVRFX1NBRkUgbXV4IGV2ZW50cyBp bmNvcnJlY3RseSBjb25maWd1cmUgdGhlIFBIWSBmb3IgRGlzcGxheVBvcnQgaW5zdGVhZCBvZiBV U0Itb25seS4KLSBbSGlnaF0gcmtfdWRwaHlfcG93ZXJfb2ZmIGFuZCBya191ZHBoeV91c2IzX3Bo eV9leGl0IGluY29ycmVjdGx5IHVzZSBod19tb2RlIHRvIGJ5cGFzcyBwb3dlci1vZmYsIHBlcm1h bmVudGx5IGxlYWtpbmcgdGhlIFBIWSBzdGF0ZSBhbmQgcHJldmVudGluZyBya191ZHBoeV9kaXNh YmxlKCkgZnJvbSBiZWluZyBjYWxsZWQuCi0tCgotLS0gUGF0Y2ggWzMzXTogW1BBVENIIHYxMSAz My8zNl0gcGh5OiByb2NrY2hpcDogdXNiZHA6IFJlbmFtZSBtb2RlIHRvIGh3X21vZGUgLS0tCmNv bW1pdCA2ZjYxMDQ3YTBhYjQzMDkxMzAyNGZjMTVlNGEyNjAzOGY2NzE4OWU0CkF1dGhvcjogU2Vi YXN0aWFuIFJlaWNoZWwgPHNlYmFzdGlhbi5yZWljaGVsQGNvbGxhYm9yYS5jb20+CgpwaHk6IHJv Y2tjaGlwOiB1c2JkcDogUmVuYW1lIG1vZGUgdG8gaHdfbW9kZQoKUmVuYW1lIG1vZGUgZmllbGQg dG8gaHdfbW9kZSB0byBtYWtlIGNsZWFyIHRoYXQgdGhpcyBpcyB0aGUgbW9kZXMKY3VycmVudGx5 IHN1cHBvcnRlZCBieSB0aGUgaGFyZHdhcmUsIGJ1dCBub3QgbmVjZXNzYXJpbHkgcmVxdWVzdGVk CmJ5IHNvZnR3YXJlLiBJdCBpcyBvbmx5IHNldCBieSBlaXRoZXIgdGhlIFVTQi1DIHN0YXRlIG1h Y2hpbmUKb3IgZGV2aWNlLXRyZWUgaWYgdGhlIFBIWSBpcyB1c2VkIGluIGEgZml4ZWQgcm91dGlu ZyBzZXR1cC4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hp cC11c2JkcC5jIGIvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLXVzYmRwLmMKPiBp bmRleCAzZmI2ZWVhMjk3OWI5Li5lMmNkNzI2NDNhN2Q3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv cGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC11c2JkcC5jCj4gKysrIGIvZHJpdmVycy9waHkvcm9j a2NoaXAvcGh5LXJvY2tjaGlwLXVzYmRwLmMKWyAuLi4gXQo+IEBAIC02MTYsMTIgKzYxNiwxMiBA QCBzdGF0aWMgdm9pZCBya191ZHBoeV9zZXRfdHlwZWNfc3RhdGUoc3RydWN0IHJrX3VkcGh5ICp1 ZHBoeSwgdW5zaWduZWQgbG9uZyBzdGF0ZQo+ICAJCQl1ZHBoeS0+bGFuZV9tdXhfc2VsWzJdID0g UEhZX0xBTkVfTVVYX0RQOwo+ICAJCQl1ZHBoeS0+bGFuZV9tdXhfc2VsWzNdID0gUEhZX0xBTkVf TVVYX0RQOwo+ICAJCX0KPiAtCQltb2RlID0gVURQSFlfTU9ERV9EUF9VU0I7Cj4gKwkJaHdfbW9k ZSA9IFVEUEhZX01PREVfRFBfVVNCOwoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlzbid0IGEgYnVn IGludHJvZHVjZWQgYnkgdGhpcyBwYXRjaCwgYnV0IHNpbmNlIHRoZSBzd2l0Y2ggc3RhdGVtZW50 IGxhY2tzCmV4cGxpY2l0IGNhc2VzIGZvciBUWVBFQ19TVEFURV9VU0IgYW5kIFRZUEVDX1NUQVRF X1NBRkUsIGRvIHRoZXkgZmFsbCB0aHJvdWdoCnRvIHRoZSBkZWZhdWx0IGNhc2UgaGVyZSBhbmQg aW5jb3JyZWN0bHkgY29uZmlndXJlIHRoZSBQSFkgZm9yIERpc3BsYXlQb3J0Cmluc3RlYWQgb2Yg VVNCLW9ubHk/CgpJZiBhIHN0YW5kYXJkIFVTQiBkZXZpY2UgaXMgY29ubmVjdGVkIG9yIHRoZSBw b3J0IGlzIGluIGEgc2FmZS91bmF0dGFjaGVkIHN0YXRlLAp0aGUgVHlwZS1DIHN1YnN5c3RlbSBm aXJlcyBhIG11eCBldmVudCB3aXRoIHN0YXRlLT5tb2RlID0gVFlQRUNfU1RBVEVfVVNCIChvcgpU WVBFQ19TVEFURV9TQUZFKSwgYW5kIGl0IHNlZW1zIHRoZXkgd291bGQgZXJyb25lb3VzbHkgYmUg YXNzaWduZWQgClVEUEhZX01PREVfRFBfVVNCIHdpdGggdHdvIERpc3BsYXlQb3J0IGxhbmVzIGlu c3RlYWQgb2YganVzdCBVRFBIWV9NT0RFX1VTQi4KCj4gIAkJdWRwaHktPmRwX2xhbmVzID0gMjsK PiAgCQlicmVhazsKPiAgCX0KWyAuLi4gXQo+IEBAIC0xMDMzLDcgKzEwMzMsNyBAQCBzdGF0aWMg aW50IHJrX3VkcGh5X3Bvd2VyX29uKHN0cnVjdCBya191ZHBoeSAqdWRwaHksIHU4IG1vZGUpCj4g IAo+ICBzdGF0aWMgdm9pZCBya191ZHBoeV9wb3dlcl9vZmYoc3RydWN0IHJrX3VkcGh5ICp1ZHBo eSwgdTggbW9kZSkKPiAgewo+IC0JaWYgKCEodWRwaHktPm1vZGUgJiBtb2RlKSkgewo+ICsJaWYg KCEodWRwaHktPmh3X21vZGUgJiBtb2RlKSkgewoKW1NldmVyaXR5OiBIaWdoXQpUaGlzIGlzIGEg cHJlLWV4aXN0aW5nIGlzc3VlLCBidXQgZG9lcyB1c2luZyBod19tb2RlIGhlcmUgYnlwYXNzIHRo ZSBwb3dlci1vZmYKc2VxdWVuY2UgYW5kIHBlcm1hbmVudGx5IGxlYWsgdGhlIHBoeXNpY2FsIFBI WSBzdGF0ZT8KCklmIGEgVHlwZS1DIGV2ZW50IGNoYW5nZXMgdGhlIGhhcmR3YXJlIG1vZGUgdG8g RFAtb25seSAoaHdfbW9kZSA9ClVEUEhZX01PREVfRFApLCB0aGUgVVNCIG1vZGUgaXMgZHJvcHBl ZC4gSWYgcmtfdWRwaHlfcG93ZXJfb2ZmKCkgaXMgY2FsbGVkCmFmdGVyd2FyZHMsIHRoaXMgY2hl Y2sgd2lsbCBieXBhc3MgcGh5c2ljYWwgc2h1dGRvd24gc2luY2UgdGhlIHJlcXVlc3RlZCBtb2Rl CndhcyBhbHJlYWR5IHJlbW92ZWQgZnJvbSBod19tb2RlLCBwcmV2ZW50aW5nIHJrX3VkcGh5X2Rp c2FibGUoKSBmcm9tIGJlaW5nCmNhbGxlZC4KCj4gIAkJZGV2X2luZm8odWRwaHktPmRldiwgIm1v ZGUgMHglMDJ4IGlzIG5vdCBzdXBwb3J0XG4iLCBtb2RlKTsKPiAgCQlyZXR1cm47Cj4gIAl9Clsg Li4uIF0KPiBAQCAtMTMwNyw3ICsxMzA3LDcgQEAgc3RhdGljIGludCBya191ZHBoeV91c2IzX3Bo eV9leGl0KHN0cnVjdCBwaHkgKnBoeSkKPiAgCWd1YXJkKG11dGV4KSgmdWRwaHktPm11dGV4KTsK PiAgCj4gIAkvKiBEUCBvbmx5IG9yIGhpZ2gtc3BlZWQgKi8KPiAtCWlmICghKHVkcGh5LT5tb2Rl ICYgVURQSFlfTU9ERV9VU0IpIHx8IHVkcGh5LT5ocykgewo+ICsJaWYgKCEodWRwaHktPmh3X21v ZGUgJiBVRFBIWV9NT0RFX1VTQikgfHwgdWRwaHktPmhzKSB7CgpbU2V2ZXJpdHk6IEhpZ2hdClRo aXMgaXMgYSBwcmUtZXhpc3RpbmcgaXNzdWUsIGJ1dCB0aGlzIGFwcGVhcnMgdG8gaGF2ZSB0aGUg c2FtZSBmbGF3IGFzCnJrX3VkcGh5X3Bvd2VyX29mZigpIGFib3ZlLgoKV2hlbiB0aGUgVVNCIGNv bnN1bWVyIHN1YnNlcXVlbnRseSBjYWxscyBwaHlfZXhpdCgpLCBhbmQgaHdfbW9kZSBoYXMgYWxy ZWFkeQpkcm9wcGVkIHRoZSBVU0IgbW9kZSwgdGhpcyByZXR1cm5zIGVhcmx5IHdpdGhvdXQgZGVs ZWdhdGluZyB0bwpya191ZHBoeV9wb3dlcl9vZmYoKS4gSWYgdGhlIFBIWSBzdGF0dXMgcmVhY2hl ZCBVRFBIWV9NT0RFX05PTkUsCnJrX3VkcGh5X2Rpc2FibGUoKSBpcyBuZXZlciBjYWxsZWQsIGFu ZCB0aGUgUEhZIHJlbWFpbnMgcGh5c2ljYWxseSBwb3dlcmVkIG9uCmluZGVmaW5pdGVseS4KCj4g IAkJdWRwaHktPnN0YXR1cyAmPSB+VURQSFlfTU9ERV9VU0I7Cj4gIAkJcmV0dXJuIDA7Cj4gIAl9 CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0 LzIwMjYwNzA5LXJvY2tjaGlwLXVzYmRwLWNsZWFudXAtdjExLTAtYTE0OWFjNjBmNzZjQGNvbGxh Ym9yYS5jb20/cGFydD0zMwoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxp c3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlz dGluZm8vbGludXgtcGh5Cg==