Re: [PATCH] arm64: dts: imx91-9x9-qsb: add CAN support overlay file

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree overlay references an undefined phandle `<&can_fun>` and omits the `pinctrl-gpiomux` node described in the commit message, causing a build failure.
--

--- Patch [1]: [PATCH] arm64: dts: imx91-9x9-qsb: add CAN support overlay file ---
commit ba3a1378093445c34dbdd034a8296e7aaebdd0da
Author: Haibo Chen <haibo.chen@nxp.com>

arm64: dts: imx91-9x9-qsb: add CAN support overlay file

This commit adds a device tree overlay to enable CAN1 support on the
i.MX91 9x9 QSB board. It configures the TJA1057GT/3 PHY and sets up
the CAN1 pins.

> diff --git a/arch/arm64/boot/dts/freescale/imx91-9x9-qsb-can1.dtso b/arch/arm64/boot/dts/freescale/imx91-9x9-qsb-can1.dtso
> new file mode 100644
> index 0000000000000..b8343d653e511
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx91-9x9-qsb-can1.dtso

[ ... ]

> +&flexcan1 {
> +	phys = <&flexcan_phy>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_flexcan1>, <&can_fun>;

[Severity: Low]
Does this overlay build successfully? The device tree overlay references
the can_fun phandle, but it does not appear to be defined here or in the
base device tree.

The commit message mentions a pinctrl-gpiomux node for can_fun, but it seems
to be missing from the patch. When the Makefile applies this overlay, will
fdtoverlay fail due to the unresolved reference?

> +	status = "okay";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260710-dts-imx91-can1-v1-1-c78c9c378e8d@nxp.com?part=1