From: Wander Lairson Costa <wander@redhat.com>
To: williams@redhat.com, jkacur@redhat.com, linux-rt-users@vger.kernel.org
Cc: juri.lelli@redhat.com, luffyluo@tencent.com,
davidlt@rivosinc.com, Wander Lairson Costa <wander@redhat.com>
Subject: [PATCH 06/11] tests: add --fail-fast flag to stop on first failure
Date: Fri, 10 Jul 2026 10:38:05 -0300 [thread overview]
Message-ID: <20260710133810.72398-7-wander@redhat.com> (raw)
In-Reply-To: <20260710133810.72398-1-wander@redhat.com>
Add a --fail-fast option to run_tests.sh that prints the test
summary and exits immediately when a test fails. The exit
triggers the cleanup trap, so RT throttling and DL-server state
are still restored.
Use print_summary || true before exit 1 to prevent set -e from
intercepting the non-zero return of print_summary's final
[ ${FAILED_TESTS} -eq 0 ] check.
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
---
tests/run_tests.sh | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/tests/run_tests.sh b/tests/run_tests.sh
index 6bfae0f..a2d50e0 100755
--- a/tests/run_tests.sh
+++ b/tests/run_tests.sh
@@ -19,6 +19,7 @@ THREADING_MODE_MATRIX=0 # Threading mode matrix testing disabled by default (en
THREADING_MODES=("power" "adaptive" "aggressive") # Threading modes to test
THREADING_MODE="" # Specific threading mode to use (empty = default)
VERBOSE=0 # Run tests with bash -vx for trace output
+FAIL_FAST=0 # Stop on first test failure
# Source test helpers for RT throttling and DL-server management
source "${TEST_ROOT}/helpers/test_helpers.sh" 2>/dev/null || true
@@ -520,6 +521,10 @@ run_shell_test() {
if [ -n "${mode}" ]; then
MODE_FAILED["${mode}"]=$((MODE_FAILED["${mode}"] + 1))
fi
+ if [ ${FAIL_FAST} -eq 1 ]; then
+ print_summary || true
+ exit 1
+ fi
fi
fi
}
@@ -609,6 +614,10 @@ while [[ $# -gt 0 ]]; do
VERBOSE=1
shift
;;
+ --fail-fast)
+ FAIL_FAST=1
+ shift
+ ;;
--disable-dl-server)
DISABLE_DL_SERVER=1
shift
@@ -673,6 +682,7 @@ while [[ $# -gt 0 ]]; do
echo ""
echo "Other Options:"
echo " --verbose Run tests with bash -vx for trace output"
+ echo " --fail-fast Stop on first test failure"
echo " --disable-dl-server Disable DL-server before running tests"
echo " -h, --help Show this help"
echo ""
--
2.55.0
next prev parent reply other threads:[~2026-07-10 13:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-10 13:37 [PATCH 00/11] tests: harden functional test suite against flakiness Wander Lairson Costa
2026-07-10 13:38 ` [PATCH 01/11] stalld: add readiness log marker for tests Wander Lairson Costa
2026-07-10 13:38 ` [PATCH 02/11] tests: use fail() for error paths in helpers Wander Lairson Costa
2026-07-10 13:38 ` [PATCH 03/11] tests: add --verbose flag for bash trace output Wander Lairson Costa
2026-07-10 13:38 ` [PATCH 04/11] tests: drop journal logging from test framework Wander Lairson Costa
2026-07-10 13:38 ` [PATCH 05/11] tests: fix intermittent starvation_gen readiness failure Wander Lairson Costa
2026-07-10 13:38 ` Wander Lairson Costa [this message]
2026-07-10 13:38 ` [PATCH 07/11] tests: dump log contents on assert_log_contains failure Wander Lairson Costa
2026-07-10 13:38 ` [PATCH 08/11] tests: dump log on start_stalld_with_log failure Wander Lairson Costa
2026-07-10 13:38 ` [PATCH 09/11] tests: start stalld before starvation_gen in all tests Wander Lairson Costa
2026-07-10 13:38 ` [PATCH 10/11] tests: add startup timing to stalld launch helpers Wander Lairson Costa
2026-07-10 13:38 ` [PATCH 11/11] tests: increase stalld initialization timeout to 240s Wander Lairson Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260710133810.72398-7-wander@redhat.com \
--to=wander@redhat.com \
--cc=davidlt@rivosinc.com \
--cc=jkacur@redhat.com \
--cc=juri.lelli@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=luffyluo@tencent.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.