All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Loic Poulain" <loic.poulain@oss.qualcomm.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, lee@kernel.org,
	robh@kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v5 2/4] dt-bindings: leds: nxp,pca963x: add multicolor LED support
Date: Fri, 10 Jul 2026 13:59:11 +0000	[thread overview]
Message-ID: <20260710135912.2E64F1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260710-monza-leds-v5-2-a8972d28c28f@oss.qualcomm.com>

> Add support for grouping individual PCA963x channels into a multicolor
> LED by introducing a multi-led@N node pattern. This follows the
> convention established by other multicolor LED drivers such as
> kinetic,ktd202x.
> 
> This is necessary to support and model hardware setups where multiple
> PWM channels drive a single physical RGB LED.
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Signed-off-by: Loic Poulain <loic.poulain@oss.qualcomm.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260710-monza-leds-v5-0-a8972d28c28f@oss.qualcomm.com?part=2


  reply	other threads:[~2026-07-10 13:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-10 13:49 [PATCH v5 0/4] leds: pca963x: Add multicolor support and enable Monza RGB LEDs Loic Poulain
2026-07-10 13:49 ` [PATCH v5 1/4] dt-bindings: leds: nxp,pca963x: fix reg maximum for pca9635 Loic Poulain
2026-07-10 13:54   ` sashiko-bot
2026-07-10 13:49 ` [PATCH v5 2/4] dt-bindings: leds: nxp,pca963x: add multicolor LED support Loic Poulain
2026-07-10 13:59   ` sashiko-bot [this message]
2026-07-10 13:49 ` [PATCH v5 3/4] leds: pca963x: add multicolor LED class support Loic Poulain
2026-07-10 14:10   ` sashiko-bot
2026-07-10 13:49 ` [PATCH v5 4/4] arm64: dts: monaco-arduino-monza: microcontroller LEDs Loic Poulain
2026-07-10 14:14   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260710135912.2E64F1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.