From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F9B343B498 for ; Fri, 10 Jul 2026 16:44:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783701871; cv=none; b=A98aNGTsshxA4YBhgIERmJDQlf7o5OvrhFIDJM/iPrsGkMn9NPONiW9QuBimu5DlX4C0WIEMPpswt4J5wSFNlsSmRBaTacol8kqtELeT7waMvH7B8PFYF7g1IHSCYBFAU1e/KMgtP0eDN/U7BkY/RjcWVQ1nhr6e7lOmzL2Gkzs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783701871; c=relaxed/simple; bh=f7MiJ/V3Sa3Z4+LOlKBCBuiD8YraJfksnG/xFb+njPc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=e4YBw3XU3MfTiEv10xS+W1Bo9MNec8ZDGqIgfUsU8g0QQ6U1dl9SM+osG3ufkSOXLV2iF/xDrOLu98yENTURdhwVXLJmNbVQ+R6XsTlTUBwCNi0ALAjKJWsmgo6rnS02GNusQbYt+h0/BncpfaGxKhkQVVdsbIjN61riI/nzUNM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=FI3oP9YY; arc=none smtp.client-ip=209.85.160.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="FI3oP9YY" Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-51c22c61795so7682801cf.0 for ; Fri, 10 Jul 2026 09:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1783701869; x=1784306669; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=f7jwDOcuUIXFwEJ3t6jZRtuRC5qCtLyV1KSZwcqARY0=; b=FI3oP9YYHhgE4T+LuS14BPDc6wqIOy69I4OhseWi8Rt1tf/J5Mw3KqzOf6S+XJf4aX tV/TkU2s864YpvGiyNx/mIKxQhOkoEySrwrleUYzVE/nk7OeZ09B60cbMn2C3XmSQBy0 dqUTDIHtc1vDT6N+p+5/Cqtfo4tviypiymM9uA+GYCDiJoYk42KS1Thf96n87SaVikK8 5dCSyAFF9LCmzGimeccwBw2zwbOpBfwEa5eAjiDX/+tKjtEvbX2JvgOrjflIojIjBHVg u4wJfYIrprUsVaVeeMCc8E4o9AmWKP8vhp3Wh/GBkbzhgV/KPNV40AuvmCVuiOEOMOXf te3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783701869; x=1784306669; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=f7jwDOcuUIXFwEJ3t6jZRtuRC5qCtLyV1KSZwcqARY0=; b=cDLlmuq0yi/Qf2lgWOSOlx/or+Lg8Ivp7cBrSW2+huIGihYZEy+jo2lnRCT7Z57K1v Uy7+ek0wM5qkrOJLV+EtKFE1HGP462kEoOl06CRSsMxBmhPRYOQ4RSPxrs9j14Druuuo 8RO0qqQG9zsCuP0vTod1zvW/V5vHwDmc/w8DBr6wBVgQpAPxPDrFHOXpvy+wAq/dcSwh i42unFVe0XY2Irblo0NKmsBsw4Egsp8/gLJHaWsrWVZAzSyYZo7IacGZFP2LOFbKIGFT U6RWJ4uDt4J6+HPhoUeshIVbqhAcg/gEUhfemfUCRODN/MuJBZ21DbuaFNRDB8szJpGz BxIw== X-Forwarded-Encrypted: i=1; AHgh+Roivk277V+p2bBTt+hNF/yq+rEoA7klURsbeKHE3qDKlHT1Y2J0DXcis/6lk2d/bRPTPzsxsqFLwL35Uow=@vger.kernel.org X-Gm-Message-State: AOJu0YxgrBo274b0iQFkNh/xMjUElrvsadOD9Phc2K7jO59RfGhK+oET /r8DV1/8d6OPehNOSfE6TYI6sx9YmtHIcM8lOPLlUYt0jPhZvjeWXUJXOvA0thmQ55U= X-Gm-Gg: AfdE7ckO1EUBJL/1DY8wfYsSXLrTo/yXfWFZbBUgTRBZg9NmZ6BGpK2EVj2wozioIpS 2IGRdLzlWUvWp3nn6SMOcYj9pW/1rQeiI/Pde6i2wqMZFY0mdl7OmSvb2o9h520vnH5GifNsuMm YXmCUfWppIfMkTPq1gz4UIabEmm0xdWuvG99qYrgztZLF+u7TYjrWC2tf+xmfbZ0TFTSmj+gGvF z7OfJeCPTYm46qL3WuAYClGU5OTXetsTPHD4qOMNDfNoU99LgliOMm0HSRdMGDIB48iB/so+0Uc xtd+/PUphiBPjMEDzXNuTBT6sTNxDQmTWEmVskP64Xbcc40bh7Zl3o+AsIfS/Q8SfpI1r63Un2h gydM9l4MlelVShSbkOAzgnBKYigrkSdXWFCkyMIyuxJUnATDzASXubeqX/kYP X-Received: by 2002:a05:622a:96:b0:51c:7b12:5ff5 with SMTP id d75a77b69052e-51c8b43fec2mr132124531cf.81.1783701869227; Fri, 10 Jul 2026 09:44:29 -0700 (PDT) Received: from ziepe.ca ([159.2.72.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd56c4b91sm45168766d6.19.2026.07.10.09.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 09:44:28 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wiEKx-00000007Yxj-3wpY; Fri, 10 Jul 2026 13:44:27 -0300 Date: Fri, 10 Jul 2026 13:44:27 -0300 From: Jason Gunthorpe To: Stanislav Kinsburskii Cc: airlied@gmail.com, akhilesh@ee.iitb.ac.in, akpm@linux-foundation.org, corbet@lwn.net, dakr@kernel.org, david@kernel.org, decui@microsoft.com, haiyangz@microsoft.com, kees@kernel.org, kys@microsoft.com, leon@kernel.org, liam@infradead.org, lizhi.hou@amd.com, ljs@kernel.org, longli@microsoft.com, lyude@redhat.com, maarten.lankhorst@linux.intel.com, mamin506@gmail.com, mhocko@suse.com, mripard@kernel.org, nouveau@lists.freedesktop.org, ogabbay@kernel.org, oleg@redhat.com, rppt@kernel.org, shuah@kernel.org, simona@ffwll.ch, skhan@linuxfoundation.org, surenb@google.com, tzimmermann@suse.de, vbabka@kernel.org, wei.liu@kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH v7 8/8] drm/gpusvm: Use hmm_range_fault_unlocked_timeout() for range faults Message-ID: <20260710164427.GW118978@ziepe.ca> References: <178345345668.660027.2952911919681614557.stgit@skinsburskii> <178345366389.660027.12986386801605494596.stgit@skinsburskii> Precedence: bulk X-Mailing-List: linux-hyperv@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178345366389.660027.12986386801605494596.stgit@skinsburskii> On Tue, Jul 07, 2026 at 12:47:43PM -0700, Stanislav Kinsburskii wrote: > Several GPU SVM paths take mmap_read_lock() only to call hmm_range_fault(), > then retry -EBUSY until HMM_RANGE_DEFAULT_TIMEOUT expires. Those paths use > MMU interval notifiers whose mm matches the mm that was locked for the HMM > fault. > > Use hmm_range_fault_unlocked_timeout() for those faults and pass the > remaining retry budget to HMM. The helper owns mmap_lock acquisition and > refreshes range->notifier_seq internally for each retry, while GPU SVM > keeps its existing driver-lock validation with mmu_interval_read_retry() > after a successful fault. > > Leave drm_gpusvm_check_pages() on hmm_range_fault() because that path is > called with the mmap lock already held by its caller. > > Signed-off-by: Stanislav Kinsburskii > --- > drivers/gpu/drm/drm_gpusvm.c | 52 ++++++------------------------------------ > 1 file changed, 7 insertions(+), 45 deletions(-) Reviewed-by: Jason Gunthorpe > - mmap_read_unlock(range->gpusvm->mm); > + err = hmm_range_fault_unlocked_timeout(&hmm_range, > + max_t(long, timeout - jiffies, 1)); Same remark about max_t Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E4B69C44501 for ; Fri, 10 Jul 2026 16:44:32 +0000 (UTC) Received: from kara.freedesktop.org (unknown [131.252.210.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2585B10EFBA; Fri, 10 Jul 2026 16:44:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=ziepe.ca header.i=@ziepe.ca header.b="bBRztYXn"; dkim-atps=neutral Received: from kara.freedesktop.org (localhost [127.0.0.1]) by kara.freedesktop.org (Postfix) with ESMTP id 9CFCF4702F; Fri, 10 Jul 2026 16:29:27 +0000 (UTC) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=lists.freedesktop.org; s=20240201; t=1783700967; b=ZVvf1DP99JZxiRivve0P5B7JFkjWqcIQP8WWn4JeSy7vztBwEE/7sRn05/V8urRG4HLh4 u92ZQaM6pWy0IUPO8cCvA1SQB6ESnUXPJUbDwWwKTi4S2AYCGcQH3v7ZP+7B1Ye7gxgaEvh mWChd65q+zXqKr9a7oDMA2Sa4OoxA3i1rzxQP3Ou9MJ5Yn3FpXlzg3rhI/ao9iwZvaEapCh E1hNWMUrpQY377Ql6Nibxx6WgvSaw7lhrk+KHsn/CDwoMsMO62ssEZCqu0swzLPZ37BqswG FT02D+LOD56Ck2ew/AJmjaMQW8WCojTWg+sAysQk/btzz77vb/0Nzj/wt+1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.freedesktop.org; s=20240201; t=1783700967; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=f7jwDOcuUIXFwEJ3t6jZRtuRC5qCtLyV1KSZwcqARY0=; b=OvD0pT8rzibWO7kj5h5YdlUhNC6tGYTj5HstytWCTPUgpx7ywyk6AlGvSvdNq7SNm+800 KU2gMBI5NdTglkweHzqKvcu7v71w+ed+lXWOWLD76e10CJhOT6divLLeJfI63EImE/BcShQ cm1nbjVmP/2Diks510ATqcNrKWNicdA5MUx3veN9OedJirClJCeSC93L/HK8aiV9f4pYNZ3 4jfuXDve02S8ARO/frjPmN7sVbdKTQWhdOmRwnxDYU4sC9xKh5cYg2b1NvBNxSVZqYYon+e utX+0SgIrV+YBbqaNKahWODI0UX3Poh087pkttPwqBOBcc3jEVnEdfWu99FQ== ARC-Authentication-Results: i=1; mail.freedesktop.org; dkim=pass header.d=ziepe.ca; arc=none (Message is not ARC signed); dmarc=none Authentication-Results: mail.freedesktop.org; dkim=pass header.d=ziepe.ca; arc=none (Message is not ARC signed); dmarc=none Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by kara.freedesktop.org (Postfix) with ESMTPS id EAEDB4022C for ; Fri, 10 Jul 2026 16:29:25 +0000 (UTC) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by gabe.freedesktop.org (Postfix) with ESMTPS id 53DCB10EB08 for ; Fri, 10 Jul 2026 16:44:30 +0000 (UTC) Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-51c0c68aa31so7532881cf.3 for ; Fri, 10 Jul 2026 09:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1783701869; x=1784306669; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=f7jwDOcuUIXFwEJ3t6jZRtuRC5qCtLyV1KSZwcqARY0=; b=bBRztYXnhgZn5YtgZ6yG55WVXbwDbgdpcGrzcFRtc0OZgnzEjXz8ubtQ7gkXODsXKR SYnmW2gdO6QQ3REQEo2O2V9Tz82tG8PYIIB58meOw4+67NnywYclnNqn3KRvitHT+BdN OUFq/SWZVGx5gdtmeF7stOrJ+Q2/tsaLx2HPey4u75om6eHcnKe0PTXT303zdPmN0SdG kpQmVJFmZQ4Nb/C5UWdXBh+QvhB75VzgoQZFxO57HLgqOY/pVIBX0YwmtiG49wnLlyjz yznrzd6BxvbI6SJtmALZ4vD8WyyhoGzC4MHBmgwo6tXWTqcSXyyaKUvDNNrniX9zueDF 6JIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783701869; x=1784306669; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=f7jwDOcuUIXFwEJ3t6jZRtuRC5qCtLyV1KSZwcqARY0=; b=bvKe3VbTZs/+lvCCrW9UrBSgARmrLGWqyJJFAZ1xOgqHkV/ammvaTuYiHdj/wwYUOv niSXkfSxp/D8TX9Z6gSrO8psuwajxRuEDa5KKKGSqCAci6TnkHVpeRa/lYJxHzxsIrpR a1/r7kjDLFxzPN+ZGC+BPyr/MOBQeSn7Ll5KCtZmIwWDYhyEjMI4QWnDMNvocAdIG4xD WPHODwlICdVXj9kib/jS8nBNyySskk60rTTREDIQcT1nnKJPvoE9iOmSlil2rda0u5pF PQGNRyGQQF+JMA/YSLprwYY0piQlSSALn8xqOh5TdZL7HreQW4NRV1lrPZ9QnAnfT36b 7hVg== X-Forwarded-Encrypted: i=1; AHgh+RqM/13ENSRQuxVJkLBWOW7cRIyh6si4fk//uUd1W16C1FjCrf/jXPxR1ha1iGfO+23fuoWr0SKn@lists.freedesktop.org X-Gm-Message-State: AOJu0YzIAJnYUr4fwGBYh2DBgqgkNYImOV4HOaN8QXm0TM7p/Mvzp1EW bT/bcZfEpoud3QPeLZSTDdZIbyBIBkeG29N1pwrKpCf8iMardUtkGKIBg4Kdr8kjGyk= X-Gm-Gg: AfdE7clmVlj5Cr//ewqPKAFcVpiTAwyGSQYldBmxgM4iOnhI+A8NSPi5+EvdQ3qxc+U nTc395KQdtpOnMY7cQSJBRe+qVuJy+r+a8zvU6jcNFl4/McZIAxdmQUF8bGd4VtfrEvuJfxcfNe WECZ1zpUw/wxOaGqG0brLA4W5aavwDMvE+elhSbSI81SeVe7901q8adAPso9SOQpxAC+HQQglP8 ov9PKLUBkezeo78J7ty4h8S22mh5bpJb3pZDD4yhg5JAUNpJmc8tEWjVMVB2OCXnEVOn+gDx3A0 4kfFS1n1tXOVsRKh5ZKmL4sWmI/7nmawNwtGF3/tu17Cg1f0ZcjMb8m8ZXOTrS4pG+WZOAQzXwh jmhxtjTkEu2ihFw6GYJyMcaKmU6KWX7p8UCrLi5DfKU7PDZPtkGiA9dWIXHki X-Received: by 2002:a05:622a:96:b0:51c:7b12:5ff5 with SMTP id d75a77b69052e-51c8b43fec2mr132124531cf.81.1783701869227; Fri, 10 Jul 2026 09:44:29 -0700 (PDT) Received: from ziepe.ca ([159.2.72.92]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8ffd56c4b91sm45168766d6.19.2026.07.10.09.44.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Jul 2026 09:44:28 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wiEKx-00000007Yxj-3wpY; Fri, 10 Jul 2026 13:44:27 -0300 Date: Fri, 10 Jul 2026 13:44:27 -0300 From: Jason Gunthorpe To: Stanislav Kinsburskii Subject: Re: [PATCH v7 8/8] drm/gpusvm: Use hmm_range_fault_unlocked_timeout() for range faults Message-ID: <20260710164427.GW118978@ziepe.ca> References: <178345345668.660027.2952911919681614557.stgit@skinsburskii> <178345366389.660027.12986386801605494596.stgit@skinsburskii> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <178345366389.660027.12986386801605494596.stgit@skinsburskii> Message-ID-Hash: D6ZEJHWYB2ST2EACQOMH6CI6KK7RZ2RH X-Message-ID-Hash: D6ZEJHWYB2ST2EACQOMH6CI6KK7RZ2RH X-MailFrom: jgg@ziepe.ca X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: akhilesh@ee.iitb.ac.in, akpm@linux-foundation.org, corbet@lwn.net, dakr@kernel.org, david@kernel.org, decui@microsoft.com, haiyangz@microsoft.com, kees@kernel.org, kys@microsoft.com, leon@kernel.org, liam@infradead.org, lizhi.hou@amd.com, ljs@kernel.org, longli@microsoft.com, maarten.lankhorst@linux.intel.com, mamin506@gmail.com, mhocko@suse.com, mripard@kernel.org, nouveau@lists.freedesktop.org, ogabbay@kernel.org, oleg@redhat.com, rppt@kernel.org, shuah@kernel.org, simona@ffwll.ch, skhan@linuxfoundation.org, surenb@google.com, vbabka@kernel.org, wei.liu@kernel.org, dri-devel@lists.freedesktop.org, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-rdma@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: Nouveau development list Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, Jul 07, 2026 at 12:47:43PM -0700, Stanislav Kinsburskii wrote: > Several GPU SVM paths take mmap_read_lock() only to call hmm_range_fault(), > then retry -EBUSY until HMM_RANGE_DEFAULT_TIMEOUT expires. Those paths use > MMU interval notifiers whose mm matches the mm that was locked for the HMM > fault. > > Use hmm_range_fault_unlocked_timeout() for those faults and pass the > remaining retry budget to HMM. The helper owns mmap_lock acquisition and > refreshes range->notifier_seq internally for each retry, while GPU SVM > keeps its existing driver-lock validation with mmu_interval_read_retry() > after a successful fault. > > Leave drm_gpusvm_check_pages() on hmm_range_fault() because that path is > called with the mmap lock already held by its caller. > > Signed-off-by: Stanislav Kinsburskii > --- > drivers/gpu/drm/drm_gpusvm.c | 52 ++++++------------------------------------ > 1 file changed, 7 insertions(+), 45 deletions(-) Reviewed-by: Jason Gunthorpe > - mmap_read_unlock(range->gpusvm->mm); > + err = hmm_range_fault_unlocked_timeout(&hmm_range, > + max_t(long, timeout - jiffies, 1)); Same remark about max_t Jason