Re: [PATCH v4 3/8] ibmvfc: make ibmvfc login to fabric

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The newly introduced IBMVFC_YES_SCSI capability flag is defined but never added to the client's login capabilities payload, preventing the client from advertising SCSI fabric login support to the VIOS.
--

--- Patch [3]: [PATCH v4 3/8] ibmvfc: make ibmvfc login to fabric ---
commit 1b5a2938bf5a0e21e24c77be11449d47426c29c4
Author: Dave Marquardt <davemarq@linux.ibm.com>

ibmvfc: make ibmvfc login to fabric
    
Add fabric login capability to support asynchronous event queue with
dedicated interrupt as required by NPIV specification for async sub-queue
and full/extended FPIN message support.

[ ... ]

> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.h b/drivers/scsi/ibmvscsi/ibmvfc.h
> index 526632cb72377..adfd67e85af86 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.h
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.h
> @@ -180,6 +181,7 @@ struct ibmvfc_npiv_login {
>  #define IBMVFC_CAN_HANDLE_FPIN		0x004
>  #define IBMVFC_CAN_USE_MAD_VERSION	0x008
>  #define IBMVFC_CAN_SEND_VF_WWPN		0x010
> +#define IBMVFC_YES_SCSI			0x040

[Severity: Medium]
Will the new fabric login functionality be reachable?

The IBMVFC_YES_SCSI flag is defined here, but it doesn't appear to be added
to the login capabilities payload in ibmvfc_set_login_info():

	login_info->capabilities =
		cpu_to_be64(IBMVFC_CAN_MIGRATE | IBMVFC_CAN_SEND_VF_WWPN |
			    IBMVFC_CAN_USE_NOOP_CMD);

Without advertising this capability to the VIOS, will the VIOS ever return
the IBMVFC_SUPPORT_SCSI flag, or will the host always fall back to the
legacy initialization path?

>  #define IBMVFC_CAN_USE_NOOP_CMD		0x200
>  	__be64 node_name;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260710-ibmvfc-fpin-support-v4-0-ef031ac19520@linux.ibm.com?part=3