From: Bjorn Helgaas <helgaas@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux ACPI <linux-acpi@vger.kernel.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Linux PCI <linux-pci@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v1] PCI: acpiphp_ibm: Do not use uninitialized device_class
Date: Fri, 10 Jul 2026 15:30:12 -0500 [thread overview]
Message-ID: <20260710203012.GA992878@bhelgaas> (raw)
In-Reply-To: <8730724.T7Z3S40VBb@rafael.j.wysocki>
On Mon, Jul 06, 2026 at 02:40:22PM +0200, Rafael J. Wysocki wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
>
> Passing an uninitialized pnp.device_class string to
> acpi_bus_generate_netlink_event() is effectively equivalent
> to passing an empty string literal to it.
>
> Accordingly, make the driver do the latter instead of doing the
> former.
>
> No intentional functional impact.
>
> This will facilitate the removal of device_class from struct
> acpi_device_pnp in the future.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Applied to pci/hotplug for v7.3, thanks!
> ---
> drivers/pci/hotplug/acpiphp_ibm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/pci/hotplug/acpiphp_ibm.c b/drivers/pci/hotplug/acpiphp_ibm.c
> index f8016ed24523..7337bd1ac6df 100644
> --- a/drivers/pci/hotplug/acpiphp_ibm.c
> +++ b/drivers/pci/hotplug/acpiphp_ibm.c
> @@ -258,8 +258,7 @@ static void ibm_handle_events(acpi_handle handle, u32 event, void *context)
>
> if (subevent == 0x80) {
> pr_debug("%s: generating bus event\n", __func__);
> - acpi_bus_generate_netlink_event(note->device->pnp.device_class,
> - dev_name(¬e->device->dev),
> + acpi_bus_generate_netlink_event("", dev_name(¬e->device->dev),
> note->event, detail);
> } else
> note->event = event;
> --
> 2.51.0
>
>
>
>
prev parent reply other threads:[~2026-07-10 20:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 12:40 [PATCH v1] PCI: acpiphp_ibm: Do not use uninitialized device_class Rafael J. Wysocki
2026-07-06 12:46 ` sashiko-bot
2026-07-08 14:33 ` Andy Shevchenko
2026-07-10 20:30 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260710203012.GA992878@bhelgaas \
--to=helgaas@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.