From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A5283B4E8B for ; Fri, 10 Jul 2026 21:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783718235; cv=none; b=sSdqW6EUQlbi+Rtnsn4lvQYW+shSTXNSRZWIMFHEPz9axNqNt6q0yKAeXYMGChO4mhLtPsw8drQG6CYSSEe9DJdZ2MUEfgoPmU6UPdkgIIpGOHQdZVzLmnYLC9FnXlCL3v2fydcem/nBQk/vg5nRlPKfdVJTlw/82zQw1xpojHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783718235; c=relaxed/simple; bh=4nS7AAIEeHikTcY+5gRo/qtgcIz5azqNdCkC+8VxlHs=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Mm//FiGLKHX0Wq1M4i6/MWe4KCxvTCLffcOLKId2yv2TOUKFlOnXLjBSXByUb0Cr60wUK7vNhZbnSgXNPqSJA76tpJZYCUsWHn8wjqd2jljz6Q6Cbj0uWoOaHLIYfx1yTnbI9z56oR6+prKVhgPo752nYC4/NrXZKHM0KQWOPUo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=A9yRTCpV; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="A9yRTCpV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99A891F000E9; Fri, 10 Jul 2026 21:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783718234; bh=3kAKtJifAmqhY5uQydDew1OG49zgWiKMKwW6/uKxx+g=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=A9yRTCpVv1OW31qXCYipnFdjOu5N5QSihN0rbj7r6OfKAFBBHDzYLx9uVm1/CJcNo t4nDfqZOV1pghbpZwCh8dLSE7VT/FCKtYAiJp4mE1AmYlpHShG01MK2+Bf2M0iFnV4 IYgX9zKxeb2vL3jJ1wrD7p0FUbmbo6Ri+PFKrY7O3IWpH/tK6VFbDUP8tg4V/pD3kE zZljgZVCqvFpisY8WUR/b2oSmMU1RDyvmeBrSJV/wFT/PzioHobbWKzFcrXsp7AYs3 J4YoqmeZCCHfOpBu8iNtEX9PSsXVFstsfA+7HR+XOs9USLwso3e3iIMVz1K/Gs1iJ/ Z6LGi6/LZSBVQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v12 27/36] phy: rockchip: usbdp: Handle rk_udphy_reset_deassert errors Reply-To: sashiko-reviews@lists.linux.dev To: "Sebastian Reichel" Cc: robh@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, vkoul@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260710-rockchip-usbdp-cleanup-v12-27-8b41a9a9bef0@collabora.com> References: <20260710-rockchip-usbdp-cleanup-v12-0-8b41a9a9bef0@collabora.com> <20260710-rockchip-usbdp-cleanup-v12-27-8b41a9a9bef0@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 10 Jul 2026 21:17:13 +0000 Message-Id: <20260710211713.99A891F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: Pre-existing issues: - [Medium] If PHY re-initialization fails during a mode change, the U3 port= is left permanently disabled and in reset, but the software state incorrec= tly remains active. -- --- Patch [27]: [PATCH v12 27/36] phy: rockchip: usbdp: Handle rk_udphy_res= et_deassert errors --- commit 00e32198a00a3780b193e546b8f16d2218cefb74 Author: Sebastian Reichel phy: rockchip: usbdp: Handle rk_udphy_reset_deassert errors This commit modifies the initialization sequence to handle errors returned by reset deassertion, avoiding a theoretical SError. Fixes: 2f70bbddeb45 ("phy: rockchip: add usbdp combo phy driver") Reported-by: Sashiko Closes: https://sashiko.dev/#/message/20260626211151.2332F1F000E9%40smtp.ke= rnel.org > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rock= chip/phy-rockchip-usbdp.c > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -803,8 +803,12 @@ static int rk_udphy_init(struct rk_udphy *udphy) > /* Step 1: power on pma and deassert apb rstn */ > rk_udphy_grfreg_write(udphy->udphygrf, &cfg->grfcfg.low_pwrn, true); > =20 > - rk_udphy_reset_deassert(udphy, "pma_apb"); > - rk_udphy_reset_deassert(udphy, "pcs_apb"); > + ret =3D rk_udphy_reset_deassert(udphy, "pma_apb"); > + if (ret) > + goto assert_resets; [Severity: Medium] This is a pre-existing issue, but returning an error here propagates up to rk_udphy_power_on(). Does this leave the U3 port in a permanently disabled state? When USB3 is active and a new mode is enabled, rk_udphy_power_on() triggers re-initialization. It disables the U3 port and calls rk_udphy_init(). If rk_udphy_init() fails and returns an error here, the caller propagates it immediately: rk_udphy_power_on() { ... ret =3D rk_udphy_init(udphy); if (ret) return ret; if (udphy->mode & UDPHY_MODE_USB) rk_udphy_u3_port_disable(udphy, false); ... } If this path is taken, the U3 port is left permanently disabled and in rese= t, but the software state (udphy->status) incorrectly remains active. The USB3 controller is unaware that the PHY has been forced into reset.=20 Could this result in a silently dropped USB3 connection, potentially causing I/O errors for active storage devices?=20 While a previous patch in the series mitigates the SError by safely routing the PIPE clock to UTMI, the state inconsistency and dead USB connection seem to remain. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260710-rockchip-u= sbdp-cleanup-v12-0-8b41a9a9bef0@collabora.com?part=3D27 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6788DC43458 for ; Fri, 10 Jul 2026 21:17:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V0SgZLhUKJnCNTzbXwZkT4MZhpgn/YVCMbwN+5NMD48=; b=pAnY76VxBv1mMN 6E+X8giVYRKbrOXpQ00HBXDb3GrUgXlQBhEewIpYKuMT9F08jg7WZ6+p4APfw54RUm5MXm8q+6gHj HN7ka1huvGR3QvO14VT3P5QTEVTNjLTF+Sn4hq4zj9DbhSOh1YzUWEVuph/pwqzeYv18G183fA1l/ gUKirZ5DQ94q45drNcmLnhbmBAIe9GNarORfjOSehR2TqWK1/lVEDvJShbdLqzSgOr9UkxHaPx/su lfeezedLyVlz9o1kNTUURq/5LnumvtfQo4RrXv/LCSsLpJrbn69oornnKm2tO8sJg85ezhFdUy5ju ZQrhcDYF/s8yyEEng2nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wiIay-00000005mxk-0lJB; Fri, 10 Jul 2026 21:17:16 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wiIaw-00000005mxZ-20dy for linux-phy@lists.infradead.org; Fri, 10 Jul 2026 21:17:14 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 3653B401DA; Fri, 10 Jul 2026 21:17:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99A891F000E9; Fri, 10 Jul 2026 21:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783718234; bh=3kAKtJifAmqhY5uQydDew1OG49zgWiKMKwW6/uKxx+g=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=A9yRTCpVv1OW31qXCYipnFdjOu5N5QSihN0rbj7r6OfKAFBBHDzYLx9uVm1/CJcNo t4nDfqZOV1pghbpZwCh8dLSE7VT/FCKtYAiJp4mE1AmYlpHShG01MK2+Bf2M0iFnV4 IYgX9zKxeb2vL3jJ1wrD7p0FUbmbo6Ri+PFKrY7O3IWpH/tK6VFbDUP8tg4V/pD3kE zZljgZVCqvFpisY8WUR/b2oSmMU1RDyvmeBrSJV/wFT/PzioHobbWKzFcrXsp7AYs3 J4YoqmeZCCHfOpBu8iNtEX9PSsXVFstsfA+7HR+XOs9USLwso3e3iIMVz1K/Gs1iJ/ Z6LGi6/LZSBVQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v12 27/36] phy: rockchip: usbdp: Handle rk_udphy_reset_deassert errors To: "Sebastian Reichel" Cc: robh@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, vkoul@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20260710-rockchip-usbdp-cleanup-v12-27-8b41a9a9bef0@collabora.com> References: <20260710-rockchip-usbdp-cleanup-v12-0-8b41a9a9bef0@collabora.com> <20260710-rockchip-usbdp-cleanup-v12-27-8b41a9a9bef0@collabora.com> Date: Fri, 10 Jul 2026 21:17:13 +0000 Message-Id: <20260710211713.99A891F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtNZWRpdW1dIElmIFBIWSByZS1pbml0aWFsaXphdGlvbiBmYWlscyBkdXJpbmcgYSBtb2RlIGNo YW5nZSwgdGhlIFUzIHBvcnQgaXMgbGVmdCBwZXJtYW5lbnRseSBkaXNhYmxlZCBhbmQgaW4gcmVz ZXQsIGJ1dCB0aGUgc29mdHdhcmUgc3RhdGUgaW5jb3JyZWN0bHkgcmVtYWlucyBhY3RpdmUuCi0t CgotLS0gUGF0Y2ggWzI3XTogW1BBVENIIHYxMiAyNy8zNl0gcGh5OiByb2NrY2hpcDogdXNiZHA6 IEhhbmRsZSBya191ZHBoeV9yZXNldF9kZWFzc2VydCBlcnJvcnMgLS0tCmNvbW1pdCAwMGUzMjE5 OGEwMGEzNzgwYjE5M2U1NDZiOGYxNmQyMjE4Y2VmYjc0CkF1dGhvcjogU2ViYXN0aWFuIFJlaWNo ZWwgPHNlYmFzdGlhbi5yZWljaGVsQGNvbGxhYm9yYS5jb20+CgpwaHk6IHJvY2tjaGlwOiB1c2Jk cDogSGFuZGxlIHJrX3VkcGh5X3Jlc2V0X2RlYXNzZXJ0IGVycm9ycwoKVGhpcyBjb21taXQgbW9k aWZpZXMgdGhlIGluaXRpYWxpemF0aW9uIHNlcXVlbmNlIHRvIGhhbmRsZSBlcnJvcnMgcmV0dXJu ZWQKYnkgcmVzZXQgZGVhc3NlcnRpb24sIGF2b2lkaW5nIGEgdGhlb3JldGljYWwgU0Vycm9yLgoK Rml4ZXM6IDJmNzBiYmRkZWI0NSAoInBoeTogcm9ja2NoaXA6IGFkZCB1c2JkcCBjb21ibyBwaHkg ZHJpdmVyIikKUmVwb3J0ZWQtYnk6IFNhc2hpa28gPHNhc2hpa28tYm90QGtlcm5lbC5vcmc+CkNs b3NlczogaHR0cHM6Ly9zYXNoaWtvLmRldi8jL21lc3NhZ2UvMjAyNjA2MjYyMTExNTEuMjMzMkYx RjAwMEU5JTQwc210cC5rZXJuZWwub3JnCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9yb2Nr Y2hpcC9waHktcm9ja2NoaXAtdXNiZHAuYyBiL2RyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2Nr Y2hpcC11c2JkcC5jCj4gLS0tIGEvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLXVz YmRwLmMKPiArKysgYi9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtdXNiZHAuYwo+ IEBAIC04MDMsOCArODAzLDEyIEBAIHN0YXRpYyBpbnQgcmtfdWRwaHlfaW5pdChzdHJ1Y3Qgcmtf dWRwaHkgKnVkcGh5KQo+ICAJLyogU3RlcCAxOiBwb3dlciBvbiBwbWEgYW5kIGRlYXNzZXJ0IGFw YiByc3RuICovCj4gIAlya191ZHBoeV9ncmZyZWdfd3JpdGUodWRwaHktPnVkcGh5Z3JmLCAmY2Zn LT5ncmZjZmcubG93X3B3cm4sIHRydWUpOwo+ICAKPiAtCXJrX3VkcGh5X3Jlc2V0X2RlYXNzZXJ0 KHVkcGh5LCAicG1hX2FwYiIpOwo+IC0JcmtfdWRwaHlfcmVzZXRfZGVhc3NlcnQodWRwaHksICJw Y3NfYXBiIik7Cj4gKwlyZXQgPSBya191ZHBoeV9yZXNldF9kZWFzc2VydCh1ZHBoeSwgInBtYV9h cGIiKTsKPiArCWlmIChyZXQpCj4gKwkJZ290byBhc3NlcnRfcmVzZXRzOwoKW1NldmVyaXR5OiBN ZWRpdW1dClRoaXMgaXMgYSBwcmUtZXhpc3RpbmcgaXNzdWUsIGJ1dCByZXR1cm5pbmcgYW4gZXJy b3IgaGVyZSBwcm9wYWdhdGVzIHVwIHRvCnJrX3VkcGh5X3Bvd2VyX29uKCkuIERvZXMgdGhpcyBs ZWF2ZSB0aGUgVTMgcG9ydCBpbiBhIHBlcm1hbmVudGx5IGRpc2FibGVkCnN0YXRlPwoKV2hlbiBV U0IzIGlzIGFjdGl2ZSBhbmQgYSBuZXcgbW9kZSBpcyBlbmFibGVkLCBya191ZHBoeV9wb3dlcl9v bigpIHRyaWdnZXJzCnJlLWluaXRpYWxpemF0aW9uLiBJdCBkaXNhYmxlcyB0aGUgVTMgcG9ydCBh bmQgY2FsbHMgcmtfdWRwaHlfaW5pdCgpLiBJZgpya191ZHBoeV9pbml0KCkgZmFpbHMgYW5kIHJl dHVybnMgYW4gZXJyb3IgaGVyZSwgdGhlIGNhbGxlciBwcm9wYWdhdGVzIGl0CmltbWVkaWF0ZWx5 OgoKcmtfdWRwaHlfcG93ZXJfb24oKSB7CiAgICAgICAgLi4uCiAgICAgICAgcmV0ID0gcmtfdWRw aHlfaW5pdCh1ZHBoeSk7CiAgICAgICAgaWYgKHJldCkKICAgICAgICAgICAgICAgIHJldHVybiBy ZXQ7CgogICAgICAgIGlmICh1ZHBoeS0+bW9kZSAmIFVEUEhZX01PREVfVVNCKQogICAgICAgICAg ICAgICAgcmtfdWRwaHlfdTNfcG9ydF9kaXNhYmxlKHVkcGh5LCBmYWxzZSk7CiAgICAgICAgLi4u Cn0KCklmIHRoaXMgcGF0aCBpcyB0YWtlbiwgdGhlIFUzIHBvcnQgaXMgbGVmdCBwZXJtYW5lbnRs eSBkaXNhYmxlZCBhbmQgaW4gcmVzZXQsCmJ1dCB0aGUgc29mdHdhcmUgc3RhdGUgKHVkcGh5LT5z dGF0dXMpIGluY29ycmVjdGx5IHJlbWFpbnMgYWN0aXZlLiBUaGUgVVNCMwpjb250cm9sbGVyIGlz IHVuYXdhcmUgdGhhdCB0aGUgUEhZIGhhcyBiZWVuIGZvcmNlZCBpbnRvIHJlc2V0LiAKCkNvdWxk IHRoaXMgcmVzdWx0IGluIGEgc2lsZW50bHkgZHJvcHBlZCBVU0IzIGNvbm5lY3Rpb24sIHBvdGVu dGlhbGx5IGNhdXNpbmcKSS9PIGVycm9ycyBmb3IgYWN0aXZlIHN0b3JhZ2UgZGV2aWNlcz8gCgpX aGlsZSBhIHByZXZpb3VzIHBhdGNoIGluIHRoZSBzZXJpZXMgbWl0aWdhdGVzIHRoZSBTRXJyb3Ig Ynkgc2FmZWx5IHJvdXRpbmcKdGhlIFBJUEUgY2xvY2sgdG8gVVRNSSwgdGhlIHN0YXRlIGluY29u c2lzdGVuY3kgYW5kIGRlYWQgVVNCIGNvbm5lY3Rpb24gc2VlbQp0byByZW1haW4uCgotLSAKU2Fz aGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwNzEw LXJvY2tjaGlwLXVzYmRwLWNsZWFudXAtdjEyLTAtOGI0MWE5YTliZWYwQGNvbGxhYm9yYS5jb20/ cGFydD0yNwoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtcGh5Cg==