From: Greg KH <gregkh@linuxfoundation.org>
To: Wang Zhaolong <wangzhaolong@fnnas.com>
Cc: Jing Wu <realwujing@gmail.com>,
jirislaby@kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org, yuanql9@chinatelecom.cn
Subject: Re: [PATCH v6] serial: 8250: fix use-after-free in IRQ chain handling
Date: Fri, 10 Jul 2026 14:17:33 +0200 [thread overview]
Message-ID: <2026071037-subprime-padding-3ba9@gregkh> (raw)
In-Reply-To: <5cf37150673ea4d5c28f94db91cdf68504b50522.9be37cbd.7a04.4d7e.b20e.d3f90675af6e@feishu.cn>
On Wed, Jul 08, 2026 at 04:30:21PM +0800, Wang Zhaolong wrote:
> Hi Jing,
>
> No.
>
> A changelog entry describes what changed between my v2 and my v3. It is not
> a claim that nobody else ever wrote a similar line in another patch.
>
> The functional fix in my series was already in my v1 on May 27. Whether my
> v1 commit message named the UAF or not does not change the code: holding the
> same mutex across link and unlink closes that window too. My v1 commit
> message intentionally described the failure mode I had reproduced and
> validated: the unbalanced IRQ enable warning. I did not want to overstate the
> impact beyond the evidence I had at the time.
>
> The v3 rename follows Jiri's review comment that hash_mutex is no longer an
> appropriate name. The __must_hold() and lockdep_assert_held() annotations
> document the locking rule after the mutex was moved to the caller. They are
> not the functional fix.
>
> I do not agree that Co-developed-by is appropriate for my patch, and I do not
> authorize adding a Co-developed-by tag for me without my Signed-off-by.
>
> I am not going to continue this argument. Maintainers can decide which patch,
> if any, to take.
As I said before, I'm not going to take either until you all can agree.
And yes, a co-developed-by does require a signed-off-by. Without you
all agreeing, none of this is going to be acceptable, sorry.
Also, all of these really look like they were created/found/whatever by
a LLM, which is not being documented, and for that reason alone I think
I need to reject all of these until that is properly addressed.
thanks,
greg k-h
next prev parent reply other threads:[~2026-07-10 12:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-07 14:06 [PATCH v6] serial: 8250: fix use-after-free in IRQ chain handling Qiliang Yuan
2026-07-08 6:03 ` Jiri Slaby
2026-07-08 6:34 ` Jing Wu
2026-07-08 7:11 ` Jing Wu
2026-07-08 7:33 ` Wang Zhaolong
2026-07-08 7:57 ` Jing Wu
2026-07-08 8:20 ` Wang Zhaolong
2026-07-08 7:39 ` Jing Wu
2026-07-08 7:53 ` Wang Zhaolong
2026-07-08 8:08 ` Jing Wu
2026-07-08 8:32 ` Wang Zhaolong
[not found] ` <5cf37150673ea4d5c28f94db91cdf68504b50522.9be37cbd.7a04.4d7e.b20e.d3f90675af6e@feishu.cn>
2026-07-10 12:17 ` Greg KH [this message]
2026-07-10 13:15 ` Wang Zhaolong
2026-07-10 13:28 ` Greg KH
2026-07-08 8:43 ` Jing Wu
2026-07-08 8:45 ` Jing Wu
-- strict thread matches above, loose matches on Subject: below --
2026-05-27 9:20 [PATCH] serial: 8250: serialize shared IRQ startup Wang Zhaolong
2026-07-08 3:11 ` [PATCH v2] serial: 8250: fix shared IRQ startup race causing IRQ warning Wang Zhaolong
2026-07-08 7:23 ` [PATCH v3] " Wang Zhaolong
2026-07-08 8:47 ` [PATCH v6] serial: 8250: fix use-after-free in IRQ chain handling Jing Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026071037-subprime-padding-3ba9@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=realwujing@gmail.com \
--cc=wangzhaolong@fnnas.com \
--cc=yuanql9@chinatelecom.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.