From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com (pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com [50.112.246.219]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 285841E5B88 for ; Sat, 11 Jul 2026 13:32:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=50.112.246.219 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783776779; cv=none; b=Zv6R1tQdhFRYPDNiwouA9K5Sut9gRtL6g6KjzU8dL9/7TtqChzwzjOk5GY5991XmJ/6NPLpCwZ8bI359OYacKMafyK1mQPe7KRy9BxtN3ZdQlnybudwINJ8OSaUyaDqDVXCJ7UMofLhZmgA2elmSmNKUHQcxj+xUb8SvxSxl1QM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783776779; c=relaxed/simple; bh=6N8s8WpDJzEut9jXnSmRAPwDpWrRRlwQ0OVCcst2cvY=; h=From:To:CC:Subject:Date:Message-ID:MIME-Version:Content-Type; b=pwzsI1tTmAqrH+WPYwEqf6/JYVcjkpZqz0i6EgqB0odKJJj5grLIivFEPn+PM0TP1j990EFIF/tOEgMLlUNObjv455SM46Hksy7u3ETJ41iJy5YnY8bzFfsYovtIea8nzPSg3QrgYouCY4G8fEkRnx2IO5ooOAmKgFw7tDiglJE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.jp; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b=b7hUmvAO; arc=none smtp.client-ip=50.112.246.219 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=amazon.com header.i=@amazon.com header.b="b7hUmvAO" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1783776778; x=1815312778; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=GKRJbIofdXLrYeFk4YuP+m2CmFCaXhx3FTzh99Bd4VA=; b=b7hUmvAOrVtRyzHsFbpkrJOnNiKZj9E+9cqZ+nsYk15xNzSt0PaoXmFE +v5Kj8QhA94VlHlsIO8mFAr2dugLdHnpflnv9yPcop8mNf2gg6MOYKLFA SXO2RED9LprojGdseanYpLCX2pqnK6qL65rkLftWHe6fK2VMkJeVwnLmB AWiwQryysTYsxSSSrFLrJi7dS73jOgWK3SF5XOFeclXoz6alQ0fTGOjuS /kRARCspuxCEiXPRlkj/XzcQZAu2gZI5ItZ7GJ2geJZVBZwl13/akaeer iVInxi4w+vE6Mh09YEkuF8ghCUvNKBZyR6noDIDjslE4tcc3yNMaxJJ8R w==; X-CSE-ConnectionGUID: vdyG+9NkRkGo+kSHQkLhww== X-CSE-MsgGUID: vzBp9IjDTPawjohMvXIupA== X-IronPort-AV: E=Sophos;i="6.25,154,1779148800"; d="scan'208";a="23288930" Received: from ip-10-5-9-48.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.9.48]) by internal-pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2026 13:32:52 +0000 Received: from EX19MTAUWB002.ant.amazon.com [205.251.233.111:25614] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.11.68:2525] with esmtp (Farcaster) id c035339e-bd81-4714-b361-2bc44f40193d; Sat, 11 Jul 2026 13:32:52 +0000 (UTC) X-Farcaster-Flow-ID: c035339e-bd81-4714-b361-2bc44f40193d Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWB002.ant.amazon.com (10.250.64.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 11 Jul 2026 13:32:52 +0000 Received: from 603e5f7bc1fe.amazon.com (10.37.245.7) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 11 Jul 2026 13:32:50 +0000 From: Takashi Kozu To: CC: , , , , , , , , , Takashi Kozu Subject: [PATCH iwl-next v1] igb: remove ASSERT_RTNL() from igb_write_rss_key() Date: Sat, 11 Jul 2026 22:32:15 +0900 Message-ID: <20260711133239.29270-2-takkozu@amazon.com> X-Mailer: git-send-email 2.47.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: EX19D040UWB003.ant.amazon.com (10.13.138.8) To EX19D001UWA001.ant.amazon.com (10.13.138.214) igb_runtime_resume() calls __igb_resume() with rpm=true, which skips rtnl_lock() to avoid deadlocks. On that path __igb_open() -> igb_configure() -> igb_setup_mrqc() -> igb_write_rss_key() runs without rtnl held, so ASSERT_RTNL() fires a false-positive WARN on every runtime resume. Drop it. Fixes: dfaf57ef99cf ("igb: prepare for RSS key get/set support") Signed-off-by: Takashi Kozu --- drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c index 65014a54a6d1..4eb586f9af99 100644 --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c @@ -3031,8 +3031,6 @@ void igb_write_rss_key(struct igb_adapter *adapter) { struct e1000_hw *hw = &adapter->hw; - ASSERT_RTNL(); - for (int i = 0; i < IGB_RSS_KEY_SIZE / 4; i++) { u32 val = get_unaligned_le32(&adapter->rss_key[i * 4]); -- 2.54.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0C6DC43458 for ; Sat, 11 Jul 2026 13:33:03 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 70A9260DAA; Sat, 11 Jul 2026 13:33:03 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id Ei-uFV5DxpKW; Sat, 11 Jul 2026 13:33:02 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 2A83460C2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1783776782; bh=GKRJbIofdXLrYeFk4YuP+m2CmFCaXhx3FTzh99Bd4VA=; h=From:To:CC:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=KMPBryYncaW0C6H4C9OtNnZgzaBSePFhHCPH+JPuSSZ7MJC35ebj+MM3tIg4MqR5G Mst2iCIBUl8gIjiw5GL8kJMvJpIMsiwwVBJkUJVAdRh4EbbIJEDynhh4p9zTo6c/cc W2BhR3T1XZjD5zfyRHysh+kkZbaY/DwDK0ca5NrGwwhXM+BwE4Y+NGT5XunBW9fGt6 LegIWKFZRUN+3QZZIfELy0JqmdqFN+6mfbEFUmY9nFQbPQn74tJk0qNrYQyz+M/GWQ oOZhwTzacuDrEQq679YikiyMUcV22qluSoiS+dthkTq2XL3mscuMXry7zrDIuG1LfB 4z+LiepkAxb6w== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp3.osuosl.org (Postfix) with ESMTP id 2A83460C2B; Sat, 11 Jul 2026 13:33:02 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id 3969122F for ; Sat, 11 Jul 2026 13:33:00 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 22C76404EE for ; Sat, 11 Jul 2026 13:33:00 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id j01CD4VWaMZw for ; Sat, 11 Jul 2026 13:32:59 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=50.112.246.219; helo=pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com; envelope-from=prvs=645d0ff52=takkozu@amazon.co.jp; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 14BDC401E7 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 14BDC401E7 Received: from pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com (pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com [50.112.246.219]) by smtp2.osuosl.org (Postfix) with ESMTPS id 14BDC401E7 for ; Sat, 11 Jul 2026 13:32:58 +0000 (UTC) X-CSE-ConnectionGUID: vdyG+9NkRkGo+kSHQkLhww== X-CSE-MsgGUID: vzBp9IjDTPawjohMvXIupA== X-IronPort-AV: E=Sophos;i="6.25,154,1779148800"; d="scan'208";a="23288930" Received: from ip-10-5-9-48.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.9.48]) by internal-pdx-out-015.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2026 13:32:52 +0000 Received: from EX19MTAUWB002.ant.amazon.com [205.251.233.111:25614] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.11.68:2525] with esmtp (Farcaster) id c035339e-bd81-4714-b361-2bc44f40193d; Sat, 11 Jul 2026 13:32:52 +0000 (UTC) X-Farcaster-Flow-ID: c035339e-bd81-4714-b361-2bc44f40193d Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWB002.ant.amazon.com (10.250.64.231) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 11 Jul 2026 13:32:52 +0000 Received: from 603e5f7bc1fe.amazon.com (10.37.245.7) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 11 Jul 2026 13:32:50 +0000 From: Takashi Kozu To: CC: , , , , , , , , , Takashi Kozu Date: Sat, 11 Jul 2026 22:32:15 +0900 Message-ID: <20260711133239.29270-2-takkozu@amazon.com> X-Mailer: git-send-email 2.47.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.37.245.7] X-ClientProxiedBy: EX19D040UWB003.ant.amazon.com (10.13.138.8) To EX19D001UWA001.ant.amazon.com (10.13.138.214) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1783776779; x=1815312779; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=GKRJbIofdXLrYeFk4YuP+m2CmFCaXhx3FTzh99Bd4VA=; b=LAa3bZmRenkUWXlDqKpEsBxbo8dkkWagceZ9jjYArA2N7NBPHWv0kPFO m6OaFzDf/7P1MqrQvwsfB/WPVvPkd36VxIgCQuXP2WHn4bHe28/QxkOe0 tuxXhTTuPsMt6TXvV5evgQM3nwhl7b/beeQV/OqoFPuvSS7TgomSbyNY9 iIr0d06rqaHod9ne+ZNblrtXu80GVKGgEnb52wbTxEKC0uaM0MwPELs4G 2yFSWG9qh9+J4WdGYdHEOPTOOranhHNOawI+ArSAxcAY8lpO9ISfjmXu5 RGEtqmb2r1GnQjqkR+zq0vf/tyJmyv82JF2SF9mcfIQaM6HwUgiqvdzlq w==; X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=amazon.com header.i=@amazon.com header.a=rsa-sha256 header.s=amazoncorp2 header.b=LAa3bZmR Subject: [Intel-wired-lan] [PATCH iwl-next v1] igb: remove ASSERT_RTNL() from igb_write_rss_key() X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" igb_runtime_resume() calls __igb_resume() with rpm=true, which skips rtnl_lock() to avoid deadlocks. On that path __igb_open() -> igb_configure() -> igb_setup_mrqc() -> igb_write_rss_key() runs without rtnl held, so ASSERT_RTNL() fires a false-positive WARN on every runtime resume. Drop it. Fixes: dfaf57ef99cf ("igb: prepare for RSS key get/set support") Signed-off-by: Takashi Kozu --- drivers/net/ethernet/intel/igb/igb_ethtool.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_ethtool.c b/drivers/net/ethernet/intel/igb/igb_ethtool.c index 65014a54a6d1..4eb586f9af99 100644 --- a/drivers/net/ethernet/intel/igb/igb_ethtool.c +++ b/drivers/net/ethernet/intel/igb/igb_ethtool.c @@ -3031,8 +3031,6 @@ void igb_write_rss_key(struct igb_adapter *adapter) { struct e1000_hw *hw = &adapter->hw; - ASSERT_RTNL(); - for (int i = 0; i < IGB_RSS_KEY_SIZE / 4; i++) { u32 val = get_unaligned_le32(&adapter->rss_key[i * 4]); -- 2.54.0