Re: [PATCH 2/2] arm64: dts: qcom: Add Xiaomi 11 Lite 5G NE

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Missing 'cd-gpios' property for the SD card interface (&sdhc_2), preventing reliable card insertion/removal detection.
- [Medium] Missing pinctrl configurations for the touchscreen and FSA4480 interrupt/reset GPIOs.
--

--- Patch [2]: [PATCH 2/2] arm64: dts: qcom: Add Xiaomi 11 Lite 5G NE ---
commit 22346a2ae0ab638635553e09fe60d37d9c64aa00
Author: Oleksii Onchul <oleksiionchul@gmail.com>

arm64: dts: qcom: Add Xiaomi 11 Lite 5G NE

Add initial support for the Xiaomi 11 Lite 5G NE, codenamed lisa.

> diff --git a/arch/arm64/boot/dts/qcom/sm7325-xiaomi-lisa.dts b/arch/arm64/boot/dts/qcom/sm7325-xiaomi-lisa.dts
> new file mode 100644
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm7325-xiaomi-lisa.dts

[ ... ]

> +	/* awinic,aw210xx_led @ 20 */
> +
> +	fsa4480: typec-mux@42 {
> +		compatible = "fcs,fsa4480";
> +		reg = <0x42>;
> +
> +		interrupts-extended = <&tlmm 2 IRQ_TYPE_LEVEL_LOW>;
> +
> +		vcc-supply = <&vreg_bob>;

[Severity: Medium]
Does the fsa4480 node need a pinctrl state to configure the pull-up for the
interrupt GPIO?

The FSA4480 interrupt pin is open-drain and typically requires a pull-up to
VDD. If the bootloader leaves this pin floating, could it cause an interrupt
storm or missed interrupts since no pinctrl-0 property is provided?

[ ... ]

> +&sdc2_data {
> +	drive-strength = <10>;
> +	bias-pull-up;
> +};
> +
> +&sdhc_2 {
> +	vmmc-supply = <&vreg_l7b_2p96>;
> +	vqmmc-supply = <&vreg_l19b_1p8>;
> +
> +	pinctrl-0 = <&sdc2_clk>, <&sdc2_cmd>, <&sdc2_data>;

[Severity: Medium]
Is a cd-gpios property missing from the &sdhc_2 node?

The commit message states that the SD card is supported, but without a card
detect GPIO, the MMC core might fall back to software polling (typically 1 Hz).
Could this polling prevent the SoC from entering deep sleep, causing a battery
drain on the device?

> +	pinctrl-1 = <&sdc2_clk_sleep>, <&sdc2_cmd_sleep>, <&sdc2_data_sleep>;
> +
> +	status = "okay";
> +};
> +
> +&spi13 {
> +	status = "okay";
> +
> +	touchscreen@0 {
> +		compatible = "goodix,gt9897";
> +		reg = <0>;
> +		spi-max-frequency = <6000000>;
> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <81 IRQ_TYPE_LEVEL_LOW>;
> +
> +		reset-gpios = <&tlmm 105 GPIO_ACTIVE_LOW>;

[Severity: Medium]
Are pinctrl configurations needed here for the touchscreen interrupt and reset
GPIOs?

This node declares an interrupt on tlmm 81 and a reset on tlmm 105, but it
does not specify a pinctrl-0 to configure the pinmux state and biases of
these pins. Relying on the bootloader's default pin state for active
interrupts and resets might lead to unexpected behavior or power leakage.

> +
> +		avdd-supply = <&vreg_l7c_3p0>;
> +		vddio-supply = <&vreg_l2c_1p8>;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260711184934.55701-1-oleksiionchul@gmail.com?part=2