From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78AF2C43458 for ; Sat, 11 Jul 2026 22:58:20 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wige7-00041f-Iw; Sat, 11 Jul 2026 18:58:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wige5-0003ym-NS; Sat, 11 Jul 2026 18:58:05 -0400 Received: from pdx-out-001.esa.us-west-2.outbound.mail-perimeter.amazon.com ([44.245.243.92]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wige3-0001QT-VX; Sat, 11 Jul 2026 18:58:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1783810684; x=1815346684; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yNBEYeoFV6RUHNn+yy3xUQpPv5kMRABtAu1z/mNwi8k=; b=F/YANnXdV9OGlCRQzCtI1+2P+VT3ViKa6acw6a7hVw3gYNMHChIFxlnK OFoSoMIYTwQYyZsmMZ3a6N777jOj+c0nmd5DnsrhtnCbpemWuDY+npulZ BGLZdiUmNIyszJVEKWmXqSFANkmdu9ROMX42idZmab6OMTK1HfNa1q8Hw j6W2flP7v+YA5R9Vc5EGsdjz1dUIv3Q8qa9xp0Hk+yRSt4WD9yRwsZdHe w+OcZu4r3dvOtaEHq23f3vb9ZWpeDtS0dWYzIitCW0BTGj2GsznuLTbyt la4oBTbZLxq+Uo8rlbEQpRJf+5D5KpieCFDfmIP1sT9UEC9f+StbZbdem w==; X-CSE-ConnectionGUID: kitu2YOpRaewwxdX4ANGTQ== X-CSE-MsgGUID: JWyq21BhQUatOA4oy1cDUQ== X-IronPort-AV: E=Sophos;i="6.25,154,1779148800"; d="scan'208";a="22997665" Received: from ip-10-5-6-203.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.6.203]) by internal-pdx-out-001.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2026 22:58:00 +0000 Received: from EX19MTAUWA001.ant.amazon.com [205.251.233.182:6951] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.11.68:2525] with esmtp (Farcaster) id b5dbb74e-0597-476d-bdf5-b1371377360a; Sat, 11 Jul 2026 22:58:00 +0000 (UTC) X-Farcaster-Flow-ID: b5dbb74e-0597-476d-bdf5-b1371377360a Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWA001.ant.amazon.com (10.250.64.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 11 Jul 2026 22:57:59 +0000 Received: from ip-10-253-83-51.amazon.com (172.19.99.218) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 11 Jul 2026 22:57:51 +0000 From: Alexander Graf To: CC: , , , , Song Gao <17746591750@163.com>, Aditya Gupta , Alexey Kardashevskiy , Farhan Ali , Alistair Francis , "Alistair Francis" , Antony Pavlov , Markus Armbruster , Artyom Tarasenko , BALATON Zoltan , Felipe Balbi , Christian Borntraeger , "Brian Cain" , Hendrik Brueckner , Chao Liu , "Huacai Chen" , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Helge Deller , Dorjoy Chowdhury , "Edgar E . Iglesias" , Alexandre Iooss , Eric Farman , Francisco Iglesias , Gaurav Sharma , "Gautam Gala" , Harsh Prateek Bora , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Jan Kiszka , Max Filippov , Joel Stanley , Jared Rossi , Tyrone Ting , Frederic Konrad , "Laurent Vivier" , Manos Pitsidianakis , Bibo Mao , "Mark Cave-Ayland" , Glenn Miles , Matthew Rosato , "Michael Rolnik" , "Michael S . Tsirkin" , "Niek Linnenbank" , Nicholas Piggin , Palmer Dabbelt , Halil Pasic , "Paolo Bonzini" , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Pierrick Bouvier" , Richard Henderson , Sai Pavan Boddu , Samuel Tardieu , Bernhard Beschow , Stafford Horne , Sergio Lopez , "Subbaraya Sundeep" , Thomas Huth , "Ran Wang" , Hao Wu , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Subject: [RFC PATCH 079/134] hw/xen: Give xenstore-driven backend devices a QOM parent Date: Sat, 11 Jul 2026 22:36:12 +0000 Message-ID: <20260711223707.42139-80-graf@amazon.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260711223707.42139-1-graf@amazon.com> References: <20260711223707.42139-1-graf@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.19.99.218] X-ClientProxiedBy: EX19D036UWC003.ant.amazon.com (10.13.139.214) To EX19D001UWA001.ant.amazon.com (10.13.138.214) Received-SPF: pass client-ip=44.245.243.92; envelope-from=prvs=645f258d4=graf@amazon.de; helo=pdx-out-001.esa.us-west-2.outbound.mail-perimeter.amazon.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org The XenBackendInfo .create callbacks (vif, console, vbd) create a XenDevice in response to xenstore hotplug events. The lifetime owner is the xen-bridge device that hosts the XenBus, so parent each device there. The failure paths already call object_unparent() so nothing else changes; the reference previously dropped by qdev_realize_and_unref() is now the parent's child<> property. Assisted-by: Kiro Signed-off-by: Alexander Graf --- hw/block/xen-block.c | 5 +++-- hw/char/xen_console.c | 5 +++-- hw/net/xen_nic.c | 5 +++-- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/hw/block/xen-block.c b/hw/block/xen-block.c index 9dd69faa02..46d94a9a95 100644 --- a/hw/block/xen-block.c +++ b/hw/block/xen-block.c @@ -1074,7 +1074,8 @@ static void xen_block_device_create(XenBackendInstance *backend, goto fail; } - xendev = XEN_DEVICE(qdev_new_orphan(type)); + xendev = XEN_DEVICE(qdev_new(OBJECT(BUS(xenbus)->parent), "vbd[*]", + type)); blockdev = XEN_BLOCK_DEVICE(xendev); if (!object_property_set_str(OBJECT(xendev), "vdev", vdev, @@ -1099,7 +1100,7 @@ static void xen_block_device_create(XenBackendInstance *backend, blockdev->iothread = iothread; blockdev->drive = drive; - if (!qdev_realize_and_unref(DEVICE(xendev), BUS(xenbus), errp)) { + if (!qdev_realize(DEVICE(xendev), BUS(xenbus), errp)) { error_prepend(errp, "realization of device %s failed: ", type); goto fail; } diff --git a/hw/char/xen_console.c b/hw/char/xen_console.c index cd440b82f4..40449b34e8 100644 --- a/hw/char/xen_console.c +++ b/hw/char/xen_console.c @@ -562,7 +562,8 @@ static void xen_console_device_create(XenBackendInstance *backend, goto fail; } - xendev = XEN_DEVICE(qdev_new_orphan(TYPE_XEN_CONSOLE_DEVICE)); + xendev = XEN_DEVICE(qdev_new(OBJECT(BUS(xenbus)->parent), "console[*]", + TYPE_XEN_CONSOLE_DEVICE)); con = XEN_CONSOLE_DEVICE(xendev); con->dev = number; @@ -610,7 +611,7 @@ static void xen_console_device_create(XenBackendInstance *backend, goto fail; } - if (qdev_realize_and_unref(DEVICE(xendev), BUS(xenbus), errp)) { + if (qdev_realize(DEVICE(xendev), BUS(xenbus), errp)) { xen_backend_set_device(backend, xendev); goto done; } diff --git a/hw/net/xen_nic.c b/hw/net/xen_nic.c index 212281aac7..ff748ae070 100644 --- a/hw/net/xen_nic.c +++ b/hw/net/xen_nic.c @@ -619,13 +619,14 @@ static void xen_net_device_create(XenBackendInstance *backend, goto fail; } - xendev = XEN_DEVICE(qdev_new_orphan(TYPE_XEN_NET_DEVICE)); + xendev = XEN_DEVICE(qdev_new(OBJECT(BUS(xenbus)->parent), "vif[*]", + TYPE_XEN_NET_DEVICE)); net = XEN_NET_DEVICE(xendev); net->dev = number; memcpy(&net->conf.macaddr, &mac, sizeof(mac)); - if (qdev_realize_and_unref(DEVICE(xendev), BUS(xenbus), errp)) { + if (qdev_realize(DEVICE(xendev), BUS(xenbus), errp)) { xen_backend_set_device(backend, xendev); return; } -- 2.47.1