From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA85CC44501 for ; Sat, 11 Jul 2026 23:00:32 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wigfl-0007mc-QH; Sat, 11 Jul 2026 18:59:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wigfZ-0007hk-CR; Sat, 11 Jul 2026 18:59:38 -0400 Received: from pdx-out-005.esa.us-west-2.outbound.mail-perimeter.amazon.com ([52.13.214.179]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wigfR-0001gL-I9; Sat, 11 Jul 2026 18:59:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1783810769; x=1815346769; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=kt2dEn9aFlPZ6cjaknzUQGuWA9n/MANpwwYTiQOngoY=; b=oVq7QlZv+1VWqJn4McSglzjUVaGd2CF7CgY3nEk1TzsFlAtRNaIfBo8g Qg8DqFaBrpGgQJwsS+6yWofNvVd5Ps3SFJcc7C+dGS0kYrFkMiLBjLvJ8 FKj4O0U6bzmW4bIxfzNQhGNdyn49BGzJgPE06X3rpj0+587cAakPU26A8 KYoWw+sE2Vr31CaOFeVVZltyr8gkHb4hL7Luq25xx2PRbzI5ukL7XHdUZ /fvAvVY1mBrM23MBUvak3bvJeYXN/0kVsEQC/83kv/qE30xYH1A3IZjXa GKkch7DIYAML3icvENIoLr1mnWuZueioO6p42+hLAgMUUmdDY/ctodWVM w==; X-CSE-ConnectionGUID: zl8Tf5aETLSFqDSBef0EaQ== X-CSE-MsgGUID: q7hwJd+rTQKjRsMPAeBvzQ== X-IronPort-AV: E=Sophos;i="6.25,154,1779148800"; d="scan'208";a="23479632" Received: from ip-10-5-6-203.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.6.203]) by internal-pdx-out-005.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2026 22:59:26 +0000 Received: from EX19MTAUWC002.ant.amazon.com [205.251.233.111:25563] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.31.54:2525] with esmtp (Farcaster) id c2daffbb-ed4d-49a0-935c-ffded380deb5; Sat, 11 Jul 2026 22:59:25 +0000 (UTC) X-Farcaster-Flow-ID: c2daffbb-ed4d-49a0-935c-ffded380deb5 Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWC002.ant.amazon.com (10.250.64.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 11 Jul 2026 22:59:25 +0000 Received: from ip-10-253-83-51.amazon.com (172.19.99.218) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 11 Jul 2026 22:59:16 +0000 From: Alexander Graf To: CC: , , , , Song Gao <17746591750@163.com>, Aditya Gupta , Alexey Kardashevskiy , Farhan Ali , Alistair Francis , "Alistair Francis" , Antony Pavlov , Markus Armbruster , Artyom Tarasenko , BALATON Zoltan , Felipe Balbi , Christian Borntraeger , "Brian Cain" , Hendrik Brueckner , Chao Liu , "Huacai Chen" , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Helge Deller , Dorjoy Chowdhury , "Edgar E . Iglesias" , Alexandre Iooss , Eric Farman , Francisco Iglesias , Gaurav Sharma , "Gautam Gala" , Harsh Prateek Bora , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Jan Kiszka , Max Filippov , Joel Stanley , Jared Rossi , Tyrone Ting , Frederic Konrad , "Laurent Vivier" , Manos Pitsidianakis , Bibo Mao , "Mark Cave-Ayland" , Glenn Miles , Matthew Rosato , "Michael Rolnik" , "Michael S . Tsirkin" , "Niek Linnenbank" , Nicholas Piggin , Palmer Dabbelt , Halil Pasic , "Paolo Bonzini" , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Pierrick Bouvier" , Richard Henderson , Sai Pavan Boddu , Samuel Tardieu , Bernhard Beschow , Stafford Horne , Sergio Lopez , "Subbaraya Sundeep" , Thomas Huth , "Ran Wang" , Hao Wu , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Subject: [RFC PATCH 084/134] isa: Remove *_orphan() creator variants Date: Sat, 11 Jul 2026 22:36:17 +0000 Message-ID: <20260711223707.42139-85-graf@amazon.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260711223707.42139-1-graf@amazon.com> References: <20260711223707.42139-1-graf@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.19.99.218] X-ClientProxiedBy: EX19D031UWA004.ant.amazon.com (10.13.139.19) To EX19D001UWA001.ant.amazon.com (10.13.138.214) Received-SPF: pass client-ip=52.13.214.179; envelope-from=prvs=645f258d4=graf@amazon.de; helo=pdx-out-005.esa.us-west-2.outbound.mail-perimeter.amazon.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org All boards create their ISA devices with an explicit QOM parent now. Drop isa_new_orphan(), isa_try_new_orphan() and isa_create_simple_orphan(). Assisted-by: Kiro Signed-off-by: Alexander Graf --- hw/isa/isa-bus.c | 19 ------------------- include/hw/isa/isa.h | 3 --- 2 files changed, 22 deletions(-) diff --git a/hw/isa/isa-bus.c b/hw/isa/isa-bus.c index 7a6a595ce7..22452e5048 100644 --- a/hw/isa/isa-bus.c +++ b/hw/isa/isa-bus.c @@ -172,25 +172,6 @@ ISADevice *isa_create_simple(Object *parent, const char *id, return dev; } -ISADevice *isa_new_orphan(const char *name) -{ - return ISA_DEVICE(qdev_new_orphan(name)); -} - -ISADevice *isa_try_new_orphan(const char *name) -{ - return ISA_DEVICE(qdev_try_new_orphan(name)); -} - -ISADevice *isa_create_simple_orphan(ISABus *bus, const char *name) -{ - ISADevice *dev; - - dev = isa_new_orphan(name); - isa_realize_and_unref(dev, bus, &error_fatal); - return dev; -} - bool isa_realize_and_unref(ISADevice *dev, ISABus *bus, Error **errp) { return qdev_realize_and_unref(&dev->parent_obj, &bus->parent_obj, errp); diff --git a/include/hw/isa/isa.h b/include/hw/isa/isa.h index 79bfe16361..9bbaa3c258 100644 --- a/include/hw/isa/isa.h +++ b/include/hw/isa/isa.h @@ -86,10 +86,7 @@ ISADevice *isa_new(Object *parent, const char *id, const char *type); ISADevice *isa_try_new(Object *parent, const char *id, const char *type); ISADevice *isa_create_simple(Object *parent, const char *id, ISABus *bus, const char *type); -ISADevice *isa_new_orphan(const char *name); -ISADevice *isa_try_new_orphan(const char *name); bool isa_realize_and_unref(ISADevice *dev, ISABus *bus, Error **errp); -ISADevice *isa_create_simple_orphan(ISABus *bus, const char *name); ISADevice *isa_vga_init(Object *parent, ISABus *bus); -- 2.47.1