From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05FC8C43458 for ; Sat, 11 Jul 2026 23:00:31 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wigfm-0007nG-Eq; Sat, 11 Jul 2026 18:59:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wigfd-0007ig-Ke; Sat, 11 Jul 2026 18:59:41 -0400 Received: from pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com ([52.42.203.116]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wigfb-0001hP-2V; Sat, 11 Jul 2026 18:59:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazoncorp2; t=1783810779; x=1815346779; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=gBcEts84ZIYAz9zRMafRNPfwwiJh1etqTPkZjTQFf84=; b=L2BpielHtSs1nujGFKQ++6ukZrnFoZJHw8748iplVwWM7FiJdrP9sqbN XJrhyzbmP6HF80h7yTfQ0TGH6Yo5a9wIaqNz+dKyg1nmfNNlWSuP7KPQe F1gNqKBvBIhoneHCwHvxeN5Q5HWG+YoDQgHUWr6HCrYVa9WocNRhZvc7v 8Yp5ozxSltcDSdjNSth5+/KWD3Q9L33zMoNew6k4YFEb0uTrJrMMU95mA w/XNhAGf8B4O50nUoCmlKLfpmc7JBDDdtzOozDJMC6xaNDFzTFa8nLaY7 nu8RwhG4XatmqDBJNtMugFEYEdeRKTFoWT06mCP3RrWamJTDm3LRKIZqs g==; X-CSE-ConnectionGUID: yVG49PCjTMuBJEmSwSoFMw== X-CSE-MsgGUID: IDbeA9UDQlWom4oE1ICN0w== X-IronPort-AV: E=Sophos;i="6.25,154,1779148800"; d="scan'208";a="23518022" Received: from ip-10-5-12-219.us-west-2.compute.internal (HELO smtpout.naws.us-west-2.prod.farcaster.email.amazon.dev) ([10.5.12.219]) by internal-pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jul 2026 22:59:34 +0000 Received: from EX19MTAUWA001.ant.amazon.com [205.251.233.236:1948] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.11.68:2525] with esmtp (Farcaster) id 59f2ed00-d7b5-4d27-81c6-fe8ebf77dc0b; Sat, 11 Jul 2026 22:59:34 +0000 (UTC) X-Farcaster-Flow-ID: 59f2ed00-d7b5-4d27-81c6-fe8ebf77dc0b Received: from EX19D001UWA001.ant.amazon.com (10.13.138.214) by EX19MTAUWA001.ant.amazon.com (10.250.64.218) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 11 Jul 2026 22:59:34 +0000 Received: from ip-10-253-83-51.amazon.com (172.19.99.218) by EX19D001UWA001.ant.amazon.com (10.13.138.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.2562.43; Sat, 11 Jul 2026 22:59:25 +0000 From: Alexander Graf To: CC: , , , , Song Gao <17746591750@163.com>, Aditya Gupta , Alexey Kardashevskiy , Farhan Ali , Alistair Francis , "Alistair Francis" , Antony Pavlov , Markus Armbruster , Artyom Tarasenko , BALATON Zoltan , Felipe Balbi , Christian Borntraeger , "Brian Cain" , Hendrik Brueckner , Chao Liu , "Huacai Chen" , =?UTF-8?q?Cl=C3=A9ment=20Chigot?= , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Helge Deller , Dorjoy Chowdhury , "Edgar E . Iglesias" , Alexandre Iooss , Eric Farman , Francisco Iglesias , Gaurav Sharma , "Gautam Gala" , Harsh Prateek Bora , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Jan Kiszka , Max Filippov , Joel Stanley , Jared Rossi , Tyrone Ting , Frederic Konrad , "Laurent Vivier" , Manos Pitsidianakis , Bibo Mao , "Mark Cave-Ayland" , Glenn Miles , Matthew Rosato , "Michael Rolnik" , "Michael S . Tsirkin" , "Niek Linnenbank" , Nicholas Piggin , Palmer Dabbelt , Halil Pasic , "Paolo Bonzini" , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , "Pierrick Bouvier" , Richard Henderson , Sai Pavan Boddu , Samuel Tardieu , Bernhard Beschow , Stafford Horne , Sergio Lopez , "Subbaraya Sundeep" , Thomas Huth , "Ran Wang" , Hao Wu , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= Subject: [RFC PATCH 085/134] pci: Remove *_orphan() creator variants Date: Sat, 11 Jul 2026 22:36:18 +0000 Message-ID: <20260711223707.42139-86-graf@amazon.com> X-Mailer: git-send-email 2.47.1 In-Reply-To: <20260711223707.42139-1-graf@amazon.com> References: <20260711223707.42139-1-graf@amazon.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.19.99.218] X-ClientProxiedBy: EX19D031UWA004.ant.amazon.com (10.13.139.19) To EX19D001UWA001.ant.amazon.com (10.13.138.214) Received-SPF: pass client-ip=52.42.203.116; envelope-from=prvs=645f258d4=graf@amazon.de; helo=pdx-out-008.esa.us-west-2.outbound.mail-perimeter.amazon.com X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org Sender: qemu-arm-bounces+qemu-arm=archiver.kernel.org@nongnu.org All boards create their PCI devices with an explicit QOM parent now. Drop pci_new_orphan(), pci_new_multifunction_orphan(), pci_create_simple_orphan(), pci_create_simple_multifunction_orphan() and the internal pci_new_internal() they wrapped. Assisted-by: Kiro Signed-off-by: Alexander Graf --- hw/pci/pci.c | 35 ----------------------------------- include/hw/pci/pci.h | 5 ----- 2 files changed, 40 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index ca5882ba59..5ef9dfa8b7 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -2388,16 +2388,6 @@ static void pci_qdev_realize(DeviceState *qdev, Error **errp) pci_dev->msi_trigger = pci_msi_trigger; } -static PCIDevice *pci_new_internal(int devfn, bool multifunction, - const char *name) -{ - DeviceState *dev; - - dev = qdev_new_orphan(name); - qdev_prop_set_int32(dev, "addr", devfn); - qdev_prop_set_bit(dev, "multifunction", multifunction); - return PCI_DEVICE(dev); -} static PCIDevice *pci_new_child_internal(Object *parent, const char *id, int devfn, bool multifunction, @@ -2440,36 +2430,11 @@ PCIDevice *pci_create_simple(Object *parent, const char *id, return dev; } -PCIDevice *pci_new_multifunction_orphan(int devfn, const char *name) -{ - return pci_new_internal(devfn, true, name); -} - -PCIDevice *pci_new_orphan(int devfn, const char *name) -{ - return pci_new_internal(devfn, false, name); -} - bool pci_realize_and_unref(PCIDevice *dev, PCIBus *bus, Error **errp) { return qdev_realize_and_unref(&dev->qdev, &bus->qbus, errp); } -PCIDevice *pci_create_simple_multifunction_orphan(PCIBus *bus, int devfn, - const char *name) -{ - PCIDevice *dev = pci_new_multifunction_orphan(devfn, name); - pci_realize_and_unref(dev, bus, &error_fatal); - return dev; -} - -PCIDevice *pci_create_simple_orphan(PCIBus *bus, int devfn, const char *name) -{ - PCIDevice *dev = pci_new_orphan(devfn, name); - pci_realize_and_unref(dev, bus, &error_fatal); - return dev; -} - static uint8_t pci_find_space(PCIDevice *pdev, uint8_t size) { int offset = PCI_CONFIG_HEADER_SIZE; diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 9c6bcc0b96..d6191fc529 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -1098,13 +1098,8 @@ PCIDevice *pci_create_simple_multifunction(Object *parent, const char *id, PCIDevice *pci_create_simple(Object *parent, const char *id, PCIBus *bus, int devfn, const char *type); -PCIDevice *pci_new_multifunction_orphan(int devfn, const char *name); -PCIDevice *pci_new_orphan(int devfn, const char *name); bool pci_realize_and_unref(PCIDevice *dev, PCIBus *bus, Error **errp); -PCIDevice *pci_create_simple_multifunction_orphan(PCIBus *bus, int devfn, - const char *name); -PCIDevice *pci_create_simple_orphan(PCIBus *bus, int devfn, const char *name); void lsi53c8xx_handle_legacy_cmdline(DeviceState *lsi_dev); -- 2.47.1