Re: [PATCH] tests/functional: fix querying available machines

[Thomas Huth <th.huth+qemu@posteo.eu>]

Am Fri, 10 Jul 2026 12:03:17 +0300
schrieb Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>:

> Aliases are not handled, and that's why tests used them
> are skipped, like this:
> 
>     PYTHONPATH=python:tests/functional \
>     QEMU_TEST_QEMU_BINARY=$PWD/build/qemu-system-x86_64 \
>     MESON_BUILD_ROOT=$PWD/build \
>     ./build/pyvenv/bin/python3 tests/functional/x86_64/test_hotplug_blk.py
> 
> TAP version 13
> ok 1 test_hotplug_blk.HotPlugBlk.test # SKIP no support for machine q35
> 1..1
> 
> Fixes: 0e7aa78b0bee50 ("tests/functional: use QMP to query available machines")
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
> ---
>  tests/functional/qemu_test/testcase.py | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py
> index 4912a47a464..e4179d165c0 100644
> --- a/tests/functional/qemu_test/testcase.py
> +++ b/tests/functional/qemu_test/testcase.py
> @@ -325,9 +325,12 @@ def set_machine(self, machinename):
>                  resp = tmp_vm.qmp('query-machines')
>  
>                  machines = resp.get('return', [])
> -                cls._machines = [
> -                    m.get('name') for m in machines if 'name' in m
> -                ]
> +                cls._machines = []
> +                for m in machines:
> +                    if 'name' in m:
> +                        cls._machines.append(m['name'])
> +                    if 'alias' in m:
> +                        cls._machines.append(m['alias'])

Thanks for the fix!

Reviewed-by: Thomas Huth <th.huth+qemu@posteo.eu>