Re: [PATCH v3] dt-bindings: net: microchip,lan78xx: convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The converted DT schema incorrectly rejects a 0-length `microchip,led-modes` property, breaking backward compatibility.
- [Medium] Silently dropping an active maintainer from the MAINTAINERS file without explanation.
--

--- Patch [1]: [PATCH v3] dt-bindings: net: microchip,lan78xx: convert to DT schema ---
commit 2888aafe795bb2f999fce4b5a449417cdf27043b
Author: Mikhail Lukianchikov <avermoal@gmail.com>

dt-bindings: net: microchip,lan78xx: convert to DT schema

Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding
documentation from plain text to DT schema. The conversion adds proper
validation for the 'microchip,led-modes' property inside the MDIO node.

Link: https://lore.kernel.org/netdev/20260709181724.24682-2-avermoal@gmail.com

> diff --git a/Documentation/devicetree/bindings/net/microchip,lan7800.yaml b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
> new file mode 100644
> index 0000000000000..730999d11e8a0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
[ ... ]
> +        properties:
> +          microchip,led-modes:
> +            $ref: /schemas/types.yaml#/definitions/uint32-array
> +            minItems: 1

[Severity: Medium]
Does setting minItems to 1 here improperly reject a 0-length property?

The original text binding specified this as a 0..4 element vector. If a device
tree uses an empty property to explicitly disable all LEDs, it will now fail
schema validation.

> +            maxItems: 4
> +            description:
> +              Array of LED mode values for each of up to 4 LEDs.
[ ... ]
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f37a81950e250..157a677a284fc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -27928,10 +27928,9 @@ F:	drivers/usb/isp1760/*
>  USB LAN78XX ETHERNET DRIVER
>  M:	Thangaraj Samynathan <Thangaraj.S@microchip.com>
>  M:	Rengarajan Sundararajan <Rengarajan.S@microchip.com>
> -M:	UNGLinuxDriver@microchip.com

[Severity: Medium]
This isn't a bug, but was the UNGLinuxDriver@microchip.com maintainer email
intentionally removed?

The commit message doesn't mention dropping this group email, which will no
longer be automatically CC'd on patches to the LAN78XX driver.

>  L:	netdev@vger.kernel.org
>  S:	Maintained

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260711105537.11065-2-avermoal@gmail.com?part=1