From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E97333A4F46 for ; Sun, 12 Jul 2026 11:07:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783854424; cv=none; b=XlGuRH9YzG8aVhdM+m2DeeGHztJF0GtGZQ2RAVx/o5zeDa2T63gdmuFDKOHgvfZT6zKGPSo0vj4B+HR6V+tfsG4AjZn85IFq9qNySNReIqjPSkcNeutqaR9X4zFAMIcY0j1mD5VdKoSTvZ4nStac5CD7XZKizd9EUw0+x79icVk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783854424; c=relaxed/simple; bh=hqwhm5yMZbYQQNjByQ/P15bH7yCPNSDUo0ZEsdjWMtE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=V8JhHUn3CWbT03GzCiJFgPa+AKJ4FePSar5z/6wsx3LSGBQPqPxMFgocykI9LvEFcGXAbA708Xw317SCcHrcLjReIIWqVmM+lazkCFg2Ep96iSwIPBq8Ci9qzDOmnVQQWoi9Vj6Yl8OkvzFspEhNP5P3p2gc/e9om66OXHH+KFg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bT3WBNY+; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bT3WBNY+" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-493b1710405so10407645e9.2 for ; Sun, 12 Jul 2026 04:07:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1783854421; x=1784459221; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=9iws13+QwWBruAinC9XI5/ioQWRS+EiwGg/eqYj2Vcg=; b=bT3WBNY+rFqL4UWpc/rqW8yAdmM1Holu5XywrXdv36PWh+7WSe3SKJA2wrNL9KJqOZ xkZLP1D6EKhLZNgXlFijANVNs6eaBAYlGTqgAsg5OtaFm/xmDTRN2j/pJqTROLJ3+iU/ aZBqfd+OBTY6Nksl+shBZm3AU+iw+tmUmLFJqitFgdjjEknyhmy0x0oUyZhDyXTOafKo X93y/htSAjZFAC3EJUgYHu1NxtZPOQUqovHMkxr6FijQ1DuyPzr5+Whfp5YGgNCn+3t8 Q4KW6ccVsh6aTIgnGnLNHm8QVxLcl53mGSaQOLiaUKrNiJpMFp0RVq1mZo72ZI3L3AYz aA8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783854421; x=1784459221; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=9iws13+QwWBruAinC9XI5/ioQWRS+EiwGg/eqYj2Vcg=; b=ne8CGKVwmgPnfwxCB/PH3yKqYtrflLq/2SDp23CLplSsWm6+R3J/2GXTcscfywF+0e IqNsvPcKLHeLDKyqa1RyMzkBMNDAmMgfEZy7jjGX+VXoacayfEL/HD7mUzOhaKgYzPbr pngZKxzxhsYCTWmSN9KXBtQPOIbFaJABrQV290M+7kZ4NaTgoMbtwfaFsUHnogUvhtSp w2kMeWai5ktxIqcBOF7EmJHlOl3vP6gwT8Bczp3BLIvGLoSdqd2A6CBpvxA62Wfd0FJR 2yWZSlEEvam1b4TIGMyWegDwgpS/E682tl47KoUSKaZm50KmkUCYBkmSQIOzCxfsbZoR jkOg== X-Forwarded-Encrypted: i=1; AHgh+RopVbihEx/ATiiTb+YLevaOkD4oEhNVC2qPvSgCg9KXgY9LKGlR9+Jg1strK0NuzUc7YyfocutQKgc6ZSY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx7Dvw9/bqnQUgDlRF950bLvT/r4HYo2uyc43wmFug7XDzcALmN ygUDFv97Ng2yvqr9bdaHl9DRT0RNKqY4rL0vrpyuv7+jUTbASxslvskG X-Gm-Gg: AfdE7cnhIlwiwJ1eACFOEjF+ivekrssl9rxpG8FmxBoflwqWBUjACeCfb+oaIAJ877+ AJ9Bbi7St6QMV447ayXAjlZ8q35aLrVeEMgLa6FuqXDSFmfAhX/xcLBnq0MwiurMfWCojKe2zzZ wTf7ABlTFcZD3jajRyfxPE1h310DTKynuTAm0MU3wJeyNi/V3f7DbEXrhQY2LarzYZ6iLjuNXUP A5MuWxjKdxzrLtedoTVUYAmoYGom0HPdmiD9Az4D9M2yjWVhpdSlBjqC9/7likLU6G/3RsfwP9k XvSkqZjfmsVk71k/djRN4ja3jHAslhR54XQ4dI9fVaPNAQgYhAnJLbEQJiB6gFdQdlEDPCKwtfO RrW9dft75FR4ek+Esq9m/elaSz4aapzelKUV+GbojI1UFzps01V/cOG+beXZpvr65ag2lGbJNoZ 2U/zoWGhIhMBw7h3nhkKjps5deh9lAygo= X-Received: by 2002:a05:600c:198f:b0:492:6efc:7c60 with SMTP id 5b1f17b1804b1-493f882933fmr49350145e9.28.1783854420895; Sun, 12 Jul 2026 04:07:00 -0700 (PDT) Received: from puma.museclub.art ([2a00:6020:b326:d300:d19:a765:d8d7:bedc]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-493eb6f3dcdsm273637625e9.3.2026.07.12.04.07.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Jul 2026 04:07:00 -0700 (PDT) From: Eugene Shalygin To: eugene.shalygin@gmail.com Cc: Guenter Roeck , linux-hwmon@vger.kernel.org (open list:ASUS EC HARDWARE MONITOR DRIVER), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 1/1] hwmon: (asus-ec-sensors) fix EC read intervals Date: Sun, 12 Jul 2026 13:05:03 +0200 Message-ID: <20260712110650.1240071-2-eugene.shalygin@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260712110650.1240071-1-eugene.shalygin@gmail.com> References: <20260712110650.1240071-1-eugene.shalygin@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Take INITIAL_JIFFIES into account when setting up next update time. Signed-off-by: Eugene Shalygin Fixes: d0ddfd241e57 ("hwmon: (asus-ec-sensors) add driver for ASUS EC") --- drivers/hwmon/asus-ec-sensors.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/hwmon/asus-ec-sensors.c b/drivers/hwmon/asus-ec-sensors.c index 29a23484cbe7..eb71e41fd4f4 100644 --- a/drivers/hwmon/asus-ec-sensors.c +++ b/drivers/hwmon/asus-ec-sensors.c @@ -1009,7 +1009,7 @@ struct ec_sensors_data { /* sorted list of unique register banks */ u8 banks[ASUS_EC_MAX_BANK + 1]; /* in jiffies */ - unsigned long last_updated; + u64 next_update; struct lock_data lock_data; /* number of board EC sensors */ u8 nr_sensors; @@ -1278,13 +1278,12 @@ static int get_cached_value_or_update(const struct device *dev, int sensor_index, struct ec_sensors_data *state, s32 *value) { - if (time_after(jiffies, state->last_updated + HZ)) { + if (time_after64(get_jiffies_64(), state->next_update)) { if (update_ec_sensors(dev, state)) { dev_err(dev, "update_ec_sensors() failure\n"); return -EIO; } - - state->last_updated = jiffies; + state->next_update = get_jiffies_64() + HZ; } *value = state->sensors[sensor_index].cached_value; @@ -1402,6 +1401,7 @@ static int asus_ec_probe(struct platform_device *pdev) if (!ec_data) return -ENOMEM; + ec_data->next_update = INITIAL_JIFFIES; dev_set_drvdata(dev, ec_data); ec_data->board_info = pboard_info; -- 2.55.0